Skip to content

FindRuby: Rename variables to match case of module name

Julien Marrec requested to merge jmarrec/cmake:20370_FindRuby_CamelCase into master

Use recommended case for variable names, i.e. matching name of the module as passed to find_package.

For backwards compatibility, the upper case versions of both input and output variables are used and defined when appropriate. Skip this for the _FOUND variable because FPHSA already does it.

This follows the approach from commit a7b09e7f that made the equivalent change for FindProtobuf.

Asked in !4386 (comment 707247)

Not sure if I need to provide backward compat for RUBY_FIND_VERSION_MAJOR, RUBY_FIND_VERSION_MINOR, RUBY_FIND_VERSION_EXACT. FindProtobuf doesn't do that.

Issue: #20370 (closed)
Topic-rename: FindRuby-variable-case

Edited by Brad King

Merge request reports