Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,226
    • Issues 3,226
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 17
    • Merge Requests 17
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge Requests
  • !2956

Merged
Opened Feb 12, 2019 by Zsolt Parragi@dutowContributor

cmListFileLexer: Add missing include to avoid possible pointer truncation

  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 2

The cmsys/Enconding.h include in cmListFileLexer.c had a typo in its sorruonding ifdef, possibly causing a missing function declaration (cmsysEncoding_DupToWide). As this is C code, this resulted in the code compiling, but with a truncated return value, possibly causing crashes.

Found when building with clang.exe on Windows.

Edited Feb 13, 2019 by Brad King
Assignee
Assign to
Reviewer
Request review from
3.14.0
Milestone
3.14.0 (Past due)
Assign milestone
Time tracking
Reference: cmake/cmake!2956
Source branch: fix-pointer-truncation