Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,226
    • Issues 3,226
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge Requests
  • !2908

Merged
Opened Feb 02, 2019 by Sebastian Holtermann@sebholtDeveloper

Refactor (and micro optimize) file detection in cmSourceFile

  • Overview 8
  • Commits 5
  • Pipelines 3
  • Changes 13

This topic branch refactors the file detection in cmSourceFile and adds some small optimizations there as well.

  • Additional static const strings in cmSourceFile should improve string comparison speeds
  • Convenience method cmSourceFile::GetIsGenerated() allows for fast checking whether a file is GENERATED
  • Refactoring cmSourceFile::FindFullPath avoids a few string re-computations
  • Fix for the case that a file was marked GENERATED after it's name was computed with an error
Edited Feb 02, 2019 by Sebastian Holtermann
Assignee
Assign to
Reviewer
Request review from
3.14.0
Milestone
3.14.0 (Past due)
Assign milestone
Time tracking
Reference: cmake/cmake!2908
Source branch: cmSourceFile_refactor