Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4,104
    • Issues 4,104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !2854

Help: prefer commit hashes in commit references

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ben Boeckel requested to merge ben.boeckel/cmake:commit-ref-in-prose into master Jan 24, 2019
  • Overview 10
  • Commits 1
  • Pipelines 4
  • Changes 1

The logic is that the describe output is readily available using git tag --contains locally. In addition, for a hypothetical commit which landed in both v3.9.4 and v3.10.1, there is no "better" tag to refer to. since v3.10.0's relation to such a commit is unclear either way.

Also mention that a Fixes trailer is preferred if the mention is just to indicate a commit which introduced an error rather than writing a complete sentence about it.


Thought it might be worth doing this in light of this week's Git Rev News where this covered.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: commit-ref-in-prose