Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,303
    • Issues 3,303
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge Requests
  • !2839

Merged
Created Jan 22, 2019 by Craig Scott@craig.scottMaintainer

cmake: Convert no source/build dir error to warning

  • Overview 14
  • Commits 4
  • Pipelines 3
  • Changes 5

This temporarily restores the previous behavior that allowed the cmake command line to have no source or build dir specified when at least one other option was given. The check for this that was introduced in 3.13.3 issued a fatal error, but this broke some user scripts that were relying on the (undocumented and unsupported) behavior. This MR downgrades that error to a warning with additional advisory comments.

The first commit should be reverted on master after this change is merged. This will restore the error for the check for the 3.14 release series. The second commit should not be reverted, it adds 3.13.4 release notes that will need to remain going forward.

Fixes: #18817 (closed)

Edited Jan 31, 2019 by Brad King
Assignee
Assign to
Reviewer
Request review from
3.13.4
Milestone
3.13.4 (Past due)
Assign milestone
Time tracking
Source branch: cmake-warn-no-src-build-dir