Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,306
    • Issues 3,306
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Merge Requests
  • !2748

Merged
Created Dec 16, 2018 by Alexander Grund@FlamefireContributor

Bundle fixes

  • Overview 46
  • Commits 5
  • Pipelines 14
  • Changes 8

When trying to use the BundleUtilities in a non-standard environment (e.g. cross-compilation) various bugs were found which are fixed by this MR:

  • install_name_tool was used verbatim although CMAKE_INSTALL_NAME_TOOL exists
  • otool -D was called instead of using the find_programed one which fails if it isn't in the PATH
  • verbose of get_prerequisites could not be enabled -> Added a global variable for that
  • Prefixed tools (e.g. x86_64-pc-linux-gnu-ldd) could not be used -> Check only last part of name
  • Scripts where passed to get_prerequisites by BundleUtilities if they were executable which caused a hard error. This is critical when wrapper scripts are the entry point of an OSX app Bundle as there was no way NOT to check that. -> Fixed in a lower level at GetPrerequisites which checks for .sh/.bat extension or shebang (!# at start of file). See also #18667 (closed)
Edited Dec 30, 2018 by Alexander Grund
Assignee
Assign to
Reviewer
Request review from
3.14.0
Milestone
3.14.0 (Past due)
Assign milestone
Time tracking
Source branch: bundle_fixes