Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • CMake CMake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4,100
    • Issues 4,100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMakeCMake
  • CMakeCMake
  • Merge requests
  • !1043

FindLibXml2: Switch to standard module variable names

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vadim Zhukov requested to merge grayed/cmake:findlibxml-standard-vars into master Jul 10, 2017
  • Overview 6
  • Commits 1
  • Pipelines 3
  • Changes 1

Now:

  • LIBXML2_INCLUDE_DIR talks about libxml2 itself;
  • LIBXML2_INCLUDE_DIRS lists also include directories coming from libxml2's dependencies and is what libxml2 users should use;
  • LIBXML2_LIBRARY talks about libxml2 itself;
  • LIBXML2_LIBRARIES is what libxml2 users should link to.

This commit doesn't break existing users of FindLibXml2.cmake, but provides the way for correct behaviour in future. In particular, on OpenBSD LIBXML2_INCLUDE_DIR resolves to /usr/local/include/libxml2, while libiconv (an libxml2 dependency) puts iconv.h in /usr/local/include, which is not picked up automatically.

Topic-rename: FindLibXml2-standard-vars

Edited Jul 14, 2017 by Brad King
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: findlibxml-standard-vars