Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,229
    • Issues 3,229
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 12
    • Merge Requests 12
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Issues
  • #21858

Closed
Open
Opened Feb 23, 2021 by Brad King@brad.kingOwner

presets: Remove undocumented non-standard JSON comment support

The CMakePresets.json format added in CMake 3.19 supports comments because its CMakeSettings.json predecessor from VS did. However, JSON comments are non-standard and not supported by all tooling.

CMake 3.19.[0-5] do not document support for the comments, but silently accept them. !5830 (merged) added documentation of the behavior for 3.20, which has not yet been released. Having thought more about this after !5830 (comment 906381), I think we should remove support for comments from the preset formats.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
3.19.6
Milestone
3.19.6 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: cmake/cmake#21858