install CMake in PATH by default
For the Windows installer cmake-3.19.0-win64-x64.msi, these choices are presented:
- Do not add CMake to the system PATH
- Add CMake to the system PATH for all users
- Add CMake to the system PATH for the current user
The default should be the most common and recommended choice. That ought to be the second one: "Add CMake to the system PATH for all users". In specialized cases where the administrator prefers one of the other options, they may certainly pick those.
Why is the change relevant? Well, chocolatey is a popular package manager, and when you install numerous packages with chocolatey you'd hope and expect they will all be functional after an installation. It's similar to apt or yum on Linux systems.
However, what currently happens is you install a dozen packages with chocolatey, and they all work correctly EXCEPT cmake! So, cmake requires some special configuration which is inconvenient and takes time to research.
Here are some quotes from https://github.com/chocolatey-community/chocolatey-coreteampackages/issues/987
"I ran into this problem today. I took me some time to figure it out. I would expect to be able to execute cmake after installing cmake. can we have this as a default?"
"The entire point of a package manager is being just an "install x" away from being able to type "x args" in the command line, with sane defaults. If I didn't want to add it to path, I'd look up flags. But the default with no flags should be a usable setup out of the box."
"But maybe it's not clear why it is not the default. Someone care to explain?"
"The default behavior should add cmake to the PATH. It is strange that this package does not add cmake to the path."