CMake profiling should treat command names case-insensitively
CMake 3.18 is introducing new profiling capabilities via the new --profiling-format
and --profiling-output
options. After trying this out with a range of different open source projects (very illuminating!), one problem I've observed is that projects don't always use consistent upper/lowercase names for commands. When the casing is different, they can't be aggregated and always appear as distinct commands in the trace output. Since CMake treats command names case-insensitively, we should ideally be writing consistent name casing into the profiling output.
I've only taken a very quick look, but perhaps we should be writing lff.Name.Lower
instead of lff.Name.Original
on this line?
Cc: @dublet