Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,187
    • Issues 3,187
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 14
    • Merge Requests 14
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • CMake
  • CMakeCMake
  • Issues
  • #18988

Closed
Open
Opened Feb 26, 2019 by Daniele E. Domenichelli@drdanzDeveloper

FindOctave should not include "octave" in `Octave_INCLUDE_DIR`

On my system (debian testing + CMake master) the FindOctave module sets the Octave_INCLUDE_DIR to /usr/include/octave-4.4.1/octave. This folder should be /usr/include/octave-4.4.1 instead. The same issue is inherited by the Octave::Octave target.

As far as I know, typically the files from octave are included passing the octave folder. For example, files generated by Swig include the files in this way:

#include <octave/oct.h>
#include <octave/version.h>

These file, at the moment, do not compile with the Octave::Octave target.

I recommend to fix this before CMake 3.14 final release, because this folders contains files like version.h, error.h, utils.h and more, that are very likely to cause conflicts. Also if people starts using it, it will be harder later to change it, keeping the compatibility and avoiding at the same time the conflicts.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
3.14.0
Milestone
3.14.0 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: cmake/cmake#18988