Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
CMake
CMake
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,235
    • Issues 3,235
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 14
    • Merge Requests 14
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CMake
  • CMakeCMake
  • Issues
  • #18973

Closed
Open
Opened Feb 23, 2019 by Craig Scott@craig.scottMaintainer

Output not captured from all check_<lang>_source_runs() implementations

While checking the implementation of the CheckFortranSourceRuns module added in CMake 3.14, I noticed that the check_c_source_runs() macro captures the output of its run and records it in CMakeOutput.log or CMakeError.log as appropriate, but neither check_fortran_source_runs() nor the existing check_cxx_source_runs() do. It would probably be wise to record this output for all languages so the user has a chance to see what happened if such tests fail.

Given that check_cxx_source_runs() also has this missing, should a fix for this be considered for the 3.14 release cycle or pushed back to 3.15? With check_fortran_source_runs() being new for 3.14, having the run's output available would seem fairly important while people try it out for the first time, so I'm leaning towards getting it addressed for 3.14.

Edited Feb 23, 2019 by Craig Scott
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: cmake/cmake#18973