1. 16 Oct, 2016 1 commit
    • Stephen Kelly's avatar
      cmTarget: Move sanity checks and computed property access to callers · c3fb0d95
      Stephen Kelly authored
      The GetProperty method is now just accessing contained data, meaning it
      can be implemented in cmState.
      
      Remove the cmMakefile context from the signature as a result and remove
      the overload with the same signature.
      
      Add a GetComputedProperty to cmTarget so that templates can be properly
      instantiated.  Otherwise the Commands would need to be able to reach the
      specializations which are currently in cmTarget.cxx.
      
      As a side-effect, the CMP0026 warning now gives a backtrace to the
      target when issued from a generator expression.
      c3fb0d95
  2. 15 Oct, 2016 13 commits
  3. 07 Oct, 2016 5 commits
  4. 03 Oct, 2016 1 commit
  5. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and lin...
      86578ecc
  6. 22 Sep, 2016 1 commit
    • Brad King's avatar
      Fix XCODE_ATTRIBUTE_..._LOCATION target property lookup · 764775c4
      Brad King authored
      Refactoring in commit v3.5.0-rc1~272^2~16 (cmGeneratorTarget: Add API for
      property keys, 2015-10-25) changed the Xcode generator implementation of
      `XCODE_ATTRIBUTE_...` properties to use the target `GetProperty` method on each
      `XCODE_ATTRIBUTE_...` property listed by `GetPropertyKeys` instead of looping
      over the property entries directly.  This made the lookup of property names of
      the form `XCODE_ATTRIBUTE_..._LOCATION` accidentally trigger the computed
      property logic for the undocumented/legacy `<CONFIG>_LOCATION` property.  Of
      course the computed property value is not the same as the value stored in the
      `XCODE_ATTRIBUTE_..._LOCATION` property.  Fix the computed property logic to
      avoid triggering on `XCODE_ATTRIBUTE_...` attributes.
      
      Closes: #16319
      764775c4
  7. 19 Sep, 2016 1 commit
  8. 15 Sep, 2016 1 commit
  9. 14 Sep, 2016 3 commits
  10. 27 Aug, 2016 1 commit
  11. 18 Aug, 2016 1 commit
  12. 16 Aug, 2016 1 commit
  13. 11 Jul, 2016 1 commit
  14. 28 Jun, 2016 1 commit
  15. 27 Jun, 2016 1 commit
  16. 17 Jun, 2016 1 commit
  17. 10 Jun, 2016 1 commit
  18. 08 Jun, 2016 1 commit
  19. 02 Jun, 2016 1 commit
    • Brad King's avatar
      Fix crash on $<TARGET_PROPERTY:...,LOCATION> genex (#16134) · f500a784
      Brad King authored
      Policy CMP0026 deprecated the LOCATION property, and we have long
      provided a $<TARGET_FILE:...> generator expression.  However, if
      a project tries to use $<TARGET_PROPERTY:...,LOCATION> we should
      at least not crash.
      
      The compatibility implementation of the LOCATION property uses
      cmGlobalGenerator::CreateGenerationObjects to create the structures
      needed to evaluate the property before generation starts.  The
      implementation assumed that accessing the property could only be done
      during configuration (via the typical get_property command use case).
      The $<TARGET_PROPERTY:...,LOCATION> genex causes the LOCATION property
      to be accessed during generation.  Calling CreateGenerationObjects
      during generation blows away all the objects currently being used for
      generation and is not safe.  Add a condition to call it only when
      configuration is not finished.
      f500a784
  20. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54
  21. 09 May, 2016 1 commit
    • Brad King's avatar
      Remove `//------...` horizontal separator comments · 0ac18d40
      Brad King authored
      Modern editors provide plenty of ways to visually separate functions.
      Drop the explicit comments that previously served this purpose.
      Use the following command to automate the change:
      
          $ git ls-files -z -- \
              "*.c" "*.cc" "*.cpp" "*.cxx" "*.h" "*.hh" "*.hpp" "*.hxx" |
            egrep -z -v "^Source/cmCommandArgumentLexer\." |
            egrep -z -v "^Source/cmCommandArgumentParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmDependsJavaLexer\." |
            egrep -z -v "^Source/cmDependsJavaParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmExprLexer\." |
            egrep -z -v "^Source/cmExprParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmFortranLexer\." |
            egrep -z -v "^Source/cmFortranParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmListFileLexer\." |
            egrep -z -v "^Source/cm_sha2" |
            egrep -z -v "^Source/(kwsys|CursesDialog/form)/" |
            egrep -z -v "^Utilities/(KW|cm).*/" |
            xargs -0 sed -i '/^\(\/\/---*\|\/\*---*\*\/\)$/ {d;}'
      
      This avoids modifying third-party sources and generated sources.
      0ac18d40
  22. 06 May, 2016 1 commit