1. 18 Jan, 2018 1 commit
  2. 10 Jan, 2018 2 commits
    • Brad King's avatar
    • Sebastian Holtermann's avatar
      Autogen: Ignore not existing source files in cmMakefile · d592bfc9
      Sebastian Holtermann authored
      Until CMake 3.10 a list of source files that had the AUTOUIC_OPTIONS property
      populated was kept in `cmMakefile::QtUiFilesWithOptions`.  In the process to
      remove all AUTOUIC related code from `cmMakefile` for CMake 3.10, the pre
      filtered list was replaced by a loop in `cmQtAutoGeneratorInitializer` over
      all source files in the `cmMakefile`.  This loop introduced the problem that
      file paths were computed for source files that weren't in the target's sources
      and that might not even have existed.  If the path for an unused and not
      existing file was computed a `cmake::FATAL_ERROR` with the error message
      "Cannot find source file:" was thrown nevertheless.
      This caused some projects to fail in CMake 3.10.
      This patch adds a test for path errors in the loops in
      `cmQtAutoGeneratorInitializer` that iterate over all source files in a
      `cmMakefile`. If a path error appears, the file is silently ignored.
      If the file is part of the target's sources, the path error will still be
      caught in the loop over all the target's sources.
      This is the fix for CMake 3.10.1.
  3. 09 Jan, 2018 4 commits
  4. 20 Dec, 2017 2 commits
  5. 14 Dec, 2017 2 commits
  6. 13 Dec, 2017 1 commit
  7. 12 Dec, 2017 6 commits
  8. 08 Dec, 2017 1 commit
  9. 07 Dec, 2017 5 commits
  10. 06 Dec, 2017 4 commits
    • Brad King's avatar
      Merge branch 'backport-revert-server-target-backtraces' into release-3.10 · 05f86af7
      Brad King authored
      Merge-request: !1564
    • Brad King's avatar
      server: Revert "Report backtraces in codemodel response" · 8b2736c7
      Brad King authored
      The backtrace information is very repetitive and hugely increases the
      size of the codemodel object.  We need to remove it until an alternative
      representation can be developed.  Revert commit v3.10.0-rc1~393^2
      (server: Report backtraces in codemodel response, 2017-06-20), except
      for the protocol version number (because it indicates other new things).
      Unfortunately this is incompatible with clients that expect the
      "crossReferences" field in targets.  However, the regression in memory
      usage is quite serious, especially on large projects, and therefore
      breaks even older clients that do not use backtraces.  Since the
      "crossReferences" field was only provided by one release (3.10.0), it is
      simplest to revert it outright for 3.10.1.
      Fixes: #17502
    • Matthew Woehlke's avatar
      GoogleTest: Add test for missing test executable · 935848a8
      Matthew Woehlke authored and Brad King's avatar Brad King committed
      Add a test to verify expected behavior when a test executable on which
      gtest_discover_tests is invoked was not built. (The test for the newly
      added timeout conveniently sets up this situation, so this new test was
      almost trivial to add.)
    • Matthew Woehlke's avatar
      GoogleTest: Add timeout to discovery · 29731d89
      Matthew Woehlke authored and Brad King's avatar Brad King committed
      Add a TIMEOUT option to gtest_discover_tests. This provides a
      work-around in case a test goes out to lunch, rather than causing the
      build to simply hang. (Although this is still a problem with the user's
      project, hanging the build is not cool, especially in the case of
      automatically running CI builds. It is much preferred that the build
      should actively fail in this case, and it is trivially easy for us to
      implement that.)
  11. 05 Dec, 2017 4 commits
    • Brad King's avatar
      Merge branch 'findmpi-notfound-spam' into release-3.10 · 0418e91f
      Brad King authored
      Merge-request: !1557
    • Brad King's avatar
      Merge branch 'findmpi-found-cond' into release-3.10 · 64184762
      Brad King authored
      Merge-request: !1556
    • Christian Pfeiffer's avatar
      FindMPI: Fix multiple configure runs · 2047eb36
      Christian Pfeiffer authored
      Due to a erroneous logical dependency on a temporary variable, FindMPI
      would depend its FOUND status on the set of flags needed to support
      compiler-implicit MPI support after the first configure run.
      This behavior is especially causing a misreported NOT FOUND status after
      the first run on MPI implementations without MPI compiler like MS-MPI or
      MPICH2 on Windows.
    • Christian Pfeiffer's avatar
      FindMPI: Correct legacy variable handling · bde7513d
      Christian Pfeiffer authored
      Due to a minor logic error, MPI_LIBRARY, MPI_EXTRA_LIBRARY and
      MPI_<LANG>_LIBRARIES hints are currently not correctly handled and
      Additionally, if either C or CXX aren't enabled, there subsequent calls
      to FindMPI will cause cache variables of the sort "MPI_MPI_EXTRA_LIBRARY-NOTFOUND"
      to appear due to an error in the compatibility handling. (Doesn't affect
  12. 01 Dec, 2017 2 commits
    • Brad King's avatar
      Merge branch 'cpack-pkg-fix' into release-3.10 · 64713d4c
      Brad King authored
      Merge-request: !1547
    • Alexander Wittig's avatar
      CPack: Fix macOS PKG component dependency information · f25d87db
      Alexander Wittig authored and Brad King's avatar Brad King committed
      Refactoring in commit v3.7.0-rc1~523^2 (CPack/PackageMaker: port to
      cmXMLWriter, 2016-06-08) accidentally broke `distribution.dist`
      generation when there are dependencies between components and the pkg
      (or the derived productbuild) generator are used.  The resulting
      package cannot be installed and instead the Apple Installer app
      shows a "Javascript error" message.
      The problem is that a `std::ostringstream` is constructed with some
      content, but the stream pointer still points to the beginning of the
      stream, so subsequent writes overwrite the initial content instead of
  13. 30 Nov, 2017 3 commits
  14. 28 Nov, 2017 2 commits
    • Brad King's avatar
      Merge branch 'clang-cl-fix' into release-3.10 · 79ad921a
      Brad King authored
      Merge-request: !1522
    • Ismail Donmez's avatar
      Clang: Do not mistake clang-cl 6.0 for GNU-like clang · f969f1a9
      Ismail Donmez authored
      The check added by commit v3.10.0-rc2~2^2 (Clang: Diagnose unsupported
      GNU-like clang targeting MSVC ABI, 2017-10-10) is incorrectly detecting
      clang-cl 6.0 as GNU-like.  Currently cmake is testing if the clang
      compiler accepts `--version` to see if it accepts GNU style flags.
      However, with the latest llvm snapshot this also works for clang-cl:
          > clang-cl --version
          clang version 6.0.0 (trunk)
          Target: x86_64-pc-windows-msvc
          Thread model: posix
          InstalledDir: C:\Program Files\LLVM\bin
      So instead we should use the `/?` flag which fails with clang but
      works with clang-cl:
          > clang-cl /? &> /dev/null; echo $?
          > clang /? &> /dev/null; echo $?
      Fixes: #17518
  15. 27 Nov, 2017 1 commit