1. 10 Oct, 2016 1 commit
  2. 07 Oct, 2016 1 commit
    • Martin Joly's avatar
      FindProtobuf: Fix protobuf_generate_*() to handle subdirs · 2b9dad69
      Martin Joly authored and Brad King's avatar Brad King committed
      The change in commit v3.7.0-rc1~513^2 (FindProtobuf: fix
      protobuf_generate_*() to handle proto files in subdirs, 2016-06-09)
      incorrectly adds subdirectories to the path of the generated files when
      `*.proto` files are passed to `protobuf_generate_*` with subdirectories.
      This behavior is not correct when `PROTOBUF_GENERATE_CPP_APPEND_PATH` is
      True (default behavior) as `protoc` will generate output file in the
      current build directory.
  3. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
  4. 02 Aug, 2016 1 commit
  5. 09 Jun, 2016 1 commit
  6. 07 Mar, 2016 1 commit
    • Antonio Perez Barrero's avatar
      FindProtobuf: Rename variables to match case of module name · a7b09e7f
      Antonio Perez Barrero authored and Brad King's avatar Brad King committed
      Use recommended case for variable names. i.e. matching name of the
      module as passed to `find_package`.
      For backwards compatibility, the upper case versions of both input and
      output variables are used and defined when appropriate.  Skip this for
      the _FOUND variable because FPHSA already does it.  Skip this for the
      _VERSION variable because that was recently added and never available
      with the old name in a release of CMake.
  7. 16 Feb, 2016 1 commit
    • Antonio Perez Barrero's avatar
      FindProtobuf: check version · bb7a41ab
      Antonio Perez Barrero authored and Brad King's avatar Brad King committed
      Check found libraries version to match user required version.
      Protobuf compiler executable version is checked to be aligned with found
      libraries, raising a warning message otherwise.
  8. 11 Feb, 2016 1 commit
  9. 11 Dec, 2015 1 commit
  10. 15 Sep, 2015 1 commit
  11. 11 Aug, 2015 1 commit
  12. 06 Nov, 2014 1 commit
  13. 18 Sep, 2014 1 commit
    • Michael Hanselmann's avatar
      FindProtobuf: Make outputs depend on protoc executable · e380d7c5
      Michael Hanselmann authored and Brad King's avatar Brad King committed
      After updating from Protocol Buffers 2.5.0 to 2.6.0 compilation of the
      generated source failed: "This file was generated by an older version of
      protoc which is incompatible with your Protocol Buffer headers. Please
      regenerate this file with a newer version of protoc.".
      Turns out the source and headers generated by way of
      FindProtobuf.cmake:PROTOBUF_GENERATE_CPP aren't updated. Adding a
      dependency on the compiler executable fixes this issue.
  14. 15 Oct, 2013 1 commit
  15. 24 May, 2013 1 commit
    • Matthew Woehlke's avatar
      FindProtobuf: also find pthread · 8961c4b6
      Matthew Woehlke authored
      Modify FindProtobuf.cmake to find the pthread library on UNIX platforms,
      and to add the same to PROTOBUF_LIBRARIES, as this is a link dependency
      of libraries using the protobuf headers.
  16. 13 Aug, 2012 2 commits
    • Kitware Robot's avatar
      Remove CMake-language block-end command arguments · 9db31162
      Kitware Robot authored and Brad King's avatar Brad King committed
      Ancient versions of CMake required else(), endif(), and similar block
      termination commands to have arguments matching the command starting the
      block.  This is no longer the preferred style.
      Run the following shell code:
      for c in else endif endforeach endfunction endmacro endwhile; do
          echo 's/\b'"$c"'\(\s*\)(.\+)/'"$c"'\1()/'
      done >convert.sed &&
      git ls-files -z -- bootstrap '*.cmake' '*.cmake.in' '*CMakeLists.txt' |
      egrep -z -v '^(Utilities/cm|Source/kwsys/)' |
      egrep -z -v 'Tests/CMakeTests/While-Endwhile-' |
      xargs -0 sed -i -f convert.sed &&
      rm convert.sed
    • Kitware Robot's avatar
      Remove trailing whitespace from most CMake and C/C++ code · 7bbaa428
      Kitware Robot authored and Brad King's avatar Brad King committed
      Our Git commit hooks disallow modification or addition of lines with
      trailing whitespace.  Wipe out all remnants of trailing whitespace
      everywhere except third-party code.
      Run the following shell code:
      git ls-files -z -- \
       bootstrap doxygen.config '*.readme' \
       '*.c' '*.cmake' '*.cpp' '*.cxx' \
       '*.el' '*.f' '*.f90' '*.h' '*.in' '*.in.l' '*.java' \
       '*.mm' '*.pike' '*.py' '*.txt' '*.vim' |
      egrep -z -v '^(Utilities/cm|Source/(kwsys|CursesDialog/form)/)' |
      egrep -z -v '^(Modules/CPack\..*\.in)' |
      xargs -0 sed -i 's/ \+$//'
  17. 03 Jan, 2012 1 commit
  18. 18 Dec, 2011 1 commit
  19. 12 Oct, 2011 1 commit
  20. 14 Jun, 2011 1 commit
  21. 26 May, 2011 1 commit
  22. 25 May, 2011 1 commit
  23. 20 Jan, 2011 1 commit
    • Brad King's avatar
      Modules: Include builtin FindPackageHandleStandardArgs directly · c4275592
      Brad King authored
      The FindPackageHandleStandardArgs module was originally created outside
      of CMake.  It was added for CMake 2.6.0 by commit e118a627 (add a macro
      FIND_PACKAGE_HANDLE_STANDARD_ARGS..., 2007-07-18).  However, it also
      proliferated into a number of other projects that at the time required
      only CMake 2.4 and thus could not depend on CMake to provide the module.
      CMake's own find modules started using the module in commit b5f656e0
      (use the new FIND_PACKAGE_HANDLE_STANDARD_ARGS in some of the FindXXX
      modules..., 2007-07-18).
      Then commit d358cf5c (add 2nd, more powerful mode to
      find_package_handle_standard_args, 2010-07-29) added a new feature to
      the interface of the module that was fully optional and backward
      compatible with all existing users of the module.  Later commit 5f183caa
      (FindZLIB: use the FPHSA version mode, 2010-08-04) and others shortly
      thereafter started using the new interface in CMake's own find modules.
      This change was also backward compatible because it was only an
      implementation detail within each module.
      Unforutnately these changes introduced a problem for projects that still
      have an old copy of FindPackageHandleStandardArgs in CMAKE_MODULE_PATH.
      When any such project uses one of CMake's builtin find modules the line
      loads the copy from the project which does not have the new interface!
      Then the including find module tries to use the new interface with the
      old module and fails.
      Whether this breakage can be considered a backward incompatible change
      in CMake is debatable.  The situation is analagous to copying a standard
      library header from one version of a compiler into a project and then
      observing problems when the next version of the compiler reports errors
      in its other headers that depend on its new version of the original
      header.  Nevertheless it is a change to CMake that causes problems for
      projects that worked with previous versions.
      This problem was discovered during the 2.8.3 release candidate cycle.
      It is an instance of a more general problem with projects that provide
      their own versions of CMake modules when other CMake modules depend on
      them.  At the time we resolved this instance of the problem with commit
      b0118402 (Use absolute path to FindPackageHandleStandardArgs.cmake
      everywhere, 2010-09-28) for the 2.8.3 release.
      In order to address the more general problem we introduced policy
      CMP0017 in commit db44848f (Prefer files from CMAKE_ROOT when including
      from CMAKE_ROOT, 2010-11-17).  That change was followed by commit
      ce28737c (Remove usage of CMAKE_CURRENT_LIST_DIR now that we have
      CMP0017, 2010-12-20) which reverted the original workaround in favor of
      using the policy.  However, existing project releases do not set the
      policy behavior to NEW and therefore still exhibit the problem.
      We introduced in commit a364daf1 (Allow users to specify defaults for
      unset policies, 2011-01-03) an option for users to build existing
      projects by adding -DCMAKE_POLICY_DEFAULT_CMP0017=NEW to the command
      line.  Unfortunately this solution still does not allow such projects to
      build out of the box, and there is no good way to suggest the use of the
      new option.
      The only remaining solution to keep existing projects that exhibit this
      problem building is to restore the change originally made in commit
      b0118402 (Use absolute path to FindPackageHandleStandardArgs.cmake
      everywhere, 2010-09-28).  This also avoids policy CMP0017 warnings for
      this particular instance of the problem the policy addresses.
  24. 04 Jan, 2011 1 commit
  25. 28 Sep, 2010 1 commit
  26. 09 Aug, 2010 1 commit
  27. 09 Oct, 2009 1 commit
  28. 05 Oct, 2009 1 commit
    • Brad King's avatar
      Fix module docs to be manpage (groff) friendly · 282b4e37
      Brad King authored
      Most problems are fixed (or rather worked-around) by making long '====='
      separators pre-formatted (i.e. prefixed with two spaces).  In order to
      preserve visual view, the code examples themselves are prefixed with 3
      This commit fixes the following man warnings:
      $ cmake --help-man - | LANG=C MANWIDTH=80 man --warnings -l - > /dev/null
        <standard input>:6024: warning [p 105, 1.7i]: can't break line
        <standard input>:6027: warning [p 105, 2.7i]: cannot adjust line
        <standard input>:6027: warning [p 105, 2.8i]: can't break line
        <standard input>:7142: warning [p 117, 7.8i]: can't break line
        <standard input>:7171: warning [p 117, 11.8i]: can't break line
        <standard input>:8878: warning [p 136, 9.0i]: can't break line
        <standard input>:8887: warning [p 136, 11.5i]: cannot adjust line
        <standard input>:8887: warning [p 136, 11.7i]: can't break line
        <standard input>:8904: warning [p 136, 14.2i]: can't break line
      Patch from Modestas Vainius.  See issue #9659.
  29. 01 Oct, 2009 1 commit
  30. 28 Sep, 2009 1 commit
    • Brad King's avatar
      Convert CMake find-modules to BSD License · c4bb9c9d
      Brad King authored
      This adds copyright/license notification blocks CMake's find-modules.
      Many of the modules had no notices at all.  Some had notices referring
      to the BSD license already.  This commit normalizes existing notices and
      adds missing notices.
  31. 21 Sep, 2009 1 commit
  32. 20 Sep, 2009 3 commits