1. 29 Mar, 2019 1 commit
    • Brad King's avatar
      ParseImplicitIncludeInfo: Canonicalize implicit include dirs · dad86f18
      Brad King authored
      The implicit include directory extraction added by commit 5990ecb7
      (Compute implicit include directories from compiler output, 2018-12-07,
      v3.14.0-rc1~108^2) leaves paths like `/usr/lib/../include` unchanged.
      Fix the logic to canonicalize such paths (e.g. to `/usr/include`)
      as we do for implicit link directories already.  This is important
      to ensure the set of implicit directories is represented in the same
      form as the include directories that will be compared to them.
      
      Issue: #19095
      dad86f18
  2. 28 Mar, 2019 1 commit
  3. 27 Mar, 2019 2 commits
  4. 26 Mar, 2019 3 commits
  5. 25 Mar, 2019 1 commit
    • Brad King's avatar
      Restore support for include_directories() in toolchain files · 588fa1bb
      Brad King authored
      Any `include_directories()` calls in toolchain files are used during our
      ABI detection step even though it does not include any system headers.
      Since commit 5990ecb7 (Compute implicit include directories from
      compiler output, 2018-12-07, v3.14.0-rc1~108^2), that check is also used
      to detect implicit include directories.  Any `include_directories()` in
      a toolchain file are detected as implicit and later excluded from
      explicit specification on compiler command lines, thus breaking the
      purpose of the calls in the first place.
      
      Fix the implicit include directory detection step to avoid using paths
      from `include_directories()` calls in the toolchain file.
      
      Fixes: #19079
      588fa1bb
  6. 21 Mar, 2019 2 commits
  7. 20 Mar, 2019 4 commits
  8. 19 Mar, 2019 3 commits
  9. 18 Mar, 2019 2 commits
  10. 15 Mar, 2019 4 commits
  11. 14 Mar, 2019 4 commits
  12. 13 Mar, 2019 1 commit
  13. 11 Mar, 2019 1 commit
  14. 08 Mar, 2019 1 commit
  15. 05 Mar, 2019 3 commits
    • Jerry's avatar
      FindThreads: Use complete program to test for pthreads in libc · d5331713
      Jerry authored
      Our check for just `pthread_create` is not sufficient because there are
      cases where that symbol may be found in libc but not all of pthreads.
      We first tried to address this in commit e9a1ddc5 (FindThreads:
      Replace the pthread symbol checking in libc., 2018-11-18,
      v3.14.0-rc1~292^2) by switching to `pthread_kill`, but that had to be
      reverted by commit 18320230 (FindThreads: Revert libc symbol check to
      pthread_create, 2019-02-27, v3.14.0-rc3~6^2) because there are other
      cases where `pthread_kill` is in libc but the rest of pthreads is not.
      Update our check to try a complete program using pthreads as an actual
      application might.
      
      Fixes: #18994
      d5331713
    • tomty89's avatar
      Android: allow user to enable versioned soname · 64e2c14c
      tomty89 authored
      64e2c14c
    • Ruslan Baratov's avatar
      iOS: Add IOS variable · e427c7c1
      Ruslan Baratov authored
      Since commit 11da882a (Apple: Introduce separate system name for iOS,
      tvOS, and watchOS, 2018-01-15, v3.14.0-rc1~14^2~1) we support setting
      `CMAKE_SYSTEM_NAME` to `iOS`.  Existing iOS toolchain files already
      set `IOS` as a short-hand variable, so do the same here.
      e427c7c1
  16. 04 Mar, 2019 1 commit
  17. 01 Mar, 2019 3 commits
    • Christian Pfeiffer's avatar
      FindJNI: Unify path search, fix support for Java 9 · 77cede09
      Christian Pfeiffer authored
      Java 9 restructured the standard location of the AWT libraries due to
      the removal of the JRE/JDK separation. We should check all possible
      combinations of subdirectories to the Java root directories to ensure
      that the libraries will be found after an upgrade.
      
      Furthermore, a root directory would contain both, include and library
      paths, so the search should be unified to ease maintenance on the
      module.
      77cede09
    • Zsolt Parragi's avatar
      MSVC: Use -D instead of /D in RC_FLAGS · e53a968e
      Zsolt Parragi authored
      llvm-rc can't handle definitions given with /D and without a space.
      e53a968e
    • Brad King's avatar
      ExternalProject: Restore default log dir with custom stamp dir · a6d3fee7
      Brad King authored
      In commit b6f6cac3 (ExternalProject: add LOG_DIR option that allows
      overriding of log location, 2018-10-12, v3.14.0-rc1~515^2~1) the log
      directory got its own option.  The intention was to fall back to the
      stamp directory by default.  However, the implementation actually only
      falls back to the same default as the stamp directory and does not
      consider a custom stamp dir.
      
      Update the default log dir computation to fall back to whatever is the
      final selection for the stamp dir.
      
      Fixes: #19000
      a6d3fee7
  18. 28 Feb, 2019 1 commit
  19. 27 Feb, 2019 2 commits
    • Zsolt Parragi's avatar
      RC: Pass output file in a way that llvm-rc 7 and below understand · 1a281a1a
      Zsolt Parragi authored
      Prior to LLVM 8.0, `llvm-rc` does not recognize `/fo` without a space
      after it.  Add the space unconditionally because MS `rc` accepts it too.
      
      Issue: #18957
      1a281a1a
    • Brad King's avatar
      FindThreads: Revert libc symbol check to pthread_create · 18320230
      Brad King authored
      Since commit e9a1ddc5 (FindThreads: Replace the pthread symbol
      checking in libc., 2018-11-18, v3.14.0-rc1~292^2) we check libc for
      `pthread_kill` instead of `pthread_create`.  However, on FreeBSD
      `pthread_kill` is in libc but not `pthread_create`.  Discussion in the
      original merge request for the above commit also considered
      `pthread_key_create`, `pthread_self`, and `pthread_attr_init`.  Every
      symbol seems to have some reason it is not an appropriate choice.
      
      Revert to the pre-3.14 behavior of using `pthread_create` pending
      further investigation.
      18320230