- 11 Aug, 2013 1 commit
-
-
Kitware Robot authored
-
- 10 Aug, 2013 1 commit
-
-
Kitware Robot authored
-
- 09 Aug, 2013 3 commits
-
-
b33c9844 Revert "Add compiler target compile options."
-
Stephen Kelly authored
This reverts commit 2d9ec1da.
-
Kitware Robot authored
-
- 08 Aug, 2013 28 commits
-
-
b93982fb Merge branch 'dev/fix-variable-watch-crash' into cmake-syntax c50f7ede cmListFileLexer: Modify flex output to avoid Borland warning bf732646 Warn about unquoted arguments that look like long brackets 58e52416 Warn about arguments not separated by whitespace e75b69f5 cmListFileCache: Convert CMake language parser to class e945949d Add RunCMake.Syntax test cases for command invocation styles 0546484e cmListFileArgument: Generalize 'Quoted' bool to 'Delimeter' enum 28685ade cmListFileLexer: Split normal and legacy unquoted arguments 1eafa3ed cmListFileLexer: Fix line number after backslash in string f3155cd6 Add RunCMake.Syntax test to cover argument parsing
-
6aa0c214 variable_watch: Add test for watching a variable multiple times b86e37c8 variable_watch: Check newValue for NULL f9bb20fe variable_watch: Don't share memory for callbacks 05dad99f variable_watch: Fix a typo in the error message 00ce12a3 variable_watch: Prevent making extra entries in the watch map 34b397e8 variable_watch: Allow specifying the data to match in RemoveWatch e43e207c variable_watch: Match client_data when finding duplicates 0d6acb1d variable_watch: Add a deleter for the client data fc7c3b4d variable_watch: Store client data as pointers
-
6f9aaad1 CTest: create one output file per memcheck (#14303)
-
cd345aa7 Skip CTestLimitDashJ test on Borland
-
-
-
ae6a5ea5 Include cmMakefile.h before cm*Lexer.h to get stdint.h first
-
8120e13f cmake-gui: Fix build rules for Qt5 on Windows
-
Brad King authored
Resolve conflict in Source/cmVariableWatchCommand.cxx by integrating the changes from both sides.
-
-
On read access, newValue can be NULL since there is no new value, so use the empty string instead.
-
The command itself is owned by the cmMakefile class, but the cmVariableWatch which holds a pointer to the cmVariableWatchCommand via the client_data for the callback outlives the cmMakefile class in the Qt GUI. This means that when the cmMakefile is destroyed, the variable watch is still in effect, but with a stale pointer. To fix this, each callback is now a separate entity completely and doesn't rely on the command which spawned it at all. An example CMakeLists.txt which demonstrates the issue (only displayed in cmake-gui, so no tests can be written for it): set(var 0) variable_watch(var) -
There was no space between "callback" and the quoted command name.
-
When removing a watch on a variable, using the operator [] on the internal map will create an empty watch if the variable doesn't have any existing watches. Rather than creating this empty structure in the map, return if there isn't a watch on the variable already.
-
Now that watches are dependent on their client_data when adding, it also makes sense to allow matching the data for removal.
-
If a callback has the same data as another call, we don't want to delete the old callback. This is because if the client_data is the same, it might get deleted causing the new client_data to be bogus. Now, AddWatch will return true if it will use the watch, false otherwise. Callers should check the return value to know whether client_data was adopted by the watch or not.
-
The client data is arbitrary and the callback may be called an unspecified number of times, so the cmVariableWatch must be the one to delete the client data in the end (if it is needed at all).
-
The STL containers create extra copies which makes keeping track of the owner of the client data much messier.
-
Brad King authored
Remove the "yyscanner = NULL" assignment from the end of the yylex_destroy function because Borland warns that the value is never used.
-
Brad King authored
In the future CMake will introduce Lua-style long bracket syntax. Warn about unquoted arguments that in the future will be treated as opening long brackets. Teach the RunCMake.Syntax test to cover such cases and ensure that the warning appears.
-
Brad King authored
Teach the lexer to return tokens for whitespace. Teach the parser to tolerate the space tokens where whitespace is allowed. Also teach the parser to diagnose and warn about cases of quoted arguments followed immediately by another argument. This was accidentally allowed previously, so we only warn. Update the RunCMake.Syntax test case StringNoSpace expected stderr to include the warnings.
-
Brad King authored
Refactor the parser implementation into a class to make it easier to extend.
-
Brad King authored
Cover commands with whitespace present in allowed combinations. Also cover command error cases such as two on one line.
-
Brad King authored
Replace the boolean value that indicates whether an argument is unquoted or quoted with a generalized enumeration of possible argument types. For now "Quoted" and "Unquoted" remain the only types.
-
Brad King authored
Match legacy arguments separately. Add macros to simplify and clarify matching rules.
-
Brad King authored
If a line inside a string ends in a backslash count the following newline character as a line increment. Add a test covering this case to verify that subsequent line numbers are correct.
-
Brad King authored
Test basic unquoted and quoted argument parsing cases including failure on an unterminated string and an unterminated command invocation. Also cover arguments not separated by any spaces, which is accidentally allowed by the current parser.
-
Kitware Robot authored
-
- 07 Aug, 2013 7 commits
-
-
Rolf Eike Beer authored
The output file used for memory checker runs must be unique for every test run in parallel, so simply make them unique for every test run. Simply use the test index to avoid collisions.
-
Brad King authored
The Borland-built CTest binary has trouble running many instances of itself in parallel, making the test unreliable. No particular recent change appears to be the culprit and the failure is not reliably reproducible. Just silence the failure for now by skipping the test.
-
Allow additional generator platforms for the installed WinCE SDKs.
-
-
Brad King authored
Set policy CMP0020 to NEW to get WinMain from Qt. Fix the documentation custom command PATH for cmake-gui to find the Qt5 DLLs.
-
The new compiler versions do not need corelibc.lib as a default link library and a architecture detection workaround.
-
-
