1. 13 Feb, 2019 4 commits
    • Brad King's avatar
      Update logic for sysroot in detected implicit include directories · 6fc33829
      Brad King authored
      Since commit 5990ecb7 (Compute implicit include directories from
      compiler output, 2018-12-07, v3.14.0-rc1~108^2) the values of the
      `CMAKE_<LANG>_IMPLICIT_INCLUDE_DIRECTORIES` variables are computed from
      a real compiler invocation.  In this case the paths under the sysroot
      should already have the sysroot prefix so we should no longer have to
      add the sysroot prefix.  However, it is also possible for project code
      to add its own paths to `CMAKE_<LANG>_IMPLICIT_INCLUDE_DIRECTORIES`
      without the sysroot prefix and expect the historical addition of the
      sysroot prefix to be preserved.
      
      Try to account for both cases by conditionally adding the sysroot prefix
      on implicit include directories that do not already have it.
      6fc33829
    • Brad King's avatar
      2ad14ef4
    • Brad King's avatar
      Fix regression in -I/usr/include exclusion logic · 557b2d6e
      Brad King authored
      The change in commit 15ad8300 (Refactor exclusion of -I/usr/include to
      avoid per-language values, 2019-01-21, v3.14.0-rc1~108^2~4) caused the
      exclusion to apply to Fortran, but it was only meant for C, CXX, and
      CUDA.  The purpose of the change was to prepare for the value of
      `CMAKE_<LANG>_IMPLICIT_INCLUDE_DIRECTORIES` to be computed from the
      actual compiler instead of hard-coded.  We need to preserve exclusion of
      `-I/usr/include` if the compiler has any implicit include directory that
      looks intended to replace it, e.g. `<sdk>/usr/include` on macOS.
      
      Fixes: #18914
      557b2d6e
    • Brad King's avatar
      macOS: Fix addition of <sdk>/usr/include to default implicit include dirs · 017598a4
      Brad King authored
      In commit 1293ed85 (ParseImplicitIncludeInfo: keep implicit incl.
      consistent when rerunning cmake, 2019-01-30, v3.14.0-rc1~26^2) the
      `Platform/UnixPaths` module was updated to add `/usr/include` to
      `CMAKE_{C,CXX,CUDA}_IMPLICIT_INCLUDE_DIRECTORIES` through an
      initialization variable used by `CMakeDetermineCompilerABI` instead of
      directly.  This approach makes it only a default that can be overridden
      by detection of the implicit include directories really used by the
      compiler.
      
      The addition of `<sdk>/usr/include` to default implicit include
      directories by the `Platform/Darwin` module needs the same update but
      was accidentally left out of the original commit.
      017598a4
  2. 06 Feb, 2019 8 commits
  3. 05 Feb, 2019 11 commits
  4. 04 Feb, 2019 10 commits
  5. 03 Feb, 2019 1 commit
  6. 02 Feb, 2019 5 commits
  7. 01 Feb, 2019 1 commit