1. 31 Jan, 2018 1 commit
    • Pavel Solodovnikov's avatar
      Reduce raw string pointers usage. · 653b8946
      Pavel Solodovnikov authored
      * Change some functions to take `std::string` instead of
        `const char*` in the following classes: `cmMakeFile`, `cmake`,
        `cmCoreTryCompile`, `cmSystemTools`,  `cmState`, `cmLocalGenerator`
        and a few others.
      * Greatly reduce using of `const char*` overloads for
        `cmSystemTools::MakeDirectory` and `cmSystemTools::RelativePath`.
      * Remove many redundant `c_str()` conversions throughout the code.
      653b8946
  2. 26 Jan, 2018 1 commit
  3. 25 Sep, 2017 1 commit
  4. 14 Sep, 2017 1 commit
  5. 26 Aug, 2017 1 commit
  6. 24 Aug, 2017 1 commit
  7. 07 Aug, 2017 1 commit
    • Bill Hoffman's avatar
      CTest: Report lines matched by launchers · 1c61d240
      Bill Hoffman authored
      Since launchers show the entire stderr/stdout for a command and only
      skip it if all of the lines are suppressed, it can be hard to tell if
      individual suppressions are working.  Mark up the output reported to
      CDash with a prefix for each line indicating whether it was a matched or
      suppressed warning.  Lines that are suppressed are prefixed with
      `[CTest: warning suppressed]` and lines that match the warning
      expression are prefixed with `[CTest: warning matched]`. This should
      make it easier for people to add suppressions as they will know what
      they need to match and what they have already suppressed. This is an
      issue because if there is more than one warning in a single compiler
      output you have to suppress all of them before it will go away.
      1c61d240
  8. 08 May, 2017 1 commit
  9. 21 Apr, 2017 1 commit
  10. 11 Apr, 2017 1 commit
    • Daniel Pfeifer's avatar
      Use quotes for non-system includes · 1d829c86
      Daniel Pfeifer authored
      Automate with:
      
      git grep -l '#include <cm_' -- Source \
        | xargs sed -i 's/#include <\(cm_.*\)>/#include "\1"/g'
      
      git grep -l '#include <cmsys/' -- Source \
        | xargs sed -i 's/#include <\(cmsys\/.*\)>/#include "\1"/g'
      
      git grep -l '#include <cm[A-Z]' -- Source \
        | xargs sed -i 's/#include <\(cm[A-Z].*\)>/#include "\1"/g'
      1d829c86
  11. 28 Nov, 2016 1 commit
  12. 14 Nov, 2016 1 commit
  13. 10 Nov, 2016 1 commit
  14. 19 Oct, 2016 1 commit
  15. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
      86578ecc
  16. 25 Aug, 2016 1 commit
  17. 18 Aug, 2016 1 commit
  18. 29 Jun, 2016 1 commit
    • Brad King's avatar
      Avoid using KWSys auto_ptr by adopting it ourselves · b5ec5b09
      Brad King authored
      Replace use of cmsys::auto_ptr with a CM_AUTO_PTR macro that maps to
      our own implementation adopted from the KWSys auto_ptr implementation.
      Later we may be able to map CM_AUTO_PTR to std::auto_ptr on compilers
      that do not warn about it.
      
      Automate the client site conversions:
      
          git grep -l auto_ptr -- Source/ | grep -v Source/kwsys/ | xargs sed -i \
            's|cmsys::auto_ptr|CM_AUTO_PTR|;s|cmsys/auto_ptr.hxx|cm_auto_ptr.hxx|'
      b5ec5b09
  19. 28 Jun, 2016 1 commit
  20. 02 Jun, 2016 1 commit
    • Daniel Pfeifer's avatar
      Simplify boolean expressions · 7f6b8d33
      Daniel Pfeifer authored
      Use clang-tidy's readability-simplify-boolean-expr checker.
      After applying the fix-its, revise all changes *very* carefully.
      Be aware of false positives and invalid changes.
      7f6b8d33
  21. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      d9fd2f54
  22. 09 May, 2016 1 commit
    • Brad King's avatar
      Remove `//------...` horizontal separator comments · 0ac18d40
      Brad King authored
      Modern editors provide plenty of ways to visually separate functions.
      Drop the explicit comments that previously served this purpose.
      Use the following command to automate the change:
      
          $ git ls-files -z -- \
              "*.c" "*.cc" "*.cpp" "*.cxx" "*.h" "*.hh" "*.hpp" "*.hxx" |
            egrep -z -v "^Source/cmCommandArgumentLexer\." |
            egrep -z -v "^Source/cmCommandArgumentParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmDependsJavaLexer\." |
            egrep -z -v "^Source/cmDependsJavaParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmExprLexer\." |
            egrep -z -v "^Source/cmExprParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmFortranLexer\." |
            egrep -z -v "^Source/cmFortranParser(\.y|\.cxx|Tokens\.h)" |
            egrep -z -v "^Source/cmListFileLexer\." |
            egrep -z -v "^Source/cm_sha2" |
            egrep -z -v "^Source/(kwsys|CursesDialog/form)/" |
            egrep -z -v "^Utilities/(KW|cm).*/" |
            xargs -0 sed -i '/^\(\/\/---*\|\/\*---*\*\/\)$/ {d;}'
      
      This avoids modifying third-party sources and generated sources.
      0ac18d40
  23. 29 Apr, 2016 1 commit
    • Brad King's avatar
      Format include directive blocks and ordering with clang-format · e1c77472
      Brad King authored
      
      
      Sort include directives within each block (separated by a blank line) in
      lexicographic order (except to prioritize `sys/types.h` first).  First
      run `clang-format` with the config file:
      
          ---
          SortIncludes: false
          ...
      
      Commit the result temporarily.  Then run `clang-format` again with:
      
          ---
          SortIncludes: true
          IncludeCategories:
            - Regex:    'sys/types.h'
              Priority: -1
          ...
      
      Commit the result temporarily.  Start a new branch and cherry-pick the
      second commit.  Manually resolve conflicts to preserve indentation of
      re-ordered includes.  This cleans up the include ordering without
      changing any other style.
      
      Use the following command to run `clang-format`:
      
          $ git ls-files -z -- \
              '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' |
            egrep -z -v '(Lexer|Parser|ParserHelper)\.' |
            egrep -z -v '^Source/cm_sha2' |
            egrep -z -v '^Source/(kwsys|CursesDialog/form)/' |
            egrep -z -v '^Utilities/(KW|cm).*/' |
            egrep -z -v '^Tests/Module/GenerateExportHeader' |
            egrep -z -v '^Tests/RunCMake/CommandLine/cmake_depends/test_UTF-16LE.h' |
            xargs -0 clang-format -i
      
      This selects source files that do not come from a third-party.
      Inspired-by: Daniel Pfeifer's avatarDaniel Pfeifer <daniel@pfeifer-mail.de>
      e1c77472
  24. 13 Oct, 2015 1 commit
  25. 05 Oct, 2015 1 commit
  26. 28 Aug, 2015 3 commits
  27. 27 May, 2015 1 commit
  28. 26 May, 2015 1 commit
  29. 16 May, 2015 1 commit
    • Stephen Kelly's avatar
      cmState: Compute and store directory components. · 57bdc1a2
      Stephen Kelly authored
      There is no need to duplicate these in all cmLocalGenerators.
      
      Rename the symbols according to current conventions.
      
      Add explicit calls to Set{Source,Binary}Directory with empty strings
      in order to trigger the population of the components containers with
      the current working directory in cmLocalGenerator.  Having
      directories set to empty is a special case in CMake, which is relied
      on for the `if(CMAKE_BINARY_DIR)` condition at the end of
      CMakeDetermineSystem.cmake.
      57bdc1a2
  30. 15 May, 2015 1 commit
  31. 18 Apr, 2015 1 commit
  32. 18 Jan, 2015 1 commit
  33. 05 Dec, 2014 1 commit
    • Ben Boeckel's avatar
      ctest --launch: write to cout and cerr in binary · 29b0c8c3
      Ben Boeckel authored
      Because ctest reads in binary but writes in text mode, Windows' newline
      transformation can be applied multiple times causing '\n' in the source
      application to be written out as '\r\r\n' instead.
      29b0c8c3
  34. 15 Oct, 2014 1 commit
  35. 11 Mar, 2014 1 commit
    • Stephen Kelly's avatar
      Remove some c_str() calls. · 21c573f6
      Stephen Kelly authored
      Use the clang RemoveCStrCalls tool to automatically migrate the
      code. This was only run on linux, so does not have any positive or
      negative effect on other platforms.
      21c573f6
  36. 08 Mar, 2014 1 commit
    • Ben Boeckel's avatar
      strings: Remove cmStdString references · 270eb96d
      Ben Boeckel authored
      Casts from std::string -> cmStdString were high on the list of things
      taking up time. Avoid such implicit casts across function calls by just
      using std::string everywhere.
      
      The comment that the symbol name is too long is no longer relevant since
      modern debuggers alias the templates anyways and the size is a
      non-issue since the underlying methods are generated since it's
      inherited.
      270eb96d
  37. 25 Feb, 2014 1 commit
    • Nils Gladitz's avatar
      CTest: exclude /showIncludes notes when scraping logs · 47702b8d
      Nils Gladitz authored
      My last related commit e5e3f3d4 (CTest: filter /showIncludes output from
      ninja compile launcher, 2013-12-01) filtered /showIncludes messages from
      the generated xml output but they also need to be filtered in
      ScrapeLog().  Otherwise they are being detected as warnings when using
      compilers withs english diagnostics.
      47702b8d
  38. 07 Jan, 2014 1 commit