1. 10 Apr, 2015 1 commit
  2. 02 Mar, 2015 1 commit
  3. 20 May, 2014 1 commit
  4. 11 Mar, 2014 1 commit
    • Stephen Kelly's avatar
      Remove some c_str() calls. · 21c573f6
      Stephen Kelly authored
      Use the clang RemoveCStrCalls tool to automatically migrate the
      code. This was only run on linux, so does not have any positive or
      negative effect on other platforms.
      21c573f6
  5. 28 May, 2013 1 commit
  6. 23 May, 2012 1 commit
    • Brad King's avatar
      KWSys: Remove unused environ declaration from SystemTools · 0fbaa63c
      Brad King authored
      Commit "KWSys: Fix SystemTools environment memory handling" (2012-04-26)
      added a _WIN32 case inside !KWSYS_CXX_HAS_ENVIRON_IN_STDLIB_H to dllimport
      the "environ" global.  Howver, KWSYS_CXX_HAS_ENVIRON_IN_STDLIB_H is true
      on every Windows toolchain we support so the case is never reached.
      Furthermore, even if it were reached the use of dllimport is incorrect
      because the toolchain might not be compiling with a dynamic runtime
      library.  Remove the unused incorrect line and supporting conditionals.
      0fbaa63c
  7. 27 Apr, 2012 1 commit
    • Brad King's avatar
      KWSys: Fix SystemTools environment memory handling (#13156) · e48796b2
      Brad King authored
      The SystemTools::PutEnv function tries to provide the "putenv" API
      without leaking memory.  However, the kwsysDeletingCharVector singleton
      frees memory that may still be referenced by the environment table,
      having been placed there by putenv.  If any static destruction or
      processing by an external tool happens after the singleton is destroyed
      and accesses the environment it will read invalid memory.
      
      Replace use of putenv with setenv/unsetenv when available.  The latter
      manage internal copies of the values passed instead of referencing the
      original memory.  When setenv/unsetenv are not available use putenv with
      a singleton that removes its values from the environment before freeing
      their memory.  This requires an "unputenv" implementation.  On at least
      some platforms it must be written in terms of "putenv" because other
      APIs are not available and direct modification of the "environ" global
      is not safe (e.g. on Windows there is interaction with "w...
      e48796b2
  8. 15 Dec, 2011 1 commit
  9. 13 Nov, 2011 2 commits
  10. 01 Nov, 2011 1 commit
    • Brad King's avatar
      KWSys: Address Intel compiler remarks · 13d19468
      Brad King authored
      CommandLineArguments.cxx:
       remark #181: argument is incompatible with corresponding format
        string conversion
      
      SystemInformation.cxx:
       remark #193: zero used for undefined preprocessing identifier "_WIN32"
       warning #177: variable "Regebx" was declared but never referenced
      
      SystemTools.cxx(375):
       remark #444: destructor for base class "std::vector<char*>" is not virtual
        class kwsysDeletingCharVector : private kwsys_stl::vector<char*>
      
      Author: Hans Johnson <hans-johnson@uiowa.edu>
      Change-Id: Ibc899c3ba14990158ef7bbabace4b435b22495c3
      13d19468
  11. 20 Aug, 2011 1 commit
    • David Cole's avatar
      KWSys: Remove translation path for "/tmp_mnt/" (#10595) · 7dcbb663
      David Cole authored
      In SystemTools::ClassInitialize, remove call to AddTranslationPath
      that was originally put in place to "work around an SGI problem."
      This code precluded using CMake effectively in valid directories
      under "/tmp_mnt/"
      7dcbb663
  12. 04 Aug, 2011 1 commit
  13. 03 Aug, 2011 1 commit
  14. 10 Jan, 2011 1 commit
  15. 07 Jan, 2011 1 commit
    • David Cole's avatar
      Fix WOW64 registry mode on Windows 2000 (#10759) · 4b05a213
      David Cole authored
      
      
      CMake fails to find any registry paths on Windows 2000: according to regmon
      it fails with an access denied error. I double checked all the access rights
      and they are fine. After checking the access modes on MSDN I found that it
      says KEY_WOW64_32KEY / KEY_WOW64_64KEY are not supported on Windows 2000.
      CMake does not check if the current system supports Wow64 before applying
      these flags.
      
      This commit adds a check for IsWow64Process in kernel32.dll before adding
      these flags.
      
      Author: Axel Gembe <ago@bastart.eu.org>
      Signed-off-by: default avatarAxel Gembe <ago@bastart.eu.org>
      4b05a213
  16. 28 Dec, 2010 1 commit
    • Brad King's avatar
      KWSys: Avoid passing string literal as char* · 75191fa3
      Brad King authored
      Pass the lpClass argument of RegCreateKeyEx as a real char[] instead of
      a string literal.  At least one platform declares the argument as char*
      instead of "const char*".
      75191fa3
  17. 14 Dec, 2010 1 commit
    • Brad King's avatar
      KWSys: Do not mangle UNC paths in ConvertToUnixOutputPath (#10206) · 3a14b6e5
      Brad King authored
      This method replaces '//' with '/' to make the paths look nicer.
      Originally it correctly skipped a leading '//' in a UNC path as the
      comment says.  However, commit "Removed extra variable initializations"
      (2005-04-15) accidentally removed the "pos=1" initializer.  It was then
      incorrectly restored by commit "Added missing variable initialization"
      (2005-04-15) as just "pos=0".  Restore the proper initializer.
      
      The test for this added by commit "better coverage" (2006-07-31)
      included incorrect output for a sample UNC-like path.  Fix it.
      3a14b6e5
  18. 08 Dec, 2010 1 commit
    • Brad King's avatar
      KWSys: Remove realpath from SystemTools::GetPath (#10335) · 306427c0
      Brad King authored
      Commit "merge in changes for beos support" (2006-12-04) added a realpath
      call for every directory parsed out of a PATH-style environment
      variable.  No reason was given in the commit message or comments.
      
      The call incorrectly resolves symlinks in referenced paths.  Remove it.
      If BeOS support really needs it then it can be restored for that
      platform with a full explanation.
      306427c0
  19. 27 Aug, 2010 2 commits
  20. 16 Aug, 2010 2 commits
  21. 04 Jun, 2010 1 commit
    • Brad King's avatar
      KWSys: Remove "copyPermissions" parameters · ac17dc4a
      Brad King authored
      The CopyFileIfDifferent, CopyFileAlways, CopyAFile and CopyADirectory
      methods should always copy permissions.  The special cases in which a
      caller would pass copyPermissions=false should be handled at the call
      site.  The parameter needlessly complicates the interface and semantics
      of these methods.
      ac17dc4a
  22. 03 Jun, 2010 1 commit
    • Brad King's avatar
      KWSys: Avoid stat in CopyFileAlways (#10790) · c15ed329
      Brad King authored
      On Windows 7 the file size reported by 'stat' on a new file sometimes
      reports zero even though the real size is correct.  This causes our
      CopyFileAlways method to falsely detect copy failure.  Work around the
      problem by trusting the state of ofstream after writing the file.
      c15ed329
  23. 04 May, 2010 1 commit
  24. 09 Apr, 2010 1 commit
  25. 28 Jan, 2010 1 commit
  26. 24 Nov, 2009 1 commit
  27. 28 Oct, 2009 1 commit
  28. 16 Oct, 2009 2 commits
  29. 01 Oct, 2009 1 commit
  30. 28 Sep, 2009 1 commit
    • Brad King's avatar
      Convert KWSys to OSI-approved BSD License · de955e4b
      Brad King authored
      This converts the KWSys license to a pure 3-clause OSI-approved BSD
      License.  We drop the previous license clause requiring modified
      versions to be plainly marked.  We also update the KWSys copyright to
      cover the full development time range.
      de955e4b
  31. 24 Sep, 2009 1 commit
    • Brad King's avatar
      Restore KWSys SystemTools _WIN32 state on cygwin · f10929ae
      Brad King authored
      The commit "Fix KWSys SystemTools build on cygwin with -mwin32" tried to
      restore the state of the _WIN32 definition that was broken by the commit
      "Optimize KWSys SystemTools::FileExists on Windows".  It did so for the
      case of building with -mwin32 on cygwin, but since including <windows.h>
      defines _WIN32, it failed for the case of not using -mwin32.
      
      This commit restores the state of _WIN32 in all cases by undefining it
      after including <windows.h> if it was not defined beforehand.
      f10929ae
  32. 23 Sep, 2009 1 commit
    • Brad King's avatar
      Fix KWSys SystemTools build on cygwin with -mwin32 · 4e121af9
      Brad King authored
      Commit "Optimize KWSys SystemTools::FileExists on Windows" accidentally
      added "#undef _WIN32" when including <windows.h> on cygwin, which breaks
      builds using the -mwin32 flag.  This commit removes that line and fixes
      the real error it was intended to avoid.
      4e121af9
  33. 22 Sep, 2009 2 commits
    • Bill Hoffman's avatar
      Put a flag in that will stop system tools from deleting system environment... · e7601ca6
      Bill Hoffman authored
      Put a flag in that will stop system tools from deleting system environment memory on exit, as it can cause gcov to crash the programs.
      e7601ca6
    • Brad King's avatar
      Optimize KWSys SystemTools::FileExists on Windows · 9b6c3d07
      Brad King authored
      We optimize this method by using the GetFileAttributesExA native Windows
      API to check for file existence when possible.  For real Windows builds
      we always use it.  For Cygwin we use cygwin_conv_to_win32_path to get a
      native Windows path if possible and otherwise fall back to 'access'.
      
      Cygwin-to-Windows path conversion and cache by Wojciech Migda.
      See issue #8826.
      9b6c3d07
  34. 06 Aug, 2009 1 commit
  35. 26 Jul, 2009 1 commit