GitLab

Instead of hardcoding the amount of retries and the time to sleep
between them when removing directories on Windows, use the setting
potentially present in the registry instead. This setting is already
used when retrying moving directories.

18ce372e Help: Add 3.15.2 release notes
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3664

Merge-request: !3664

18b0330b clang-tidy: Enable performance-inefficient-string-concatenation
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3648

7ed84b1e FindPython: ensure virtual environments are correctly handled
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3649

959b97a2 Tests: testStringAlgorithms: Add cmTrimWhitespace, cmEscapeQuotes, cmTokenize
7fbcc16d cmStringAlgorithms: cmIsSpace, cmTrimWhitespace, cmEscapeQuotes, cmTokenize
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3647

8fe129e3 Help: Fix spelling typo in `CMAKE_MESSAGE_INDENT` docs
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3658

feeb0381 FindGLEW: Fix typo in verbose log message
ab822a9b FindGLEW: Add required OpenGL dependency in macOS
a8a3efa3 FindGLEW: Fix macOS library suffix selection
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3656

8ed86860 find_package: Fix prefer-config mode to not fail on missing optional package
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3653

493b8eae Help: Fix example output in the `CMAKE_MESSAGE_INDENT` documentation
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3651

d192caef CMakeDependentOption: Document that 4th parameter follows if-syntax
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3643

Merge-request: !3656

macOS requires OpenGL as INTERFACE_LINK_LIBRARIES dependency
in the GLEW targets. This commit fixes this issue.

Fix logic added by commit a7d85386 (FindGLEW: Update implementation,
2019-03-13, v3.15.0-rc1~375^2~1) on macOS.  macOS is recognized as both
UNIX and APPLE.  Consequently, the library suffix for shared and static
library was set, respectively, as `.so` and `.a`, just like UNIX systems.
Fix this by properly checking the OS type.

Fixes: #19542

Merge-request: !3653

a2454793 clang: Work around toolchain file use of internal CMake variables
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3650

When `CMAKE_FIND_PACKAGE_PREFER_CONFIG` mode was set to `ON`, failure to
find a package was fatal even if it was not `REQUIRED`.  Fix this and
add a test case.

Fixes: #19557

Fixes: #19525

Enables the clang-tidy test performance-inefficient-string-concatenation
and replaces all inefficient string concatenations with `cmStrCat`.

Closes: #19555

41364824 cmFunctionBlocker: Recycle functions
6491270e cmFunctionBlocker: Move check for matching args
af24e4ef cmFunctionBlocker: Move common logic to base
ef38ff22 cm*FunctionBlocker: Extract function Replay
b51fba62 cmMakefile: Add OnExecuteCommand callback
c7650094 cm*FunctionBlocker: Move to source file
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3632

09625896 cmake: Initialize booleans at declaration and cleanup constructor
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3646

d75cad01 Fix rpath-link for shared lib with only private deps
4b2e1fc9 cmGeneratorTarget: Use local var to de-duplicate CMP0022 checks
94648953 cmLinkItem: Simplify tracking of whether link interface is explicit
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3642

f6d6dbc2 Make CMAKE_LINK_LIBRARY_FILE_FLAG work like CMAKE_LINK_LIBRARY_FLAG
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3641

Merge-request: !3650

d70a0f86 fileapi: Fix codemodel target install destination for cross-dir rules
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3639

Since commit d44c0db0 (clang: setup correct configuration in gnu mode,
2019-02-20, v3.15.0-rc1~41^2~5) our Clang compiler information modules
need the `CMAKE_<LANG>_COMPILER_FRONTEND_VARIANT` variable that we
compute during compiler detection.  However, some existing toolchain
files set our internal `CMAKE_<LANG>_COMPILER_ID_RUN` variables and
block that detection, but do not set the new frontend variant variable.
Help them out by setting `CMAKE_<LANG>_COMPILER_FRONTEND_VARIANT` anyway.

Fixes: #19515, #19539