1. 09 Jun, 2014 1 commit
  2. 05 Jun, 2014 1 commit
  3. 03 Jun, 2014 3 commits
    • Brad King's avatar
      cmake: Fix --build crash on bad CMAKE_GENERATOR in cache · 44e2923f
      Brad King authored
      If we fail to create the generator named by CMAKE_GENERATOR, exit
      with an error message instead of crashing.  While at it, fix the
      wording of the error message when CMAKE_GENERATOR is not set.
      
      Extend the RunCMake.CommandLine test with cases covering the
      "cmake --build" option when the named directory does not provide
      a CMakeCache.txt with a valid CMAKE_GENERATOR.
      44e2923f
    • Brad King's avatar
      Simplify and clarify credit text and link · 889f2fd8
      Brad King authored
      Use the name "Kitware" rather than "Kitware, Inc." to simplify the text.
      Provide a CMake-specific URL.
      889f2fd8
    • Brad King's avatar
      Simplify and clarify credit text and link · 8da0a75b
      Brad King authored
      Use the name "Kitware" rather than "Kitware, Inc." to simplify the text.
      Provide a CMake-specific URL.
      8da0a75b
  4. 27 May, 2014 2 commits
    • Brad King's avatar
      cmCacheManager: Avoid cache entry self-assignment · 1cd37527
      Brad King authored
      Since commit bef93dc5 (Couple of changes: cache variables now have a map
      of properties, 2002-09-11) the cmCacheManager::AddCacheDefinition method
      accesses its map entry by reference.  However, the commit left the
      original entry assignment at the end of the method.  With Apple Clang
      5.1 and libc++ this self-assignment destroys the cache entry property
      map.
      
      Drop the self assignment.  Also drop the condition around the call to
      UnwatchUnusedCli since it was a self-comparison that must always have
      been true.
      1cd37527
    • Brad King's avatar
      cmake: Tolerate missing HELPSTRING on compiler change · 326d15a3
      Brad King authored
      Teach cmake::HandleDeleteCacheVariables to tolerate a missing HELPSTRING
      (NULL pointer) when saving cache entries.  In the absence of other bugs
      this should not be possible, but avoid the crash just in case.
      326d15a3
  5. 22 May, 2014 1 commit
  6. 20 May, 2014 2 commits
    • Brad King's avatar
      KWSys Process: Workaround child kill trouble on Cygwin · 0c7f84ca
      Brad King authored
      When we kill a child we send SIGSTOP first so that we can traverse its
      child processes recursively.  On unwinding the recursion we then send
      SIGKILL.  Current Cygwin has trouble when both signals are sent in quick
      succession by the parent process.  Add a usleep(1) after sending the
      first signal to give up our time slice and give Cygwin a chance to
      process the first signal before sending the second.
      0c7f84ca
    • Brad King's avatar
      KWSys SystemTools: Port cygwin path conversion to modern API · e604209c
      Brad King authored
      The cygwin_conv_to_win32_path function is deprecated in favor of
      cygwin_conv_path.  Use the latter.
      e604209c
  7. 19 May, 2014 1 commit
    • Brad King's avatar
      CMP0022: Fix link language propagation in NEW behavior · 40b9cd0f
      Brad King authored
      The languages used in compiling STATIC libraries need to be propagated
      to dependents regardless of the settings of INTERFACE_LINK_LIBRARIES or
      CMP0022.  They are independent of the libraries in the link interface.
      
      Prior to commit v2.8.12~192^2~2 (Introduce the INTERFACE_LINK_LIBRARIES
      property, 2013-06-04) the cmTarget::ComputeLinkInterface code path for
      "explicitLibraries" could never be taken for STATIC libraries, so the
      logic to propagate languages existed only in the non-explicitLibraries
      code path.  After that commit, INTERFACE_LINK_LIBRARIES could be set for
      STATIC libraries to cause the "explicitLibraries" code path to be taken.
      The commit also left the old non-explicitLibraries code path conditional
      on CMP0022 not being set to NEW.  Thus link language propagation was
      left missing from two cases by that commit.
      
      The explicitLibraries code path was fixed to propagate languages by
      commit v2.8.12~149^2~1 (cmTarget: Fix iface libraries and languages for
      static libraries, 2013-07-26).  However, the non-explicitLibraries case
      was never taught to propagate languages when CMP0022 is set to NEW.  Fix
      that now.  Factor the logic to propagate link languages out of the link
      interface libraries conditions so that it always occurs.  Update
      Tests/Fortran to set CMP0022 to NEW to test this case (because the test
      passes only if link language propagation works).
      40b9cd0f
  8. 13 May, 2014 2 commits
  9. 09 May, 2014 3 commits
    • Brad King's avatar
      Ninja: Fix deptype for Intel compiler on Linux · 54535f47
      Brad King authored
      Since commit v3.0.0-rc1~305^2 (Ninja: deptype msvc for Intel's compiler
      on Windows, 2013-11-25) we used "deps = msvc" for the Intel compiler.
      This is correct only on Windows.  On Linux we still want "deps = gcc".
      
      Fix the logic to use "deps = msvc" when the compiler id or the "simulate
      id" is "MSVC".  This will preserve the behavior on Intel for Windows and
      fix the behavior on Intel for Linux.  In the future this should be
      converted to a platform information module variable.
      54535f47
    • Brad King's avatar
      cmTarget: Evaluate CMP0026 in calling context · 23409f50
      Brad King authored
      This policy should be checked at the call site that tries to access the
      LOCATION property, not the directory scope containing the target.
      Thread the caller context through cmTarget::GetProperty to use for
      checking the policy setting and emitting a diagnostic with proper
      backtrace.
      
      Extend the RunCMake.CMP0026 test with a cross-directory case.
      23409f50
    • Brad King's avatar
      cmTarget: Drop unused GetProperty signature · 2e75bf67
      Brad King authored
      No callers use the second "scope" argument.  Drop this signature and
      hard-code the default parameter value internally.
      2e75bf67
  10. 07 May, 2014 3 commits
  11. 06 May, 2014 1 commit
  12. 25 Apr, 2014 1 commit
  13. 22 Apr, 2014 1 commit
    • Tim Blechmann's avatar
      OS X: Fix Info.plist placement in a CFBundle · 149ce5db
      Tim Blechmann authored and Brad King's avatar Brad King committed
      Fix cmOSXBundleGenerator::CreateCFBundle to place Info.plist under the
      same root directory as the rest of the bundle.  Without this, Info.plist
      was placed into CMAKE_BINARY_DIR, not CMAKE_CURRENT_BINARY_DIR because
      the target path was not generated correctly.
      149ce5db
  14. 16 Apr, 2014 2 commits
  15. 02 Apr, 2014 1 commit
    • Brad King's avatar
      Do not warn by default when policy CMP0025 or CMP0047 is not set · a41c0a9d
      Brad King authored
      These policies are triggered by the use of a particular compiler rather
      than outdated CMake code in a project.  Avoid warning in every project
      that enables a language by not displaying the policy warning by default.
      Add variable CMAKE_POLICY_WARNING_CMP<NNNN> to control the warning
      explicitly; otherwise enable the warning with --debug-output or --trace.
      
      This breaks with strict policy convention because it does not provide
      developers with any warning about the behavior change by default.
      Existing projects will continue to build without a warning or change in
      behavior.  When a developer changes the minimum required version of
      CMake in a project to a sufficiently high value (3.0), the project will
      suddenly get the new compiler id and may break, but at least the
      breakage comes with a change to the project rather than the version of
      CMake used to build it.
      
      Breaking strict policy convention is worthwhile in this case because
      very few projects will be affected by the behavior change but every
      project would have to see the warning if it were enabled by default.
      a41c0a9d
  16. 31 Mar, 2014 1 commit
  17. 20 Mar, 2014 1 commit
  18. 19 Mar, 2014 2 commits
  19. 17 Mar, 2014 3 commits
  20. 12 Mar, 2014 1 commit
  21. 10 Mar, 2014 1 commit
  22. 06 Mar, 2014 1 commit
  23. 04 Mar, 2014 1 commit
  24. 25 Feb, 2014 1 commit
    • Nils Gladitz's avatar
      CTest: exclude /showIncludes notes when scraping logs · 47702b8d
      Nils Gladitz authored and Brad King's avatar Brad King committed
      My last related commit e5e3f3d4 (CTest: filter /showIncludes output from
      ninja compile launcher, 2013-12-01) filtered /showIncludes messages from
      the generated xml output but they also need to be filtered in
      ScrapeLog().  Otherwise they are being detected as warnings when using
      compilers withs english diagnostics.
      47702b8d
  25. 21 Feb, 2014 2 commits
  26. 19 Feb, 2014 1 commit
    • Brad King's avatar
      Change version scheme to use only two components for feature levels · 7cbab178
      Brad King authored
      Historically CMake used three version components for the feature level.
      We released new features while incrementing only the third version
      component.  Since commit v2.8.2~105^2~4 (New version scheme to support
      branchy workflow, 2010-04-23) we used the fourth version component for
      bug-fix releases and the development date:
      
       <major>.<minor>.<patch>[.<tweak>][-rc<n>] = Release
       <major>.<minor>.<patch>.<date>[-<id>]     = Development
      
      This solidified use of three components for the feature level, and was
      necessary to continue releasing 2.x versions because:
      
      * Some existing projects performed floating-point comparisons of
        ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION} to 2.x numbers
        so ``x`` could never be higher than 9.
      
      * Version 2.9.<date> was used briefly in post-2.8.0 development in
        CVS prior to the transition to Git, so using it in releases may
        have caused confusion.
      
      Now that we are moving to 3.x versions, these two restriction...
      7cbab178