1. 08 Nov, 2016 1 commit
  2. 26 Oct, 2016 1 commit
  3. 21 Oct, 2016 1 commit
    • Daniel Pfeifer's avatar
      Fix newly discovered clang-tidy issues · 569509f4
      Daniel Pfeifer authored
      Clang-tidy reports some issues only from the currently compiled source
      file and its associated header file.  Separating the compilation of
      commands exposed some clang-tidy issues that were not reported previously.
      Fix them.
  4. 19 Oct, 2016 1 commit
  5. 27 Sep, 2016 1 commit
    • Brad King's avatar
      Simplify CMake per-source license notices · 86578ecc
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      Replace CMake per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online information
      available from "https://cmake.org/licensing".  The online URL also handles
      cases of modules being copied out of our source into other projects, so we
      can drop our notices about replacing links with full license text.
      Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
      of the replacements mechanically.  Manually fix up shebang lines and trailing
      newlines in a few files.  Manually update the notices in a few files that the
      script does not handle.
  6. 16 Sep, 2016 1 commit
  7. 15 Sep, 2016 1 commit
  8. 03 Sep, 2016 1 commit
  9. 09 Aug, 2016 1 commit
  10. 18 Jul, 2016 1 commit
  11. 28 Jun, 2016 1 commit
  12. 16 May, 2016 1 commit
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · d9fd2f54
      Kitware Robot authored
      Run the `Utilities/Scripts/clang-format.bash` script to update
      all our C++ code to a new style defined by `.clang-format`.
      Use `clang-format` version 3.8.
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
  13. 29 Apr, 2016 2 commits
    • Brad King's avatar
      Format include directive blocks and ordering with clang-format · e1c77472
      Brad King authored
      Sort include directives within each block (separated by a blank line) in
      lexicographic order (except to prioritize `sys/types.h` first).  First
      run `clang-format` with the config file:
          SortIncludes: false
      Commit the result temporarily.  Then run `clang-format` again with:
          SortIncludes: true
            - Regex:    'sys/types.h'
              Priority: -1
      Commit the result temporarily.  Start a new branch and cherry-pick the
      second commit.  Manually resolve conflicts to preserve indentation of
      re-ordered includes.  This cleans up the include ordering without
      changing any other style.
      Use the following command to run `clang-format`:
          $ git ls-files -z -- \
              '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' |
            egrep -z -v '(Lexer|Parser|ParserHelper)\.' |
            egrep -z -v '^Source/cm_sha2' |
            egrep -z -v '^Source/(kwsys|CursesDialog/form)/' |
            egrep -z -v '^Utilities/(KW|cm).*/' |
            egrep -z -v '^Tests/Module/GenerateExportHeader' |
            egrep -z -v '^Tests/RunCMake/CommandLine/cmake_depends/test_UTF-16LE.h' |
            xargs -0 clang-format -i
      This selects source files that do not come from a third-party.
      Inspired-by: Daniel Pfeifer's avatarDaniel Pfeifer <daniel@pfeifer-mail.de>
    • Brad King's avatar
      Source: Stabilize include order · 180538c7
      Brad King authored
      Each source file has a logical first include file.  Include it in an
      isolated block so that tools that sort includes do not move them.
  14. 08 Apr, 2016 1 commit
  15. 29 Mar, 2016 3 commits
    • Brad King's avatar
      cmConditionEvaluator: Pre-allocate keyword strings · 5c324294
      Brad King authored
      Calls to `IsKeyword("...")` cause runtime construction of std::string.
      Avoid possible repeated allocation by pre-allocating keyword strings
      during initialization.
    • Brad King's avatar
      cmConditionEvaluator: Remove GetConditionContext method · 2379b3ae
      Brad King authored
      All it does is call cmListFileContext::FromCommandContext, so move this
      to the call sites.
    • Brad King's avatar
      cmConditionEvaluator: Drop unnecessary path conversion · 02fce523
      Brad King authored
      In commit v3.4.0-rc2~1^2 (cmIfCommand: Issue CMP0054 warning with
      appropriate context, 2015-10-20) we added construction of a
      cmListFileContext with conversion of the calling file path.  This code
      path runs on every condition (e.g. `if()`) and so the path conversion
      has a noticeable performance cost.  Fortunately the only use of this
      context is for insertion into cmMakefile::CMP0054ReportedIds so we do
      not need to convert the path.  Simply drop the conversion.
  16. 01 Feb, 2016 1 commit
    • Brad King's avatar
      cmConditionEvaluator: Fix matching of `CMAKE_MATCH_*` values (#15944) · 6ffc4323
      Brad King authored
      While evaluating `if(MATCHES)` we get a `const char*` pointer to the
      string to be matched.  On code like
      the string to be matched may be owned by our own result variables.
      We must move the value to our own buffer before clearing them.
      Otherwise we risk reading freed storage.
  17. 20 Oct, 2015 1 commit
    • Stephen Kelly's avatar
      cmIfCommand: Issue CMP0054 warning with appropriate context. (#15802) · d6a03b47
      Stephen Kelly authored
      Commit v3.4.0-rc1~494^2~4 (cmMakefile: Add API for elseif to create
      backtrace., 2015-05-29) removed the use of cmMakefileCall to push/pop
      execution context in favor of a new way to create backtraces.
      However, a call to cmMakefile::GetExecutionContext is still invoked to
      issue a contextual CMP0054 warning through cmConditionEvaluator.  As
      the elseif is not part of the call stack, this resulted in trying to
      access an empty vector.
      Avoid the attempt at getting execution context when evaluating elseif by
      constructing a context and backtrace on behalf of the cmConditionEvaluator
      in all cases.
  18. 03 Aug, 2015 1 commit
    • Matt McCormick's avatar
      if: Add "TEST <test>" condition · 14e49ed1
      Matt McCormick authored
      if(TEST TestNameThatExists) will return true if a test with the name
      TestNameThatExists has been added with add_test.  The syntax is similar
      to if(TARGET TargetName).  Since use of "TEST" as an argument to if()
      could previously be interpreted as a non-keyword argument, add policy
      CMP0064 to treat it as a keyword as NEW behavior.
  19. 27 Jul, 2015 1 commit
  20. 18 May, 2015 2 commits
  21. 04 May, 2015 1 commit
  22. 30 Apr, 2015 1 commit
  23. 15 Apr, 2015 1 commit
  24. 11 Jan, 2015 2 commits
  25. 03 Dec, 2014 1 commit
  26. 26 Nov, 2014 1 commit
    • Ben Boeckel's avatar
      Revert "ClearMatches: Only clear matches which were actually set" (#15261) · 7d674b5f
      Ben Boeckel authored
      This reverts commit v3.1.0-rc1~557^2~2 (ClearMatches: Only clear matches
      which were actually set, 2014-03-12).  The optimization did not track
      the match count in the same scope as the variables, allowing possible
      Resolve conflicts in Source/cmIfCommand.cxx, Source/cmMakefile.cxx,
      and Source/cmMakefile.h by moving the changes to the new location
      of the code involved.
  27. 11 Sep, 2014 2 commits