1. 30 Jan, 2019 2 commits
  2. 28 Jan, 2019 2 commits
    • Sebastian Holtermann's avatar
      Autogen: Reenable passing compiler implicit include directories to moc · 03dbb62d
      Sebastian Holtermann authored
      Since commit 5990ecb7 (Compute implicit include directories from
      compiler output, 2018-12-07) we now have compiler implicit include
      directory computation for gcc and clang.  It should be safe now to pass
      these to `moc`.  This patch re-enables passing the compiler implicit
      include directories to `moc`, which was disabled due to issue #18669.
      Fixes: #18041
      Issue: #18669
    • Sebastian Holtermann's avatar
      cmLocalGenerator: Simplify `GetIncludeDirectories` · f16dfdf7
      Sebastian Holtermann authored
      This patch strips the `stripImplicitDirs` and `appendAllImplicitDirs`
      parameters from the `cmLocalGenerator::GetIncludeDirectories` method and makes
      it a wrapper into the new `cmLocalGenerator::GetIncludeDirectoriesImplicit`
      method.  `cmLocalGenerator::GetIncludeDirectoriesImplicit` is the renamed old
      implementation of `cmLocalGenerator::GetIncludeDirectories` and still
      accepts `stripImplicitDirs` and `appendAllImplicitDirs`.
      The motivation is that there's only *one* case where
      `cmLocalGenerator::GetIncludeDirectories` is called with the
      `stripImplicitDirs` parameter being `false` (QtAutoGen), but many other places
      where it is called using the `true` default value.
      QtAutoGen is modified to use `cmLocalGenerator::GetIncludeDirectoriesImplicit`
      directly.  In two use cases of `cmLocalGenerator::GetIncludeDirectories`
      the manually set `true` value for `stripImplicitDirs` is removed.
  3. 23 Jan, 2019 1 commit
  4. 21 Jan, 2019 1 commit
  5. 18 Jan, 2019 1 commit
    • Sebastian Holtermann's avatar
      Autogen: Prepend instead of append `mocs_compilation.cpp` to the sources list · 1ed4d48d
      Sebastian Holtermann authored
      `mocs_compilation.cpp` easily takes a long time to compile when it
      contains multiple `moc` files.  When it was appended like before
      we ran into the situation that all smaller sources were already compiled when
      `mocs_compilation.cpp` got compiled at last.  In that case a single core was
      busy but all remaining cores stayed idle.
      To optimize CPU core utilization we now prepend `mocs_compilation.cpp`
      to the sources list instead of appending it.  This allows smaller source files
      to get compiled *while* the long lasting `mocs_compilation.cpp` gets compiled.
      Closes #18793
  6. 17 Jan, 2019 1 commit
  7. 16 Jan, 2019 1 commit
  8. 15 Jan, 2019 2 commits
  9. 10 Jan, 2019 1 commit
    • Tobias Hunger's avatar
      Autogen: Add AUTO(MOC|RCC|UIC)_EXECUTABLE target properties · cd32886b
      Tobias Hunger authored
      Allow to force moc/rcc/uic compiler used for AUTO(MOC|RCC|UIC).
      Setting these properties is only necessary if you are going to do
      strange things like build these tools as part of your own build system.
      Setting these properties will also prevent cmake from testing the
      binary: It is user-provided and assumed to be valid.
  10. 07 Jan, 2019 1 commit
    • Tobias Hunger's avatar
      Autogen: Prepare for Qt 6 · 9045f6a3
      Tobias Hunger authored
      Handle Qt version > 5 in Qt AutoGen.
      This patch does *NOT* include tests and documentation: There is no
      Qt 6 yet. I still need this patch to work on a cmake based build
      system for Qt 6.
  11. 07 Dec, 2018 3 commits
  12. 03 Dec, 2018 1 commit
  13. 28 Nov, 2018 1 commit
  14. 27 Nov, 2018 1 commit
    • Sebastian Holtermann's avatar
      Autogen: Fix empty uic executable string · b1b5004c
      Sebastian Holtermann authored
      In CMake 3.13.0 when a target has ``AUTOUIC`` enabled but doesn't
      link against Qt5Widgets, the uic executable string is empty and
      an error string "The uic executable \"\" does not exist" is generated.
      In CMake 3.12 ``AUTOUIC`` was silently disabled instead.
      This patch fixes the regression and restores the behavior of CMake 3.12.
      Fixes: #18630
  15. 21 Nov, 2018 1 commit
  16. 14 Nov, 2018 1 commit
  17. 11 Nov, 2018 1 commit
  18. 03 Nov, 2018 1 commit
    • Sebastian Holtermann's avatar
      Autogen: Add (CMAKE_)AUTOGEN_ORIGIN_DEPENDS support · b5e895b5
      Sebastian Holtermann authored
      This adds
      - the variable ``CMAKE_AUTOGEN_ORIGIN_DEPENDS`` which initializes
      - the target property ``AUTOGEN_ORIGIN_DEPENDS``
      which controls whether or not the origin target dependencies
      should be forwarded to the corresponding ``_autogen`` target.
      The default value of ``CMAKE_AUTOGEN_ORIGIN_DEPENDS`` is ``ON``
      which corresponds to the behavior that is in place since CMake 3.9.
      Closes: #18493
  19. 18 Oct, 2018 1 commit
  20. 10 Oct, 2018 1 commit
    • Brad King's avatar
      cmLocalGenerator: Remove AddCompileDefinitions method · 8f076acd
      Brad King authored
      This method offers the same definitions as `GetTargetDefines` except
      that it excludes the "export" macro on shared libraries.  Update call
      sites to use `GetTargetDefines` instead.  Some of them were incorrectly
      excluding the export macro.
  21. 18 Sep, 2018 1 commit
  22. 05 Sep, 2018 1 commit
  23. 27 Aug, 2018 1 commit
  24. 13 Aug, 2018 2 commits
  25. 07 Aug, 2018 1 commit
    • Sebastian Holtermann's avatar
      cmGeneratedFileStream: clang-tidy applied to remove redundant ``c_str`` calls · b6802cd5
      Sebastian Holtermann authored
      After changing the ``cmGeneratedFileStream`` methods to accept
      ``std::string const&`` instead of ``const char*`` we don't
      need to call ``std::string::c_str`` anymore when passing
      a ``std::string`` to a ``cmGeneratedFileStream`` method.
      This patch removes all redundant ``std::string::c_str``
      calls when passing a string to a ``cmGeneratedFileStream`` method.
      It was generated by building CMake with clang-tidy enabled using
      the following options:
  26. 30 Jul, 2018 5 commits
  27. 11 Jul, 2018 3 commits
  28. 02 Jul, 2018 1 commit