GitLab

Ben Keller authored May 10, 2016 and Brad King committed Sep 06, 2016

When exporting from a project (with install(EXPORT ...)), the
`<PROJECT>Targets.cmake` file contains logic for computing the
`_IMPORT_PREFIX` from its own location.  This `_IMPORT_PREFIX` is then
used in the `<PROJECT>Targets-<config>.cmake` file to generate the
`IMPORTED_LOCATION_<CONFIG>`.  The generation unconditionally appends a
"/" to `_IMPORT_PREFIX` before appending the rest of the path.  If
`_IMPORT_PREFIX` is "/", then the `IMPORTED_LOCATION_<CONFIG>`
properties all start with exactly two leading slashes ("//").

Exactly two leading slashes is a special case in POSIX file paths, such
that its interpretation is left up to the implementation.  This means
that changing the path prefix from "/" to "//" should not be allowed.

Since references to `_IMPORT_PREFIX` are always followed by a "/",
simply check the value to replace "/" with "".

Brad King authored Sep 06, 2016 and Kitware Robot committed Sep 06, 2016

f6fd0abc Genex: Diagnose invalid LINK_ONLY usage instead of crashing

Brad King authored Sep 06, 2016 and Kitware Robot committed Sep 06, 2016

72ecdd34 Tests: Cleanup RunCMake.GenerateExportHeader somewhat
fc3dab0e Tests: Port GenerateExportHeader test to RunCMake infrastructure
4feba34d GNU: Do not use -fvisibility on AIX or HP-UX

Brad King authored Sep 06, 2016 and Kitware Robot committed Sep 06, 2016

4ffdd564 CPack/DEB: Add option to select archive type

Brad King authored Sep 06, 2016 and Kitware Robot committed Sep 06, 2016

1a9de803 surround macro arguments with parentheses

Brad King authored Sep 06, 2016 and Kitware Robot committed Sep 06, 2016

0039ffa2 use CM_NULLPTR

Brad King authored Sep 06, 2016 and Kitware Robot committed Sep 06, 2016

62c5f9af QtDialog: fix clang-tidy warnings

This will allow build failure cases to be added later.

Use of `-fvisibility=hidden` warns:

  warning: visibility attribute not supported in this configuration; ignored

Brad King authored Sep 05, 2016 and Kitware Robot committed Sep 05, 2016

32f756c8 CursesDialog: include what you use

Brad King authored Sep 05, 2016 and Kitware Robot committed Sep 05, 2016

60dcaaea tidy: Fix readability-redundant-string-cstr issues

Domen Vrankar authored Sep 04, 2016 and Brad King committed Sep 05, 2016

Add a `CPACK_DEBIAN_ARCHIVE_TYPE` option that can be used to select an
archive type that supports long file names.

Closes: #14332

When `$<LINK_ONLY:...>` is used outside of linking we may evaluate it
without a `dagChecker`.  Do not dereference the NULL pointer and issue a
diagnostic instead.

Closes: #16287

Brad King authored Sep 03, 2016 and Kitware Robot committed Sep 03, 2016

efed6468 fix a load of include-what-you-use violations
bd3d0eaf cmCTest: don't redefine cout and cerr
3838a0d5 make sure to include cmConfigure.h before cmStandardIncludes.h
54140848 Tests/CMakeLib: include what you use
3f9c4cdf Tests/CMakeLib: use cmsys::ifstream

Brad King authored Sep 03, 2016 and Kitware Robot committed Sep 03, 2016

c03a7b4f CTestCustom: Suppress scan-build warnings in libuv
3825a564 libuv: Simplify variable initializations to satisfy Clang scan-build

Brad King authored Sep 03, 2016 and Kitware Robot committed Sep 03, 2016

b61eab24 FindHDF5: Fix regression in providing HDF5_IS_PARALLEL

Brad King authored Sep 03, 2016 and Kitware Robot committed Sep 03, 2016

befe8648 FindHDF5: Fix regression in finding hdf5hl_fortran

Daniel Pfeifer authored Sep 01, 2016 and Brad King committed Sep 03, 2016

The definitions have been introduced to ensure that cout and cerr are
not used in certain files.  However, this limitation does not apply to
all source files that require cmCTest.h to be included.  Furthermore,
the definitions cause side effects depending on the include order.  In
total, the definitions do more harm than good.  Remove them.

Clang scan-build warns in some expansions of RB_GENERATE_STATIC
that it has a "Dereference of null pointer".  It also warns that
"The left operand of '==' is a garbage value" strangely.  Simply
suppress these since this is third-party code anyway.

Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
to correctly find HL for all bindings, 2016-05-12) accidentally dropped
the name `hdf5hl_fortran` from the list of library names and replaced it
with `hdf5_hl_fortran`.  IIUC the latter name is when HDF5 is built with
CMake and the former name is for other build systems.  Since this is the
non-CMake code path, user the former name.

Closes: #16233

Since commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of compiler
wrappers, 2016-04-01) we have additional code paths that find HDF5 and
suppress the original search logic.  Report HDF5_IS_PARALLEL from these
other code paths too.

Closes: #16257

Brad King authored Sep 02, 2016 and Kitware Robot committed Sep 02, 2016

228f4e9b cmFilePathUuid: Use Base32 string instead of Base64 string
b481ddb3 Add cmBase32Encoder class

Brad King authored Sep 02, 2016 and Kitware Robot committed Sep 02, 2016

0cbaaf2d GenerateExportHeader: Fix add_compiler_export_flags regression

Brad King authored Sep 02, 2016 and Kitware Robot committed Sep 02, 2016

9998774f VS: Fix VS 2015 .vcxproj debug setting for v80 toolset

Sebastian Holtermann authored Sep 01, 2016 and Brad King committed Sep 02, 2016

This produces files that will not collide on a case-insensitive
filesystem.  It also avoids the need for special character
substitutions.