A patch update will be applied today - June 21st between 1pm - 1:45pm EDT (UTC-0400). GitLab will go down a few minutes within that time.

Commit ff5823f5 authored by Rolf Eike Beer's avatar Rolf Eike Beer
Browse files

cmOutputConverter: mark helper functions static

This allows the linker to entirely drop any symbols of the functions.
parent 674c5b30
...@@ -342,13 +342,12 @@ use the caret character itself (^), use two in a row (^^). ...@@ -342,13 +342,12 @@ use the caret character itself (^), use two in a row (^^).
*/ */
/* Some helpers to identify character classes */ /* Some helpers to identify character classes */
namespace { static int Shell__CharIsWhitespace(char c)
inline int Shell__CharIsWhitespace(char c)
{ {
return ((c == ' ') || (c == '\t')); return ((c == ' ') || (c == '\t'));
} }
inline int Shell__CharNeedsQuotesOnUnix(char c) static int Shell__CharNeedsQuotesOnUnix(char c)
{ {
return ((c == '\'') || (c == '`') || (c == ';') || (c == '#') || return ((c == '\'') || (c == '`') || (c == ';') || (c == '#') ||
(c == '&') || (c == '$') || (c == '(') || (c == ')') || (c == '~') || (c == '&') || (c == '$') || (c == '(') || (c == ')') || (c == '~') ||
...@@ -356,17 +355,16 @@ inline int Shell__CharNeedsQuotesOnUnix(char c) ...@@ -356,17 +355,16 @@ inline int Shell__CharNeedsQuotesOnUnix(char c)
(c == '\\')); (c == '\\'));
} }
inline int Shell__CharNeedsQuotesOnWindows(char c) static int Shell__CharNeedsQuotesOnWindows(char c)
{ {
return ((c == '\'') || (c == '#') || (c == '&') || (c == '<') || return ((c == '\'') || (c == '#') || (c == '&') || (c == '<') ||
(c == '>') || (c == '|') || (c == '^')); (c == '>') || (c == '|') || (c == '^'));
} }
inline int Shell__CharIsMakeVariableName(char c) static int Shell__CharIsMakeVariableName(char c)
{ {
return c && (c == '_' || isalpha((static_cast<int>(c)))); return c && (c == '_' || isalpha((static_cast<int>(c))));
} }
}
int cmOutputConverter::Shell__CharNeedsQuotes(char c, int flags) int cmOutputConverter::Shell__CharNeedsQuotes(char c, int flags)
{ {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment