Commit e863496a authored by Brad King's avatar Brad King 💬 Committed by Kitware Robot
Browse files

Merge topic 'minor-cleanups'

dcd443d4 cmTarget: Clean up the InsertCompileDefinition implementation.
parents 2e2552af dcd443d4
...@@ -1620,16 +1620,11 @@ void cmTarget::InsertCompileOption(const cmValueWithOrigin &entry, ...@@ -1620,16 +1620,11 @@ void cmTarget::InsertCompileOption(const cmValueWithOrigin &entry,
} }
//---------------------------------------------------------------------------- //----------------------------------------------------------------------------
void cmTarget::InsertCompileDefinition(const cmValueWithOrigin &entry, void cmTarget::InsertCompileDefinition(const cmValueWithOrigin &entry)
bool before)
{ {
cmGeneratorExpression ge(entry.Backtrace); cmGeneratorExpression ge(entry.Backtrace);
std::vector<cmTargetInternals::TargetPropertyEntry*>::iterator position this->Internal->CompileDefinitionsEntries.push_back(
= before ? this->Internal->CompileDefinitionsEntries.begin()
: this->Internal->CompileDefinitionsEntries.end();
this->Internal->CompileDefinitionsEntries.insert(position,
new cmTargetInternals::TargetPropertyEntry(ge.Parse(entry.Value))); new cmTargetInternals::TargetPropertyEntry(ge.Parse(entry.Value)));
} }
......
...@@ -531,8 +531,7 @@ public: ...@@ -531,8 +531,7 @@ public:
bool before = false); bool before = false);
void InsertCompileOption(const cmValueWithOrigin &entry, void InsertCompileOption(const cmValueWithOrigin &entry,
bool before = false); bool before = false);
void InsertCompileDefinition(const cmValueWithOrigin &entry, void InsertCompileDefinition(const cmValueWithOrigin &entry);
bool before = false);
void AppendBuildInterfaceIncludes(); void AppendBuildInterfaceIncludes();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment