Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
CMake
CMake
Commits
b61c268b
Commit
b61c268b
authored
Oct 04, 2016
by
Stephen Kelly
1
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Convert: Extract local variables for readability
parent
e278f5a8
Pipeline
#29744
passed with stage
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
12 deletions
+13
-12
Source/cmOutputConverter.cxx
Source/cmOutputConverter.cxx
+13
-12
No files found.
Source/cmOutputConverter.cxx
View file @
b61c268b
...
...
@@ -91,21 +91,22 @@ std::string cmOutputConverter::ConvertToRelativePath(
return
remote_path
;
}
const
std
::
string
relativePathTopBinary
=
this
->
StateSnapshot
.
GetDirectory
().
GetRelativePathTopBinary
();
const
std
::
string
relativePathTopSource
=
this
->
StateSnapshot
.
GetDirectory
().
GetRelativePathTopSource
();
const
bool
bothInBinary
=
cmOutputConverterNotAbove
(
local_path
.
c_str
(),
this
->
StateSnapshot
.
GetDirectory
().
GetRelativePathTopBinary
())
&&
cmOutputConverterNotAbove
(
remote_path
.
c_str
(),
this
->
StateSnapshot
.
GetDirectory
().
GetRelativePathTopBinary
());
cmOutputConverterNotAbove
(
local_path
.
c_str
(),
relativePathTopBinary
.
c_str
())
&&
cmOutputConverterNotAbove
(
remote_path
.
c_str
(),
relativePathTopBinary
.
c_str
());
const
bool
bothInSource
=
cmOutputConverterNotAbove
(
local_path
.
c_str
(),
this
->
StateSnapshot
.
GetDirectory
().
GetRelativePathTopSource
())
&&
cmOutputConverterNotAbove
(
remote_path
.
c_str
(),
this
->
StateSnapshot
.
GetDirectory
().
GetRelativePathTopSource
());
cmOutputConverterNotAbove
(
local_path
.
c_str
(),
relativePathTopSource
.
c_str
())
&&
cmOutputConverterNotAbove
(
remote_path
.
c_str
(),
relativePathTopSource
.
c_str
());
if
(
!
(
bothInSource
||
bothInBinary
))
{
return
remote_path
;
...
...
Brad King
@brad.king
Mentioned in commit
9c4d1056
·
Oct 07, 2016
Mentioned in commit
9c4d1056
Mentioned in commit 9c4d105680c99e194c6d6063315ee2affd2a7b63
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment