Commit 7ed7db88 authored by Craig Scott's avatar Craig Scott
Browse files

CPackIFW: Fix cppcheck warnings

The cppcheck warnings about uninitialised variables are likely harmless,
since they are initialised in ParseResource() anyway. Fix the warnings
anyway to reduce linting noise. The warning about a single argument
non-explicit constructor is worth fixing in general.
parent f388ce53
...@@ -275,9 +275,8 @@ void cmCPackIFWInstaller::ConfigureFromOptions() ...@@ -275,9 +275,8 @@ void cmCPackIFWInstaller::ConfigureFromOptions()
class cmCPackIFWResourcesParser : public cmXMLParser class cmCPackIFWResourcesParser : public cmXMLParser
{ {
public: public:
cmCPackIFWResourcesParser(cmCPackIFWInstaller* i) explicit cmCPackIFWResourcesParser(cmCPackIFWInstaller* i)
: installer(i) : installer(i)
, file(false)
{ {
this->path = i->Directory + "/resources"; this->path = i->Directory + "/resources";
} }
...@@ -296,7 +295,9 @@ public: ...@@ -296,7 +295,9 @@ public:
} }
cmCPackIFWInstaller* installer; cmCPackIFWInstaller* installer;
bool file, hasFiles, hasErrors; bool file = false;
bool hasFiles = false;
bool hasErrors = false;
std::string path, basePath; std::string path, basePath;
protected: protected:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment