cleanup: Prefer compiler provided special member functions

Source/CTest/cmCTestGIT.cxx

@@ -475,7 +475,6 @@ private:
     std::string EMail;
     unsigned long Time = 0;
     long TimeZone = 0;
-    Person() = default;
   };
 
   void ParsePerson(const char* str, Person& person)

Source/CTest/cmCTestMultiProcessHandler.cxx

@@ -44,7 +44,6 @@ public:
     : Handler(handler)
   {
   }
-  ~TestComparator() = default;
 
   // Sorts tests in descending order of cost
   bool operator()(int index1, int index2) const

Source/CTest/cmCTestRunTest.h

@@ -27,8 +27,6 @@ class cmCTestRunTest
 public:
   explicit cmCTestRunTest(cmCTestMultiProcessHandler& multiHandler);
 
-  ~cmCTestRunTest() = default;
-
   void SetNumberOfRuns(int n) { this->NumberOfRunsLeft = n; }
   void SetRunUntilFailOn() { this->RunUntilFail = true; }
   void SetTestProperties(cmCTestTestHandler::cmCTestTestProperties* prop)

Source/CTest/cmCTestScriptHandler.cxx

@@ -53,8 +53,6 @@ struct cmListFileFunction;
 class cmCTestScriptFunctionBlocker : public cmFunctionBlocker
 {
 public:
-  cmCTestScriptFunctionBlocker() = default;
-  ~cmCTestScriptFunctionBlocker() override = default;
   bool IsFunctionBlocked(const cmListFileFunction& lff, cmMakefile& mf,
                          cmExecutionStatus& /*status*/) override;
   // virtual bool ShouldRemove(const cmListFileFunction& lff, cmMakefile &mf);

Source/CTest/cmCTestSubmitHandler.cxx

@@ -29,10 +29,6 @@ typedef std::vector<char> cmCTestSubmitHandlerVectorOfChar;
 
 class cmCTestSubmitHandler::ResponseParser : public cmXMLParser
 {
-public:
-  ResponseParser() { this->Status = STATUS_OK; }
-  ~ResponseParser() override = default;
-
 public:
   enum StatusType
   {
@@ -41,7 +37,7 @@ public:
     STATUS_ERROR
   };
 
-  StatusType Status;
+  StatusType Status = STATUS_OK;
   std::string Filename;
   std::string MD5;
   std::string Message;

Source/CTest/cmParseCoberturaCoverage.cxx

@@ -13,19 +13,12 @@ class cmParseCoberturaCoverage::XMLParser : public cmXMLParser
 {
 public:
   XMLParser(cmCTest* ctest, cmCTestCoverageHandlerContainer& cont)
-    : CTest(ctest)
+    : FilePaths{ cont.SourceDir, cont.BinaryDir }
+    , CTest(ctest)
     , Coverage(cont)
   {
-    this->InSources = false;
-    this->InSource = false;
-    this->SkipThisClass = false;
-    this->FilePaths.push_back(this->Coverage.SourceDir);
-    this->FilePaths.push_back(this->Coverage.BinaryDir);
-    this->CurFileName.clear();
   }
 
-  ~XMLParser() override = default;
-
 protected:
   void EndElement(const std::string& name) override
   {
@@ -144,9 +137,9 @@ protected:
   }
 
 private:
-  bool InSources;
-  bool InSource;
-  bool SkipThisClass;
+  bool InSources = false;
+  bool InSource = false;
+  bool SkipThisClass = false;
   std::vector<std::string> FilePaths;
   typedef cmCTestCoverageHandlerContainer::SingleFileCoverageVector
     FileLinesType;

Source/CTest/cmParseJacocoCoverage.cxx

@@ -18,13 +18,8 @@ public:
     : CTest(ctest)
     , Coverage(cont)
   {
-    this->FilePath.clear();
-    this->PackagePath.clear();
-    this->PackageName.clear();
   }
 
-  ~XMLParser() override = default;
-
 protected:
   void EndElement(const std::string& /*name*/) override {}
 

Source/cmCPluginAPI.cxx

@@ -474,7 +474,6 @@ int CCONV cmGetTotalArgumentSize(int argc, char** argv)
 // API for source files.
 struct cmCPluginAPISourceFile
 {
-  cmCPluginAPISourceFile() = default;
   cmSourceFile* RealSourceFile = nullptr;
   std::string SourceName;
   std::string SourceExtension;

Source/cmCTest.h

@@ -57,8 +57,6 @@ public:
   /** Representation of one part.  */
   struct PartInfo
   {
-    PartInfo() = default;
-
     void SetName(const std::string& name) { this->Name = name; }
     const std::string& GetName() const { return this->Name; }
 

Source/cmCacheManager.h

@@ -42,7 +42,6 @@ private:
     void AppendProperty(const std::string& property, const char* value,
                         bool asString = false);
     bool Initialized = false;
-    CacheEntry() = default;
   };
 
 public:

Source/cmCommandArgumentsHelper.h

@@ -172,8 +172,6 @@ class cmCommandArgumentGroup
   friend class cmCommandArgument;
 
 public:
-  cmCommandArgumentGroup() = default;
-
   /// All members of this group may follow the given argument
   void Follows(const cmCommandArgument* arg);
 

Source/cmComputeLinkDepends.h

@@ -38,8 +38,6 @@ public:
     cmGeneratorTarget const* Target = nullptr;
     bool IsSharedDep = false;
     bool IsFlag = false;
-    LinkEntry() = default;
-    LinkEntry(LinkEntry const& r) = default;
   };
 
   typedef std::vector<LinkEntry> EntryVector;

Source/cmDependsC.h

@@ -75,7 +75,6 @@ public:
 
   struct cmIncludeLines
   {
-    cmIncludeLines() = default;
     std::vector<UnscannedEntry> UnscannedEntries;
     bool Used = false;
   };

Source/cmDocumentation.h

@@ -115,7 +115,6 @@ private:
 
   struct RequestedHelpItem
   {
-    RequestedHelpItem() = default;
     cmDocumentationEnums::Type HelpType = None;
     std::string Filename;
     std::string Argument;

Source/cmExecutionStatus.h

@@ -11,8 +11,6 @@
 class cmExecutionStatus
 {
 public:
-  cmExecutionStatus() = default;
-
   void Clear()
   {
     this->ReturnInvoked = false;

Source/cmFileCommand.cxx

@@ -1102,7 +1102,6 @@ protected:
   {
     bool Exclude = false;
     mode_t Permissions = 0;
-    MatchProperties() = default;
   };
   struct MatchRule
   {

Source/cmFileMonitor.cxx

@@ -19,7 +19,6 @@ void on_fs_close(uv_handle_t* handle);
 class cmIBaseWatcher
 {
 public:
-  cmIBaseWatcher() = default;
   virtual ~cmIBaseWatcher() = default;
 
   virtual void Trigger(const std::string& pathSegment, int events,
@@ -150,8 +149,6 @@ public:
     p->AddChildWatcher(ps, this);
   }
 
-  ~cmRealDirectoryWatcher() override = default;
-
   void StartWatching() final
   {
     if (!this->Handle) {

Source/cmFindLibraryCommand.cxx

@@ -202,7 +202,6 @@ struct cmFindLibraryHelper
     bool TryRaw = false;
     std::string Raw;
     cmsys::RegularExpression Regex;
-    Name() = default;
   };
   std::vector<Name> Names;
 

Source/cmFindPackageCommand.cxx

@@ -1688,7 +1688,6 @@ private:
 class cmFileList
 {
 public:
-  cmFileList() = default;
   virtual ~cmFileList() = default;
   cmFileList& operator/(cmFileListGeneratorBase const& rhs)
   {

Source/cmFunctionCommand.cxx

@@ -14,11 +14,6 @@
 class cmFunctionHelperCommand : public cmCommand
 {
 public:
-  cmFunctionHelperCommand() = default;
-
-  ///! clean up any memory allocated by the function
-  ~cmFunctionHelperCommand() override = default;
-
   /**
    * This is a virtual constructor for the command.
    */