Skip to content
  • Brad King's avatar
    Windows: Restore suppression of error report popups in CI builds · a4c19cb8
    Brad King authored
    On Windows, libuv uses `_CrtSetReportHook` to install a handler it uses
    to suppress assertions on invalid file descriptors in `_get_osfhandle`.
    This removes the handler we install in CI environments to suppress
    interactive popups.  Move installation of our handler to after libuv is
    initialized so that our handler is actually used.
    
    Unfortunately this also removes libuv's handler and so may cause Debug
    builds under CI to abort on invalid file descriptors instead of simply
    converting them to `INVALID_HANDLE_VALUE`.  If this becomes a problem
    we may need to modify libuv to make its hook more configurable.
    a4c19cb8