• David Cole's avatar
    CPack: Fix retry logic when calls to hdiutil fail · 05a76d53
    David Cole authored
    The long-standing sporadic failures of CPack tests on the Mac dashboards
    are caused by an occasional problem running hdiutil. To compensate for
    this, a retry loop was added in the code in a previous commit: a9fa71a4
    ... but the logic for breaking out of the retry loop was flawed, breaking
    out of the loop (and not retrying) when the hdiutil command returns an
    error instead of when it returns success.
    This commit fixes the flawed logic, bumps up the number of retries from
    4 to 10, and adds a half-second delay in between retries.
    The delay is specifically added in case a virus checker or spotlight indexer
    is temporarily causing the hdiutil failure by hanging onto a newly created
    file longer than hdiutil expects it to.
    As with all sporadically occurring issues, we'll never know if this is
    really fixed all the way. But I'll be happy even if we can only get it to
    happen just a bit less often.
cmCPackOSXX11Generator.cxx 10.8 KB