Previously, point fields compressed by ZFP were attached as point fields
on the output. However, using them as a point field would cause
problems. So, instead attache them as WholeDataSet
fields.
Also fixed a problem where the 1D decompressor created an output of the wrong size.
@kmorel I see the build passed but a few tests failed. I guess the testing system isn't very stable. I'm going to approve this MR.
@kmorel Sorry about the late reply. These changes make sense to me, so I'm fine with approving them. But there is a build failure in the job: 7458224 (build:ascent). Should we worry about that?
Do: merge
@vbolea Yes. I think that's not related to this MR. Should I leave a comment with Do: merge
to merge this MR?
@vbolea Thanks! It seems that the CI external tests hang due to some reason. I cannot open the page when I click on it. Do you have any idea what is wrong?
@vbolea Oh, I didn't see your message. I manually checkout all files under .gitlab in the master branch and replaced those files in my branch, so there are no CI-related file changes. Would that be ok?
Jieyang Chen (a157c0e8) at 01 Oct 15:27
Add changes for supporting Kokkos/HIP
Jieyang Chen (9c67cc78) at 01 Oct 14:52
Add changes for supporting Kokkos/HIP
... and 21 more commits
Jieyang Chen (a607679c) at 30 Sep 22:52
Merge topic 'enable-testing-lib-find-pkg'
... and 28 more commits
@vbolea What's the best way to squash all of the commits into a single one? Should I copy files and create a new MR?
I already disabled those tests in the latest commit. It seems that it can pass all build and unit tests in CI check. Since it is 5 commits behind the master, I'm going to rebase again. Please let me know if there is anything else that I need to do to get this merged. Thanks!
Do: reformat
Jieyang Chen (678fdc7e) at 20 Sep 16:43
disable two failing unit tests
@dpugmire @vbolea @kmorel The HIP version can now successfully pass the CI build. Two unit tests that are yet to be fixed are causing the CI test to fail. Should I disable those two for this MR? Or just keep them in there?
Also, what does the 'ghostflow-branch...' check do? It is failing but I don't know how to fix that. Thanks!
Jieyang Chen (30d4763f) at 18 Sep 00:22
disable two benchmarks that are taking too long to compile with hipcc
Jieyang Chen (9e478d68) at 17 Sep 09:49
Merge branch 'hip-support' of https://gitlab.kitware.com/cjy7117/vt...
... and 1 more commit