Commit c0252d9d authored by Brad King's avatar Brad King Committed by Code Review
Browse files

Merge "SystemInformation: Improve comments in private implementation"

parents c38ba638 58308145
...@@ -443,7 +443,7 @@ public: ...@@ -443,7 +443,7 @@ public:
}; };
protected: protected:
// Functions. // For windows
bool RetrieveCPUFeatures(); bool RetrieveCPUFeatures();
bool RetrieveCPUIdentity(); bool RetrieveCPUIdentity();
bool RetrieveCPUCacheDetails(); bool RetrieveCPUCacheDetails();
...@@ -457,6 +457,7 @@ protected: ...@@ -457,6 +457,7 @@ protected:
bool RetrieveClassicalCPUIdentity(); bool RetrieveClassicalCPUIdentity();
bool RetrieveExtendedCPUIdentity(); bool RetrieveExtendedCPUIdentity();
// Processor information
Manufacturer ChipManufacturer; Manufacturer ChipManufacturer;
CPUFeatures Features; CPUFeatures Features;
ID ChipID; ID ChipID;
...@@ -464,11 +465,11 @@ protected: ...@@ -464,11 +465,11 @@ protected:
unsigned int NumberOfLogicalCPU; unsigned int NumberOfLogicalCPU;
unsigned int NumberOfPhysicalCPU; unsigned int NumberOfPhysicalCPU;
int CPUCount(); int CPUCount(); // For windows
unsigned char LogicalCPUPerPhysicalCPU(); unsigned char LogicalCPUPerPhysicalCPU();
unsigned char GetAPICId(); unsigned char GetAPICId(); // For windows
bool IsHyperThreadingSupported(); bool IsHyperThreadingSupported();
static LongLong GetCyclesDifference(DELAY_FUNC, unsigned int); static LongLong GetCyclesDifference(DELAY_FUNC, unsigned int); // For windows
// For Linux and Cygwin, /proc/cpuinfo formats are slightly different // For Linux and Cygwin, /proc/cpuinfo formats are slightly different
bool RetreiveInformationFromCpuInfoFile(); bool RetreiveInformationFromCpuInfoFile();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment