Our shell jobs on Windows use the default `GIT_CLONE_PATH`,
which contains `CI_CONCURRENT_ID`.  Therefore the jobs can use
a concurrent runner.

Teach jobs to load the environment for a specific MSVC version, and tag
them accordingly.  This allows runners to have multiple versions of MSVC
installed without requiring us to compile on the newer ones right away.

The runners provide the VS 2019 location in a `VS160COMNTOOLS`
environment variable.  Use it to avoid requiring a specific VS edition.

Issue: #595

Kenneth Moreland authored Feb 04, 2021 and Kitware Robot committed Feb 04, 2021

99e613d3 Avoid conversion warnings in `RecombineVec` copy
4c524de6 Fix inverted `ArrayCopy` arguments
fa4da95e Add changelog for copying UnknownArrayHandle
1faed371 Remove the use of ResetTypes for ArrayCopy
ad703368 Change ArrayCopy of UnknownArrayHandle to limit types
916a01d7 Add general `ArrayCopy` between `UnknownArrayHandle`s
26ea2ab4 Break circular dependency of ArrayCopy.h and UnknownArrayHandle.h
990cc9ec

 Test copying UnknownArrayHandle

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Sujin Philip <sujin.philip@kitware.com>
Merge-request: !2396

Unfortunately, there is no way to specify when copying `RecombineVec`s
whether we wish to allow precision loss in conversions. Because
sometimes we need them, disable the warnings.

Also fix condition where a `UnknownArrayHandle` destination does not
have an underlying `ArrayHandle` set yet.

It used to be the case where you needed to call `ResetTypes` on a
`VariantArrayHandle` before using `ArrayCopy` to limit the types it gets
compiled for. However, there is now a general form for
`UnknownArrayHandle`, so `ResetTypes` no longer does anything useful in
this case. Remove the use of that.

Rather than copy every type to every other type, only copy for the same
base type or copy to/from FloatDefault. This should reduce the amount of
code generated by a lot.

This reduces the size of the .o for ArrayCopy.cxx on my mac from
21MB to 7.7MB.

Add an overload of `ArrayCopy` that takes `UnknownArrayHandle`s and
copies them for (almost) any `ArrayHandle` type.

The code uses `CastAndCallWithExtractedArray` to reduce the total number
of copy conditions to about 100, which are all precompiled into the
library. On a debug build on my mac, this creates a .o file of 21MB.
That's not great, but not terrible. Hopefully, this can be used to
consolidate copy implementations elsewhere.

The circular dependency came from UnknownArrayHandle.h needing
VTKmDefaultTypes.h, which needed all the cell set types. Some of those
cell sets used ArrayCopy in templated functions. Changed those functions
to directly deep copy the ArrayHandle.

Gunther Weber authored Feb 02, 2021 and Kitware Robot committed Feb 02, 2021

7ed0cd15 Fix deprecation warning
c9af2875 Fix ValueType error in pre-split data read
cea11732 Reverse error check in ContourTreeMaker
5005b5d4

 Updated ContourTreeMesh::DebugPrint / ContourTreeMaker::DebugPrintt to use per-call build guards

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2394

Gunther Weber authored Feb 01, 2021 and Kitware Robot committed Feb 01, 2021

c59d8b25 Use test_equal_ArrayHandles instead of custom functions ArraysEqual
06ab386a Added test for combinining contour tree meshes
3d5adf33

 Re-enabled tests with external files (and added required files to Git LFS)

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !2344

Kenneth Moreland authored Feb 01, 2021 and Kitware Robot committed Feb 01, 2021

34412ff2 Deprecate ArrayHandle::Shrink
eb90a608

 Update documentation for Storage

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2392

Kenneth Moreland authored Feb 01, 2021 and Kitware Robot committed Feb 01, 2021

880d26d6 Add test for UnknownArrayHandle::NewInstanceFloatBasic
d51fdadd

 Add UnknownArrayHandle::NewInstanceFloatBasic

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Dave Pugmire <dpugmire@gmail.com>
Merge-request: !2395

This provides the ability to convert an array handle of an unknown value
type to an array handle that has `vtkm::FloatDefault` as its base
component type. Thus subsequently lets you pull the components as
`vtkm::FloatDefault` without having to worry about type conflicts.

This method has been subsumed by Allocate with vtkm::CopyFlag::On.

Gunther Weber authored Jan 29, 2021 and Kitware Robot committed Jan 29, 2021

239adf59

 Fix typos in functor names for contour tree

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !2393

Gunther Weber authored Jan 28, 2021 and Kitware Robot committed Jan 28, 2021

5d8a67ef

 Re-enable marching cubes unit tests for disitrbuted contour tree

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2391

Gunther Weber authored Jan 28, 2021 and Kitware Robot committed Jan 28, 2021

0183db68 Split array access into separate lines and add VTKM_ASSERT
0a33737e

 Re-enable unit tests for ContourTreeUniformAugmentedFilter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !2390

Kenneth Moreland authored Jan 26, 2021 and Kitware Robot committed Jan 26, 2021

8b133288 Fix deprecation warnings
b085cde3 Fix runaway deprecation suppression
3f5193d2

 Consolidate getting a scalar field array

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Sujin Philip <sujin.philip@kitware.com>
Merge-request: !2387

There was an error that caused deprecation warnings in VTK-m to be
suppressed, which meant that many uses of deprecated features went
unnoticed. This fixes those deprecation warnings.

The majority of the warnings were caused by the use of the deprecated
`Cast`, `CopyTo`, and `ResetTypes` methods of `UnknownArrayHandle` (or
`VariantArrayHandle`). Both `Cast` and `CopyTo` have been subsumed by
`AsArrayHandle` (to make the functionality more clear). `ResetTypes` now
requires a second template argument to define the storage types to try.

Also fixed some issues with `SerializableField` being deprecated.
This class is no longer necessary because `Field` can now be directly
serialized.

Field.h had a runaway deprecation suppression where the pragmas to
suppress deprecation warnings were turned on but not properly turned
off. This caused deprecation warnings to be turned off for anything
including Field.h (directly or indirectly), and consequently lots of use
of deprecated features went unnoticed.

There are several places in the ray casting library that require
operating on a field that we know is a scalar field. Previously, these
were all independently cast to an uncertain array of the limited types.
Rather than have independent calls everywere, make a consolidated
function that does the same operation for everyone.

This fixes an issue with using a deprecated version of a method. It also
makes it possible to quickly change types in the future.

Kenneth Moreland authored Jan 25, 2021 and Kitware Robot committed Jan 25, 2021

c6c44924

 Fix CUDA build for logistic map example.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !2386