1. 07 Jul, 2014 1 commit
  2. 23 Jun, 2014 4 commits
    • Brad King's avatar
      cmTarget: Lookup targets in LinkInterface and LinkImplementation · d912220e
      Brad King authored
      Instead of storing just the string names in these structures, lookup any
      target associated with each item and store its cmTarget pointer.  Use
      the cmLinkItem class to hold the name and pointer together.  Update
      client sites to use the pre-stored lookup result instead of looking up
      the target name again.
      Create a cmTarget::LookupLinkItems helper method to handle the lookup.
      Since lookups are now moving from cmComputeLinkDepends::AddLinkEntries
      to cmTarget::LookupLinkItems, move use of CheckCMP0004 to the latter.
      This drops use of CheckCMP0004 from entries added for _LIB_DEPENDS
      variables by cmComputeLinkDepends::AddVarLinkEntries, but I do not
      think that use was intentional originally anyway.
    • Brad King's avatar
      cmTarget: Add GetUtilityItems to get target ordering dependencies · 097be413
      Brad King authored
      Add a method like GetUtilities but that provides the target names
      already looked up and resolved to cmTarget pointers internally.  Update
      call site in cmComputeTargetDepends::AddTargetDepend to use the
      already-found target instead of looking it up again.
    • Brad King's avatar
      cmTarget: Remove 'head' argument from GetLinkImplementation · 0dc9e88d
      Brad King authored
      Many of the 'head' arguments added by commit v2.8.11~289^2~1 (Make
      linking APIs aware of 'head' target, 2013-01-04) turned out not to be
      needed.  The "link implementation" of a target never needs to be
      computed with anything but itself as the 'head' target (except for
      CMP0022 OLD behavior because then it is the link interface).
      Remove the unused 'head' target paths.  Add "internal" versions of
      cmTarget::GetDirectLinkLibraries and GetLinkImplementationLibraries
      to support the CMP0022 OLD behavior without otherwise exposing the
      'head' target option of these methods.
    • Brad King's avatar
      cmComputeTargetDepends: Remove unused 'linking' argument · 7b859389
      Brad King authored
      The AddInterfaceDepends method is never called with a non-true value for
      its 'linking' argument.  Drop it.
  3. 05 Jun, 2014 1 commit
  4. 02 Apr, 2014 3 commits
    • Stephen Kelly's avatar
      cmTarget: Make the source files depend on the config. · e6971df6
      Stephen Kelly authored
      Disallow the use of config-specific source files with
      the Visual Studio and Xcode generators. They don't have
      any way to represent the condition currently.
      Use the same common-config API in cmQtAutoGenerators. While
      it accepts config-specific files, it doesn't have to support
      multiple configurations yet.
      Loop over the configs in cmTargetTraceDependencies
      and cmGlobalGenerator::WriteSummary and consume all source
      Loop over the configs in cmComputeTargetDepends and compute the
      object library dependencies for each config.
    • Stephen Kelly's avatar
      cmComputeTargetDepends: Use valid config to compute target depends. · 869328aa
      Stephen Kelly authored
      If CMAKE_BUILD_TYPE is set, and user code contains:
       target_link_libraries(myexe prefix_$<$<CONFIG:Debug>:debug>)
      then the computation with an empty config was computing a target-level
      dependency on a target or library called prefix_, and a dependency
      on a target or library called prefix_debug (as expected).
      The existing logic skips 'prefix_' because it is not a known target,
      and defers to the link-dependencies logic to find the library. The
      link-dependencies logic does not incorrectly handle the config as
      cmComputeTargetDepends did, and so did not encounter 'prefix_'
      during its computation. This likely had no effect on the generated
    • Stephen Kelly's avatar
      cmComputeTargetDepends: Track object library depends. · c355d108
      Stephen Kelly authored
      Relieve cmGeneratorTarget of that responsibility.
  5. 31 Mar, 2014 1 commit
  6. 11 Mar, 2014 1 commit
    • Stephen Kelly's avatar
      Remove some c_str() calls. · 21c573f6
      Stephen Kelly authored
      Use the clang RemoveCStrCalls tool to automatically migrate the
      code. This was only run on linux, so does not have any positive or
      negative effect on other platforms.
  7. 08 Mar, 2014 3 commits
  8. 06 Mar, 2014 1 commit
  9. 16 Jan, 2014 1 commit
    • Rolf Eike Beer's avatar
      cmMakefile: make some methods take const std::string& instead of const char* · c768e398
      Rolf Eike Beer authored and Brad King's avatar Brad King committed
      Most callers already have a std::string, on which they called c_str() to pass it
      into these methods, which internally converted it back to std::string. Pass a
      std::string directly to these methods now, avoiding all these conversions.
      Those methods that only pass in a const char* will get the conversion to
      std::string now only once.
  10. 12 Jan, 2014 1 commit
  11. 11 Dec, 2013 1 commit
  12. 10 Dec, 2013 1 commit
    • Stephen Kelly's avatar
      Remove INTERFACE build targets. · 97fae68b
      Stephen Kelly authored
      Commit b04f3b9a (Create make rules for INTERFACE_LIBRARY
      targets., 2013-08-21) extended the makefile generator to create
      build targets for INTERFACE_LIBRARY targets. No other generators
      were extended with this feature.
      This conflicts with the feature of whitelisting of target properties
      read from INTERFACE_LIBRARY targets. The INTERFACE_* properties
      of the INTERFACE_LIBRARY may legitimately contain TARGET_PROPERTY
      generator expressions for reading properties from the 'head target'.
      The 'head target' would be the INTERFACE_LIBRARY itself when creating
      the build rules for it, which means that non-whitelisted properties
      would be read.
  13. 25 Nov, 2013 1 commit
    • Stephen Kelly's avatar
      INTERFACE_LIBRARY: Avoid codepaths which set unneeded properties. · 0bfcb450
      Stephen Kelly authored
      As an INTERFACE_LIBRARY has no direct link dependencies, we can
      short-circuit in cmGeneratorExpressionEvaluator and
      in cmGlobalGenerator::CheckLocalGenerators.
      As they do not generate any output directly, any generate- or install-
      related code acn also be short-circuited. Many of the local generators
      already do this.
      Because only INTERFACE related properties make sense on INTERFACE_LIBRARY
      targets, avoid setting other properties, for example via defaults.
  14. 21 Oct, 2013 1 commit
    • Stephen Kelly's avatar
      Create make rules for INTERFACE_LIBRARY targets. · b04f3b9a
      Stephen Kelly authored and Brad King's avatar Brad King committed
      The result is that the depends of the target are created.
       add_library(somelib foo.cpp)
       add_library(anotherlib EXCLUDE_FROM_ALL foo.cpp)
       add_library(extra EXCLUDE_FROM_ALL foo.cpp)
       target_link_libraries(anotherlib extra)
       add_library(iface INTERFACE)
       target_link_libraries(iface INTERFACE anotherlib)
      Executing 'make iface' will result in the anotherlib and extra targets
      being made.
      Adding a regular executable to the INTERFACE of an INTERFACE_LIBRARY
      will not result in the executable being built with 'make iface' because
      of the logic in cmComputeTargetDepends::AddTargetDepend.
      So far, this is implemented only for the Makefile generator. Other
      generators will follow if this feature is possible for them.
      Make INTERFACE_LIBRARY targets part of the all target by default.
      Test this by building the all target and making the expected library
  15. 02 Jul, 2013 1 commit
  16. 08 Jan, 2013 2 commits
    • Stephen Kelly's avatar
      Add LINK_LIBRARIES property for direct target link dependencies · 76538627
      Stephen Kelly authored and Brad King's avatar Brad King committed
      Previously we kept direct link dependencies in OriginalLinkLibraries.
      The property exposes the information in the CMake language through the
      get/set_property commands.  We preserve the OriginalLinkLibraries value
      internally to support old APIs like that for CMP0003's OLD behavior, but
      the property is now authoritative.  This follows up from commit d5cf644a
      (Split link information processing into two steps, 2012-11-01).
      This will be used later to populate the link interface properties when
      exporting targets, and will later allow use of generator expressions
      when linking to libraries with target_link_libraries.
      Also make targets depend on the (config-specific) union of dependencies.
      CMake now allows linking to dependencies or not depending on the config.
      However, generated build systems are not all capable of processing
      config-specific dependencies, so the targets depend on the union of
      dependencies for all configs.
    • Stephen Kelly's avatar
      Make linking APIs aware of 'head' target · 40cf3fb9
      Stephen Kelly authored and Brad King's avatar Brad King committed
      The 'head' is the dependent target to be linked with the current target.
      It will be used to evaluate generator expressions with proper handling
      of mapped configurations and is used as the source target of properties.
      This requires that memoization is done with a key of a pair of target
      and config, instead of just config, because now the result also depends
      on the target.  Removing the memoization entirely is not an option
      because it slows cmake down considerably.
  17. 03 Jan, 2013 1 commit
  18. 29 Feb, 2012 1 commit
  19. 02 Oct, 2011 1 commit
    • Nicolas Despres's avatar
      Refactor TargetTypeNames. · 3db2973b
      Nicolas Despres authored
      Make it a static method instead of an array. It is safer for the
      type checking and if we add a new target type we will be warned to add
      a case to the switch.
  20. 04 Aug, 2011 1 commit
  21. 19 Nov, 2010 1 commit
    • Brad King's avatar
      Allow add_dependencies() on imported targets (#10395) · e01cce28
      Brad King authored
      Imported targets do not themselves build, but we can follow dependencies
      through them to find real targets.  This allows imported targets to
      depend on custom targets that provide the underlying files at build
  22. 18 Nov, 2010 1 commit
  23. 25 Aug, 2010 3 commits
  24. 01 Oct, 2009 1 commit
  25. 28 Sep, 2009 1 commit
    • Brad King's avatar
      Convert CMake to OSI-approved BSD License · 96afb120
      Brad King authored
      This converts the CMake license to a pure 3-clause OSI-approved BSD
      License.  We drop the previous license clause requiring modified
      versions to be plainly marked.  We also update the CMake copyright to
      cover the full development time range.
  26. 24 Aug, 2009 1 commit
  27. 06 Aug, 2008 2 commits
    • Brad King's avatar
      BUG: Avoid bogus dependency on executable targets · d76b20bf
      Brad King authored
      When an executable target within the project is named in
      target_link_libraries for another target, but the executable does not
      have the ENABLE_EXPORTS property set, then the executable cannot really
      be linked.  This is probably a case where the user intends to link to a
      third-party library that happens to have the same name as an executable
      target in the project (or else will get an error at build time).  We
      need to avoid making the other target depend on the executable target
      incorrectly, since the executable may actually want to link to that
      target and this is not a circular depenency.
    • Brad King's avatar
      ENH: Improve readability of circular depends error · 37a009b7
      Brad King authored
      When reporting the dependencies in a strongly connected component quote
      the target names to make the message more readable no matter the target
  28. 07 Feb, 2008 1 commit
    • Brad King's avatar
      ENH: Improve link line generation for static library cycles. · 4987e17f
      Brad King authored
        - Move Tarjan algorithm from cmComputeTargetDepends
          into its own class cmComputeComponentGraph
        - Use cmComputeComponentGraph to identify the component DAG
          of link dependencies in cmComputeLinkDepends
        - Emit non-trivial component members more than once but always
          in a contiguous group on the link line
  29. 05 Feb, 2008 1 commit
    • Brad King's avatar
      ENH: Analyze inter-target dependencies to safely fix cycles · 523ddeda
      Brad King authored
        - Cycles may be formed among static libraries
        - Native build system should not have cycles in target deps
        - Create cmComputeTargetDepends to analyze dependencies
        - Identify conneced components and use them to fix deps
        - Diagnose cycles containing non-STATIC targets
        - Add debug mode property GLOBAL_DEPENDS_DEBUG_MODE
        - Use results in cmGlobalGenerator as target direct depends