Merge topic 'commitid-into-string'

06c83ba8 rust: prefer Into<String> over ToString
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !72

CHANGELOG.md

@@ -11,6 +11,7 @@
   * `error-chain` is no longer used. Instead, custom error types are used. This
     means that errors from this crate no longer allocate (except where a
     `String` needs to be stored for messaging purposes).
+  * `Into<String>` is used for `CommitId` and `Identity` construction methods.
 
 # v3.1.2
 

src/git.rs

@@ -128,8 +128,8 @@ pub(crate) type GitResult<T> = Result<T, GitError>;
 
 impl CommitId {
     /// Create a new `CommitId`.
-    pub fn new<I: ToString>(id: I) -> Self {
-        CommitId(id.to_string())
+    pub fn new<I: Into<String>>(id: I) -> Self {
+        CommitId(id.into())
     }
 
     /// The commit as a string reference.
@@ -166,12 +166,12 @@ impl Identity {
     /// Create a new identity.
     pub fn new<N, E>(name: N, email: E) -> Self
     where
-        N: ToString,
-        E: ToString,
+        N: Into<String>,
+        E: Into<String>,
     {
         Self {
-            name: name.to_string(),
-            email: email.to_string(),
+            name: name.into(),
+            email: email.into(),
         }
     }
 }