Imported targets bring flags with them automatically.

Utkarsh Ayachit authored Nov 17, 2017 and Kitware Robot committed Nov 17, 2017

6434f092

 Add ability to add custom library prefix/suffix.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !12

Since QtTesting is often part of other projects, we add mechanism to
allow those projects to add prefix/suffix to the QtTesting library.

Utkarsh Ayachit authored Sep 07, 2017 and Kitware Robot committed Sep 07, 2017

25869ff1 clang-format: fix code formatting
6aa39647 Add gitattributes.
1da4e67d

 Add clang-format file (same as ParaView).
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !11

This run of `clang-format` cleanups indentation and spacing to match
ParaView style.

Ben Boeckel authored Aug 30, 2017 and Kitware Robot committed Aug 30, 2017

bd8c472e

 clang-tidy: fix override issues
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !9

Utkarsh Ayachit authored Aug 30, 2017 and Kitware Robot committed Aug 30, 2017

20f23d30

 Fixes issues when test playback fails to find an object.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !10

Fixes multiple issues when test playback failed to find an object.
1. The failure message was printed out twice. Fixed that. Only 1 call to
   `qCritical()` is sufficient.
2. `qCritical() << QString()` causes the '\n's to be escaped. Avoid
   that by converting QString to `char*`.
3. Don't report crazy long list of possible matches or available
   widgets. That's very useless and makes terminal (or output log)
   unreadable. Limit it to 20 matches.

This run of `clang-tidy` removes unnecessary `virtual` keywords and adds
`override` where necessary.

Utkarsh Ayachit authored Jun 26, 2017 and Kitware Robot committed Jun 26, 2017

fe6abd40

 Added ability to check a widget's size.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Shawn Waldon <shawn.waldon@kitware.com>
Merge-request: !8

Adding a new command to check a widget's size.

e.g.

  <pqevent object=".../MultiViewWidget1" command="size" arguments="640,400" />

Jean-Christophe Fillion-Robin authored May 09, 2017 and Kitware Robot committed May 09, 2017

46837aa3

 test: Fix pqEventRecorderTest
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !6

Jean-Christophe Fillion-Robin authored May 09, 2017 and Kitware Robot committed May 09, 2017

bcbe1708

 test: Fix pq(Double)SpinBoxEventTranslatorTest
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !5

Jean-Christophe Fillion-Robin authored May 09, 2017 and Kitware Robot committed May 09, 2017

70308a5c Fix -Woverloaded-virtual warning in custom event translator
8f3038e8

 Fix -Woverloaded-virtual warning in custom event player
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !7

This commit fixes warning like one reported below occuring when imlementing
custom event translators:


```
In file included from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLNodeComboBoxEventTranslator.h:28:0,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:84:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqWidgetEventTranslator.h:62:16: warning: ‘virtual bool pqWidgetEventTranslator::translateEvent(QObject*, QEvent*, int, bool&)’ was hidden [-Woverloaded-virtual]
   virtual bool translateEvent(QObject* object, QEvent* event, int eventType, bool& error);
                ^
In file included from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:84:0:
/home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLNodeComboBoxEventTranslator.h:43:16: warning:   by ‘virtual bool qMRMLNodeComboBoxEventTranslator::translateEvent(QObject*, QEvent*, bool&)’ [-Woverloaded-virtual]
   virtual bool translateEvent(QObject *Object, QEvent *Event, bool &Error);
                ^
```

This commit fixes warning like one reported below occuring when imlementing
custom event players:

```
In file included from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLCheckableNodeComboBoxEventPlayer.h:25:0,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:82:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqWidgetEventPlayer.h:60:16: warning: ‘virtual bool pqWidgetEventPlayer::playEvent(QObject*, const QString&, const QString&, bool&)’ was hidden [-Woverloaded-virtual]
   virtual bool playEvent(
                ^
In file included from /home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqTreeViewEventPlayer.h:35:0,
                 from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLTreeViewEventPlayer.h:25,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:85:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqAbstractItemViewEventPlayerBase.h:51:8: warning:   by ‘virtual bool pqAbstractItemViewEventPlayerBase::playEvent(QObject*, const QString&, const QString&, int, bool&)’ [-Woverloaded-virtual]
   bool playEvent(QObject* object, const QString& command,
        ^
```

This commit updates "pqDoubleSpinBoxEventTranslatorTest" and
"pqSpinBoxEventTranslatorTester" to account for changes introduced
in 61d84487 (Using isPrint() instead of isLetterOrNumber()).

The new behavior only record value numerical values associated with the
key event.

Ben Boeckel authored Feb 27, 2017 and Kitware Robot committed Feb 27, 2017

6be6b822

 cmake: don't set the minimum version if not the top-level
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Reviewed-by: Brad King <brad.king@kitware.com>
Merge-request: !4

See paraview#17161.

Mathieu Westphal authored Feb 10, 2017 and Kitware Robot committed Feb 10, 2017

e936b75c

 Add feature to record interaction timings
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Joachim Pouderoux <joachim.pouderoux@kitware.com>
Acked-by: Julien Finet <julien.finet@kitware.com>
Merge-request: !2

This add a new checkbox in the event recorder dialog
When checked, "pause" event will be recorded between
user interactions, allowing to record a test to be played
and understood at the same time be the user playing the test.

Qt5 fixes

See merge request !3

With Qt 5, on OsX all file dialog (and other modal dialog) tests would
fail. The problem was that the modal dialog's event loop would not quite
even after `QDialog::accept()` was called. This happened when
`QApplication::processEvents` was called by the testing framework when
processing a test item while the modal dialog was open. Skipping the
calling of `QApplication::processEvents` overcomes that issue.

Mathieu Westphal authored Jan 25, 2017 and Kitware Robot committed Jan 25, 2017

6ec9392d

 Enable use of continuous flush
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1

Continous flush options was available, however not accessible.
This commit add a checkbox to control this options,
Modify slughtly the signal api so it is standardized and actually use the signal
in the only provided observer.
When true, continuous flush ensure that events are written on file
as sson as they are recorded.

Cleanup to use imported targets.

Also updates CMake minimum version to 2.8.12.

Add guard for context menu in some view event players