cmake: use extensions on source properties

Avoids some slow paths in CMake and is more explicit anyways.

Change-Id: I875de45e323a786e32ad7406eb7ac295e3cfb7a6

Catalyst/Editions/Essentials/ParaViewCore/VTKExtensions/Default/Essentials.props.catalyst.cmake

 set_source_files_properties(
-  vtkAMRDualGridHelper
+  vtkAMRDualGridHelper.cxx
   WRAP_EXCLUDE
   )

Catalyst/Editions/Essentials/VTK/Filters/Core/Essentials.props.catalyst.cmake

 set_source_files_properties(
-  vtkContourHelper
+  vtkContourHelper.cxx
   WRAP_EXCLUDE
   )

Catalyst/Editions/Rendering-Base/ParaViewCore/ClientServerCore/Rendering/CMakeLists.txt

@@ -7,10 +7,10 @@ foreach (cmake_file IN LISTS cmake_files)
 endforeach ()
 
 set_source_files_properties(
-#  vtkPVContextView
-#  vtkPVDataRepresentation
-#  vtkPVSynchronizedRenderWindows
-  vtkPVView
+#  vtkPVContextView.cxx
+#  vtkPVDataRepresentation.cxx
+#  vtkPVSynchronizedRenderWindows.cxx
+  vtkPVView.cxx
   ABSTRACT)
 
 #set (${vtk-module}_HDRS vtkStreamingPriorityQueue.h)

Catalyst/Editions/Rendering-Base/ParaViewCore/VTKExtensions/Rendering/Rendering-Base-glsl.catalyst.cmake

@@ -13,5 +13,5 @@ foreach (file vtkIceTCompositeZPassShader_fs.glsl)
       VTKPVVTKEXTENSIONSRENDERING_EXPORT vtkPVVTKExtensionsRenderingModule.h
     )
   list(APPEND Module_SRCS ${res})
-  set_source_files_properties(${file_we} WRAP_EXCLUDE)
+  set_source_files_properties(${res} WRAP_EXCLUDE)
 endforeach()

CoProcessing/Catalyst/CMakeLists.txt

@@ -39,13 +39,13 @@ set (Module_SRCS
 )
 
 set_source_files_properties(
-  vtkCPAdaptorAPI
-  vtkCPPipeline
+  vtkCPAdaptorAPI.cxx
+  vtkCPPipeline.cxx
   ABSTRACT)
 
 set_source_files_properties(
-  CAdaptorAPI
-  vtkCPCxxHelper
+  CAdaptorAPI.cxx
+  vtkCPCxxHelper.cxx
   WRAP_EXCLUDE)
 
 set (${vtk-module}_HDRS CAdaptorAPI.h)

CoProcessing/PythonCatalyst/CMakeLists.txt

@@ -35,7 +35,7 @@ set (Module_SRCS
 )
 
 set_source_files_properties(
-  vtkCPPythonAdaptorAPI
+  vtkCPPythonAdaptorAPI.cxx
   ABSTRACT)
 
 configure_file(vtkCPPythonScriptPipelineConfig.h.in

CoProcessing/TestDriver/CMakeLists.txt

@@ -18,15 +18,15 @@ SET(TestDriver_SRCS
 )
 
 SET_SOURCE_FILES_PROPERTIES(
-  vtkCPBaseFieldBuilder
-  vtkCPBaseGridBuilder
-  vtkCPFieldBuilder
-  vtkCPFileGridBuilder
-  vtkCPGridBuilder
-  vtkCPScalarFieldFunction
-  vtkCPTensorFieldFunction
-  vtkCPUnstructuredGridBuilder
-  vtkCPVector3FieldFunction
+  vtkCPBaseFieldBuilder.cxx
+  vtkCPBaseGridBuilder.cxx
+  vtkCPFieldBuilder.cxx
+  vtkCPFileGridBuilder.cxx
+  vtkCPGridBuilder.cxx
+  vtkCPScalarFieldFunction.cxx
+  vtkCPTensorFieldFunction.cxx
+  vtkCPUnstructuredGridBuilder.cxx
+  vtkCPVector3FieldFunction.cxx
   ABSTRACT
 )
 

ParaViewCore/Animation/CMakeLists.txt

@@ -65,15 +65,11 @@ if (PARAVIEW_ENABLE_PYTHON)
     )
 endif()
 
-#set_source_files_properties(
-#  WRAP_EXCLUDE
-#)
-
 set_source_files_properties(
-  vtkAnimationPlayer
-  vtkPVAnimationCue
-  vtkPVCueManipulator
-  vtkPVKeyFrameAnimationCue
+  vtkAnimationPlayer.cxx
+  vtkPVAnimationCue.cxx
+  vtkPVCueManipulator.cxx
+  vtkPVKeyFrameAnimationCue.cxx
   vtkSMAnimationSceneWriter.cxx
   ABSTRACT
 )

ParaViewCore/ClientServerCore/Core/CMakeLists.txt

@@ -89,27 +89,27 @@ if (PARAVIEW_ENABLE_PYTHON)
 endif()
 
 set_source_files_properties(
-  vtkExtractsDeliveryHelper
-  vtkProcessModuleAutoMPI
-  vtkPVOptionsXMLParser
-  vtkPVPlugin
-  vtkPVPythonPluginInterface
-  vtkPVServerManagerPluginInterface
-  vtkPVServerOptions
+  vtkExtractsDeliveryHelper.cxx
+  vtkProcessModuleAutoMPI.cxx
+  vtkPVOptionsXMLParser.cxx
+  vtkPVPlugin.cxx
+  vtkPVPythonPluginInterface.cxx
+  vtkPVServerManagerPluginInterface.cxx
+  vtkPVServerOptions.cxx
 
   WRAP_EXCLUDE
   )
 
 set_source_files_properties(
-  vtkNetworkAccessManager
-  vtkPVDataInformationHelper
-  vtkPVInformation
-  vtkPVPlugin
-  vtkPVPluginTracker
-  vtkPVPythonPluginInterface
-  vtkPVServerManagerPluginInterface
-  vtkPVSession
-  vtkSession
+  vtkNetworkAccessManager.cxx
+  vtkPVDataInformationHelper.cxx
+  vtkPVInformation.cxx
+  vtkPVPlugin.cxx
+  vtkPVPluginTracker.cxx
+  vtkPVPythonPluginInterface.cxx
+  vtkPVServerManagerPluginInterface.cxx
+  vtkPVSession.cxx
+  vtkSession.cxx
   ABSTRACT)
 
 # Use a custom hints file for this module.

ParaViewCore/ClientServerCore/Default/CMakeLists.txt

@@ -44,10 +44,6 @@ if (PARAVIEW_ENABLE_PYTHON)
     )
 endif()
 
-set_source_files_properties(
-  vtkNetworkAccessManager
-  ABSTRACT)
-
 vtk_module_library(vtkPVClientServerCoreDefault ${Module_SRCS})
 
 # for vtkPVFileInformation

ParaViewCore/ClientServerCore/Rendering/CMakeLists.txt

@@ -110,19 +110,19 @@ if (PARAVIEW_USE_ICE_T)
 endif()
 
 set_source_files_properties(
-  vtkCacheSizeKeeper
+  vtkCacheSizeKeeper.cxx
 
   # No need to wrap vtkPExtentTranslator, its an internal class.
-  vtkPExtentTranslator
+  vtkPExtentTranslator.cxx
   WRAP_EXCLUDE
 )
 
 set_source_files_properties(
-  vtkCacheSizeKeeper
-  vtkPVContextView
-  vtkPVDataRepresentation
-  vtkPVSynchronizedRenderWindows
-  vtkPVView
+  vtkCacheSizeKeeper.cxx
+  vtkPVContextView.cxx
+  vtkPVDataRepresentation.cxx
+  vtkPVSynchronizedRenderWindows.cxx
+  vtkPVView.cxx
   ABSTRACT)
 
 set (${vtk-module}_HDRS vtkStreamingPriorityQueue.h)

ParaViewCore/Common/CMakeLists.txt

@@ -47,11 +47,11 @@ set(Module_SRCS
 )
 
 set_source_files_properties(
-  vtkClientServerInterpreterInitializer
+  vtkClientServerInterpreterInitializer.cxx
   WRAP_EXCLUDE)
 
 set_source_files_properties(
-  vtkClientServerInterpreterInitializer
+  vtkClientServerInterpreterInitializer.cxx
   ABSTRACT)
 
 vtk_module_library(vtkPVCommon ${Module_SRCS})

ParaViewCore/ServerImplementation/Core/CMakeLists.txt

@@ -63,7 +63,7 @@ set (Module_SRCS
 )
 
 set_source_files_properties(
-  vtkSMMessage
+  vtkSMMessage.cxx
   WRAP_EXCLUDE)
 
 set_source_files_properties(

ParaViewCore/ServerManager/Core/CMakeLists.txt

@@ -129,25 +129,25 @@ set (Module_SRCS
 )
 
 SET_SOURCE_FILES_PROPERTIES(
-  vtkSMDeserializer
-  vtkSMDomain
-  vtkSMLink
-  vtkSMPropertyHelper
-  vtkSMProxyManager  # since New() is protected.
-  vtkSMRangeDomainTemplate
-  vtkSMRemoteObject
-  vtkSMSession
-  vtkSMSessionProxyManager # since New() is non-standard.
-  vtkSMUncheckedPropertyHelper
-  vtkSMUndoElement
-  vtkSMVectorProperty
+  vtkSMDeserializer.cxx
+  vtkSMDomain.cxx
+  vtkSMLink.cxx
+  vtkSMPropertyHelper.cxx
+  vtkSMProxyManager.cxx  # since New() is protected.
+  vtkSMRangeDomainTemplate.txx
+  vtkSMRemoteObject.cxx
+  vtkSMSession.cxx
+  vtkSMSessionProxyManager.cxx # since New() is non-standard.
+  vtkSMUncheckedPropertyHelper.cxx
+  vtkSMUndoElement.cxx
+  vtkSMVectorProperty.cxx
   ABSTRACT
   )
 
 SET_SOURCE_FILES_PROPERTIES(
-  vtkSMPropertyHelper
-  vtkSMRangeDomainTemplate
-  vtkSMUncheckedPropertyHelper
+  vtkSMPropertyHelper.cxx
+  vtkSMRangeDomainTemplate.txx
+  vtkSMUncheckedPropertyHelper.cxx
   WRAP_EXCLUDE)
 
 vtk_module_library(vtkPVServerManagerCore ${Module_SRCS})

ParaViewCore/ServerManager/Rendering/CMakeLists.txt

@@ -77,7 +77,7 @@ list(APPEND Module_SRCS
   vtkSMParaViewPipelineControllerWithRendering.cxx
   ${CMAKE_CURRENT_BINARY_DIR}/${vtk-module}ObjectFactory.cxx)
 
-set_source_files_properties(${vtk-module}ObjectFactory WRAP_EXCLUDE)
+set_source_files_properties(${vtk-module}ObjectFactory.cxx WRAP_EXCLUDE)
 
 # Override some rendering classes. Create object factory:
 set(vtk_module_overrides "vtkSMParaViewPipelineController")

ParaViewCore/ServerManager/SMApplication/CMakeLists.txt

@@ -33,7 +33,7 @@ set (Module_SRCS
 )
 
 SET_SOURCE_FILES_PROPERTIES(
-  vtkInitializationHelper
+  vtkInitializationHelper.cxx
   ABSTRACT
   )
 

ParaViewCore/VTKExtensions/Core/CMakeLists.txt

@@ -46,15 +46,15 @@ set(Module_SRCS
 )
 
 set_source_files_properties(
-  vtkCommunicationErrorCatcher
-  vtkMultiProcessControllerHelper
-  vtkPVInformationKeys
+  vtkCommunicationErrorCatcher.cxx
+  vtkMultiProcessControllerHelper.cxx
+  vtkPVInformationKeys.cxx
   WRAP_EXCLUDE
   )
 
 set_source_files_properties(
-  vtkCommunicationErrorCatcher
-  vtkUndoElement
+  vtkCommunicationErrorCatcher.cxx
+  vtkUndoElement.cxx
   ABSTRACT)
 
 vtk_module_library(vtkPVVTKExtensionsCore ${Module_SRCS})

ParaViewCore/VTKExtensions/Default/CMakeLists.txt

@@ -149,32 +149,32 @@ set(Module_SRCS
 )
 
 set_source_files_properties(
-  vtkAMRDualGridHelper
-  vtkMaterialInterfaceCommBuffer
-  vtkMaterialInterfaceIdList
-  vtkMaterialInterfacePieceLoading
-  vtkMaterialInterfacePieceTransaction
-  vtkMaterialInterfacePieceTransactionMatrix
-  vtkMaterialInterfaceProcessLoading
-  vtkMaterialInterfaceProcessRing
-  vtkMaterialInterfaceToProcMap
-  vtkPVPlotTime
-  vtkSpyPlotBlock
-  vtkSpyPlotBlockIterator
-  vtkSpyPlotIStream
-  vtkSpyPlotReaderMap
-  vtkSpyPlotUniReader
+  vtkAMRDualGridHelper.cxx
+  vtkMaterialInterfaceCommBuffer.cxx
+  vtkMaterialInterfaceIdList.cxx
+  vtkMaterialInterfacePieceLoading.cxx
+  vtkMaterialInterfacePieceTransaction.cxx
+  vtkMaterialInterfacePieceTransactionMatrix.cxx
+  vtkMaterialInterfaceProcessLoading.cxx
+  vtkMaterialInterfaceProcessRing.cxx
+  vtkMaterialInterfaceToProcMap.cxx
+  vtkPVPlotTime.cxx
+  vtkSpyPlotBlock.cxx
+  vtkSpyPlotBlockIterator.cxx
+  vtkSpyPlotIStream.cxx
+  vtkSpyPlotReaderMap.cxx
+  vtkSpyPlotUniReader.cxx
   WRAP_EXCLUDE
   )
 
 set_source_files_properties(
-  vtkCellIntegrator
-  vtkPEnSightReader
-  vtkSciVizStatistics
-  vtkTransferFunctionEditorRepresentation
-  vtkTransferFunctionEditorRepresentation1D
-  vtkTransferFunctionEditorWidget
-  vtkTransferFunctionEditorWidget1D
+  vtkCellIntegrator.cxx
+  vtkPEnSightReader.cxx
+  vtkSciVizStatistics.cxx
+  vtkTransferFunctionEditorRepresentation.cxx
+  vtkTransferFunctionEditorRepresentation1D.cxx
+  vtkTransferFunctionEditorWidget.cxx
+  vtkTransferFunctionEditorWidget1D.cxx
   ABSTRACT)
 
 # Use a custom hints file for this module.

ParaViewCore/VTKExtensions/Rendering/CMakeLists.txt

@@ -103,9 +103,6 @@ if (PARAVIEW_USE_MPI)
   endif()
 endif()
 
-#set_source_files_properties(
-#  WRAP_EXCLUDE
-#  )
 if (PARAVIEW_QT_VERSION VERSION_GREATER "4")
   include_directories(${Qt5Core_INCLUDE_DIRS})
 else ()
@@ -113,10 +110,10 @@ else ()
 endif ()
 
 set_source_files_properties(
-  vtkCameraManipulatorGUIHelper
-  vtkImageCompressor
-  vtkPVJoystickFly
-  vtkPVRenderViewProxy
+  vtkCameraManipulatorGUIHelper.cxx
+  vtkImageCompressor.cxx
+  vtkPVJoystickFly.cxx
+  vtkPVRenderViewProxy.cxx
   ABSTRACT)
 
 #---------------------------------------------------------
@@ -135,7 +132,7 @@ foreach (file vtkIceTCompositeZPassShader_fs.glsl)
       VTKPVVTKEXTENSIONSRENDERING_EXPORT vtkPVVTKExtensionsRenderingModule.h
     )
   list(APPEND Module_SRCS ${res})
-  set_source_files_properties(${file_we} WRAP_EXCLUDE)
+  set_source_files_properties(${res} WRAP_EXCLUDE)
 endforeach()
 #---------------------------------------------------------