1. 29 Apr, 2020 1 commit
  2. 22 Apr, 2020 1 commit
    • Hans Johnson's avatar
      STYLE: Prefer = default to explicitly trivial implementations · f118a65a
      Hans Johnson authored
      This check replaces default bodies of special member functions with
      = default;. The explicitly defaulted function declarations enable more
      opportunities in optimization, because the compiler might treat
      explicitly defaulted functions as trivial.
      
      Additionally, the C++11 use of = default more clearly expreses the
      intent for the special member functions.
      f118a65a
  3. 19 Nov, 2019 1 commit
  4. 18 Nov, 2019 3 commits
    • Kitware Robot's avatar
      clang-format: reformat using clang-format-8 · ac76fe16
      Kitware Robot authored
      Run the `clang-format.bash` script to update all our C and C++ code to a
      new style defined by `.clang-format`.  Use `clang-format` version 8.0.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      ac76fe16
    • Kitware Robot's avatar
      clang-format: prepare data arrays for formatting · cf111cf6
      Kitware Robot authored
      clang-format tends to either put each element on its own line or smash
      them together into a few lines. There's a little bit more structure
      that's important in these arrays, so preserve that through clang-format
      as well.
      cf111cf6
    • Kitware Robot's avatar
      clang-format: add semicolons to macro calls · d9968f38
      Kitware Robot authored
      clang-format takes the lack of a semicolon as if it were an attribute or
      some other "chainable" call leading to bogus indentation. By using
      semicolons on all macro calls, the formatting comes out the way it
      should.
      d9968f38
  5. 13 Nov, 2019 1 commit
  6. 12 Nov, 2019 1 commit
  7. 30 Aug, 2019 1 commit
  8. 23 May, 2019 1 commit
    • Andras Lasso's avatar
      Fix disappearing labels when anchor points are not in world · 64e866bb
      Andras Lasso authored
      vtkLabelPlacementMapper and vtkLabelPlacer incorrectly assumed at a couple of places that anchor point is specified in world coordinate system. This caused incorrect frustum clipping (randomly disappearing labels) when anchor point coordinates were specified in another coordinate system (for example: labelPlacementMapper->GetAnchorTransform()->SetCoordinateSystemToNormalizedViewport()).
      
      There was also a small (probably copy-paste) bug in the culling bounds computation.
      64e866bb
  9. 08 Jan, 2019 3 commits
  10. 07 Dec, 2018 1 commit
    • David E. DeMarle's avatar
      fix a crash when rebuilding labelhierarchy · 4722480b
      David E. DeMarle authored
      CoincidentPoints has to be rebuilt whenever the input points
      change or we can walk off the points array and crash. The points
      always change before ComputeHierarchy(), so we can't reuse and
      thus always need to start with a fresh CoincidentPoints.
      
      Thanks DB for finding this.
      4722480b
  11. 25 Oct, 2018 1 commit
  12. 22 Jun, 2018 1 commit
  13. 17 Jun, 2018 1 commit
  14. 25 May, 2018 1 commit
  15. 18 May, 2018 1 commit
    • Kitware Robot's avatar
      ExternalData: Convert content links from MD5 to SHA512 · d6d05b2a
      Kitware Robot authored
      Populate a script with `map_<md5>=<sha512>` variable settings and
      then run the following to convert the content link files:
      
          git ls-files -- '*.md5' | while read f; do
            md5="$(cat "$f")"
            sha512="$(eval echo \${map_$md5})"
            rm "$f"
            echo $sha512 > ${f%.md5}.sha512
          done
      d6d05b2a
  16. 21 Mar, 2018 1 commit
    • Sean McBride's avatar
      Applied clang-tidy modernize-use-equals-default fixes · 84ec1d57
      Sean McBride authored
      This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.
      
      There are now some duplicate semis because it did changes like:
      
        ~AMRIndexIterator() override{};
      to
        ~AMRIndexIterator() override= default;;
      
      Note there was a pointless semi before, which clang-tidy didn’t expect / account for.
      
      My next commit will remove them.
      84ec1d57
  17. 09 Mar, 2018 1 commit
  18. 25 Jan, 2018 1 commit
    • Sean McBride's avatar
      Updates for new cppcheck 1.82 · 5a55f3a6
      Sean McBride authored
      - fixed one warning about division by 0 from public API:
      
      Rendering/Label/vtkLabeledTreeMapDataMapper.cxx:656: style: Public interface of vtkLabeledTreeMapDataMapper is not safe. When calling vtkLabeledTreeMapDataMapper::SetFontSizeRange(), if parameter delta is 0 that leads to division by zero.
      
      - removed suppressions for false positives that are now fixed
      - added suppressions for new false positives
      5a55f3a6
  19. 20 Dec, 2017 1 commit
  20. 05 Dec, 2017 2 commits
  21. 20 Nov, 2017 1 commit
  22. 15 Nov, 2017 1 commit
  23. 04 Oct, 2017 2 commits
    • Ken Martin's avatar
      manually convert more NULL to nullptr · de3c93a3
      Ken Martin authored
      This topic catches another batch of NULL conversions that
      clang did not handle for various reasons. It also includes
      a number of changes to comments and strings where NULL was
      used. It also catches some recent code changes where NULL
      was used instead of nullptr.
      de3c93a3
    • Kitware Robot's avatar
      Replace VTK_DELETE_FUNCTION with =delete. · 1ac2c008
      Kitware Robot authored
      Now that VTK requires a C++11 compiler we can ditch using custom typedefs to
      wrap =delete;
      1ac2c008
  24. 02 Oct, 2017 2 commits
  25. 29 Sep, 2017 1 commit
    • Andrew Bauer's avatar
      Improvements for vtkNew for stl containers and comparison operations · fd04b442
      Andrew Bauer authored
      Adding in functionality to allow inserting vtkNew objects into
      stl containers of vtkSmartPointer objects as well as comparisons
      between vtkNew objects and raw pointers. Also removing Get() and
      GetPointer() calls from vtkNew objects since in most instances we
      can just pass in the vtkNew<> object instead of having to use the
      Get() or GetPointer() methods to get the raw pointer.
      fd04b442
  26. 26 Jul, 2017 1 commit
    • Kitware Robot's avatar
      Replace many NULL and 0 occurances with nullptr · a855cab0
      Kitware Robot authored
      This topic is the result of running clang-tidy to
      modernize our usage of NULL and 0 to nullptr. It also
      includes some manual and semi manual changes where
      clang-tidy would not be expected to work (such as in
      comments, or classes not compiled on this build)
      
      There are definitely many comments and occurances that
      this topic misses that we will need to fix over time.
      a855cab0
  27. 10 Jul, 2017 1 commit
    • David E. DeMarle's avatar
      Make LabelDataMapper respect clipping planes · f5334a5e
      David E. DeMarle authored
      Promote the convenience function getter to the parent class where
      the clipping planes actually live.
      
      Implement the clipping function in the CPU side of the labelmapper.
      Note, passing the clipplanes down to the internal mappers will not
      work (easily) because inside them the clipping space is in screen
      coordinates not world space.
      
      Add a test.
      f5334a5e
  28. 02 Jun, 2017 1 commit
    • Sean McBride's avatar
      Converted the last remaining sprintf to snprintf · 5c238b17
      Sean McBride authored
      These changes are more invasive than my previous conversions.
      a) Some private/protected method signatures now take a size parameter.
      b) Deleted vtkMPEG2Writer entirely, because 1) it uses sprintf and I can’t find the size of the buffer, I think it’s been removed. 2) The class hasn’t been built in years.
      c) some new defines introduced to avoid copy-pasting magic numbers.
      
      The only remaining sprintf, I think, are in third party or C code.
      5c238b17
  29. 30 May, 2017 1 commit
  30. 27 Apr, 2017 1 commit
  31. 08 Apr, 2017 2 commits
  32. 15 Mar, 2017 1 commit