d068829e BUG: Fix crash in vtkImageHistogram if input contains NaN
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6846

vtkImageHistogram caused application crash when input image contained NaN value
using Intel TBB backend, Visual Studio 2017, x64.

The problem was that when the image contained a NaN value then the computed scalar range was set to (Nan, Nan),
which later got converted to invalid bin min/max indexes. The safety check that should have forced
the indices to the valid range did not work, as it relied on comparison with a NaN value.

Fixed computation of scalar range (similar to how it is done here:
vtk/vtk@06d553fb), by changing
the order of operands in the ternary operator.

To make sure that similar error do not cause crash in the future, added a NaN-value check in the bin range computation, too.

Added test case to verify that the results are correct and the application does not crash anymore if input image contains NaN.

4f45930b Test C++11's elimination for the need of a space in closing template arg list
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6854

The clang_format option "Cpp11" was recently committed, which wants to reformat closing template argument lists as >> instead of > >.

This single adoption of this is to make sure all nightly dashboards accept it.

346d3d72 Merge branch 'release-rendering-review-release' into release-rendering-review
7789697d Fixed #17832: Observe NSView frame changes even for NSViews VTK didn't create
4a0b3b0a Fixed CAOpenGLLayer example being rendered as solid red
36350987 Create the NSOpenGLPixelFormat and NSOpenGLContext before the NSView/NSWindow
a12cdb6a Hoisted some duplicated code into a helper method
75a4aa97 Review of vtkCocoaRenderWindow SetSize and SetPosition
bf4a12a5 Added method separator comment lines in some files that missed some
3b14eb34 Fixed/improved a few incorrect comments
...
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Seun Odutola <seun@rogue-research.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6788

7789697d Fixed #17832: Observe NSView frame changes even for NSViews VTK didn't create
4a0b3b0a Fixed CAOpenGLLayer example being rendered as solid red
36350987 Create the NSOpenGLPixelFormat and NSOpenGLContext before the NSView/NSWindow
a12cdb6a Hoisted some duplicated code into a helper method
75a4aa97 Review of vtkCocoaRenderWindow SetSize and SetPosition
bf4a12a5 Added method separator comment lines in some files that missed some
3b14eb34 Fixed/improved a few incorrect comments
71a3fa44 Cleanup SetSize and SetPosition methods
...
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Seun Odutola <seun@rogue-research.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6788

0f0720ab Update to cpp11 for clang
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6848

cpp03 doesn't handle multiline string literals
while cpp11 does.

6baf8b35 PERF: readability container size empty
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Sean McBride <sean@rogue-research.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Acked-by: Hans Johnson <hans.j.johnson@gmail.com>
Merge-request: !6782

35d16f9a setup.py.in: add topics
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6844

35d16f9a setup.py.in: add topics
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6844

7705ef95 README.md: fix typo
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6843

7705ef95 README.md: fix typo
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6843

6478eacf DOC: Fix link to contributing instructions in python wheel long description
38ba5a09 DOC: Fix reference-style links in README.md to properly render on pypi
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: T.J. Corona <tj.corona@kitware.com>
Reviewed-by: T.J. Corona <tj.corona@kitware.com>
Merge-request: !6842

6478eacf DOC: Fix link to contributing instructions in python wheel long description
38ba5a09 DOC: Fix reference-style links in README.md to properly render on pypi
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: T.J. Corona <tj.corona@kitware.com>
Reviewed-by: T.J. Corona <tj.corona@kitware.com>
Merge-request: !6842

82f62d3f Added filter to smooth and/or pack points.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: T.J. Corona <tj.corona@kitware.com>
Merge-request: !6834

adbab991 Fix and test triangulate for penta and hexa prism cells
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6838

This filter adjusts point positions based on equalizing forces
between the points. The forces can be further modified by scalar
or tensor values.

As documented in the specification, reference links should be specified.
See https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links

7fe57281 setup.py.in: fixes for pypi
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Merge-request: !6841

7fe57281 setup.py.in: fixes for pypi
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Merge-request: !6841

53b3a4d9 Remove useless code
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Charles Gueunet <charles.gueunet@kitware.com>
Merge-request: !6837

(cherry picked from commit 0fa0b892)

0fa0b892 Fix and test triangulate for penta and hexa prism cells
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: T.J. Corona <tj.corona@kitware.com>
Merge-request: !6836

Usually VTK creates its own NSViews, and in that case we were already observing NSViewFrameDidChangeNotification and reacting appropriately.

But VTK can also be used in a different way, were clients create their own NSViews and point VTK to them. The SimpleCocoaVTK example does this.  In this case, VTK was not observing for NSVIew frame changes. That was ok unitl b75bc715.  But now that VTK creates its own framebuffer, it really needs to know when the NSView frame changes size.  So now we observe frame changes even for NSViews we didn't create.  In response, GetSize/SetSize will be invoked and do some necessary work. They will not however change the size of the NSView/NSWindow becuase a new 'if' contition limits that to happening only for NSViews created by VTK.

The SimpleCocoaVTK example project has two kinds of NSViews, one being based on CAOpenGLLayer. That one has been broken in master for some time now, rendering as solid red. Fixed by invoking InitializeFromCurrentContext(). Bypassed vtkCocoaRenderWindow's implementation though because it mutates the NSView and NSWindow ivars, which is undesirable in this case. Instead, invoke super's implementation.

The motivation here is that if we switch to NSOpenGLView, we'll need the NSOpenGLPixelFormat to construct it. Seems to make no difference creating it before or after currently.

Also moved the code that sets the NSWindow title higher up where the NSWindow is created.