From 57ac67588a3e7a755638c33ad70704455db17b52 Mon Sep 17 00:00:00 2001 From: Kenneth Moreland <morelandkd@ornl.gov> Date: Wed, 8 Jan 2025 17:43:14 -0500 Subject: [PATCH] Fix issue with Fides initializing HIP before using There was an issue with Fides crashing because it attempted to allocate memory with HIP before HIP was initialized. (See https://gitlab.kitware.com/vtk/fides/-/issues/26.) The problem was actually with VTK-m. (Initializing VTK-m is supposed to be optional, but HIP was not getting initialized in time if it was not.) To fix the Fides issue, update VTK-m to the changes provided by https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3289. --- Documentation/release/dev/fides-init.md | 9 +++++++++ ThirdParty/vtkm/vtkvtkm/vtk-m | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 Documentation/release/dev/fides-init.md diff --git a/Documentation/release/dev/fides-init.md b/Documentation/release/dev/fides-init.md new file mode 100644 index 00000000000..949f741cfd0 --- /dev/null +++ b/Documentation/release/dev/fides-init.md @@ -0,0 +1,9 @@ +## Fix issue with Fides not initializing HIP before using it + +There was an issue with Fides crashing because it attempted to allocate memory +with HIP before HIP was initialized. (See +https://gitlab.kitware.com/vtk/fides/-/issues/26.) The problem was actually with +VTK-m. (Initializing VTK-m is supposed to be optional, but HIP was not getting +initialized in time if it was not.) To fix the Fides issue, VTK-m is updated to +the changes provided by +https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3289. diff --git a/ThirdParty/vtkm/vtkvtkm/vtk-m b/ThirdParty/vtkm/vtkvtkm/vtk-m index a2784a96fdd..025421a2dc4 160000 --- a/ThirdParty/vtkm/vtkvtkm/vtk-m +++ b/ThirdParty/vtkm/vtkvtkm/vtk-m @@ -1 +1 @@ -Subproject commit a2784a96fdd79b06670532f6c19ab113f7e29ba4 +Subproject commit 025421a2dc4c5ee983d1f87fe1328b7effc1e107 -- GitLab