GitLab

1df732cd Add changedocs for removing `ArrayTransfer`
90050b96 Remove `ArrayManagerExecution`
19685902 Delete the default implementation of `ArrayTransfer`
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !2347

This class was used indirectly by the old `ArrayHandle`, through
`ArrayHandleTransfer`, to move data to and from a device. This
functionality has been replaced in the new `ArrayHandle`s through the
`Buffer` class (which can be compiled into libraries rather than make
every translation unit compile their own template).

This commit removes `ArrayManagerExecution` and all the implementations
that the device adapters were required to make. None of this code was in
any use anymore.

`ArrayTransfer` is used with the old `ArrayHandle` style to move data
between host and device. The new version of `ArrayHandle` does not use
`ArrayTransfer` at all because this functionality is wrapped in `Buffer`
(where it can exist in a precompiled library).

Once all the old `ArrayHandle` classes are gone, this class will be
removed completely. Although all the remaining `ArrayHandle` classes
provide their own versions of `ArrayTransfer`, they still need the
prototype to be defined to specialize. Thus, the guts of the default
`ArrayTransfer` are removed and replaced with a compile error if you try
to compile it.

df1dd51f Convert ArrayHandleZip to new buffer-style array
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !2342

78aa463d Fix compile error when template parameter shadows superclass
905b5a02 Call PrepareForControl to get transform for undefined device
650e416c Convert ArrayHandleTransform to new buffer-style-array
76880dd8 Enable ExecutionObjectBase::PrepareForExecution for DeviceAdapterId
b0146b1e Fix issue with CreateBuffers function
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !2341

I'm too lazy to look up the C++ spec, but it seems like template
parameter names would shadow the same names from a superclass.
Apparently that is not the case for Visual Studio. The `Storage` for the
cast array inherits from the `Storage` of the transform array. The
latter declares a private type named `SourceStorage`, and that is being
used instead of the former's `SourceStorage` template parameter. You
then get an error for accessing a private member that you did not want
in the first place.

Fix the problem by changing the name of the template parameter.

7f61058b Use kokkos reduce functionality
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !2340

a10d7be0 Revert back from ResizeVector to Allocate but setting vtkm::CopyFlag::On
76dcacc0 Revert from Allocate to ResizeVector, but initialize with 0 instead of NO_SUCH_ELEMENT
774d8df3 Renamed ResizeIndexVector to ResizeVector and fixed bad resize call
94697e0e Fix unused variable warnings when logging is disabled
25bacf92 Removed return statement that is never reached
635510de Make device tracker named variable
58515c2e Use ScopedRuntimeDeviceTracker to enforce the device rather than setting it explicitly
bda234c6 Use CopySubRange to ensure arrays are not being shrunk
...
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !2279