From a0931e758e9773e13552e8a47d19b57d835b1c22 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timoth=C3=A9e=20Couble?= <timothee.couble@kitware.com>
Date: Thu, 14 Mar 2024 16:14:15 +0100
Subject: [PATCH] [refact] Use lidarview_add_interpreter_plugin

---
 CMakeLists.txt                                       |  4 +++-
 .../VelodyneLidarBasePacketInterpreter.xml           |  4 ++--
 .../VelodyneLidarLegacyPacketInterpreter.xml         |  4 ++--
 VelodynePacketInterpreters/VelodyneLidarReader.xml   |  4 ++--
 VelodynePacketInterpreters/VelodyneLidarStream.xml   |  4 ++--
 .../VelodynePosePacketInterpreter.xml                |  4 ++--
 .../VelodynePoseReader.xml                           |  6 +++---
 .../VelodynePoseStream.xml                           |  6 +++---
 VelodyneProxies.xml                                  | 12 +-----------
 9 files changed, 20 insertions(+), 28 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index bf4c417..b38a846 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,4 +1,6 @@
-paraview_add_plugin(VelodynePlugin
+include(LidarViewInterpreterPlugin)
+
+lidarview_add_interpreter_plugin(Velodyne
   REQUIRED_ON_CLIENT
   REQUIRED_ON_SERVER
   VERSION "2.0"
diff --git a/VelodynePacketInterpreters/VelodyneLidarBasePacketInterpreter.xml b/VelodynePacketInterpreters/VelodyneLidarBasePacketInterpreter.xml
index 03b8ac9..7487fd1 100644
--- a/VelodynePacketInterpreters/VelodyneLidarBasePacketInterpreter.xml
+++ b/VelodynePacketInterpreters/VelodyneLidarBasePacketInterpreter.xml
@@ -1,9 +1,9 @@
 <ServerManagerConfiguration>
-  <ProxyGroup name="internal_interpreter">
+  <ProxyGroup name="internal_velodyne">
     <Proxy name="BaseVelodynePacketInterpreter"
            class="vtkVelodyneBasePacketInterpreter"
            label="Velodyne Base Packet Interpreter"
-           base_proxygroup="internal_interpreter"
+           base_proxygroup="internal_velodyne"
            base_proxyname="CommonLidarPacketInterpreter">
 
       <StringVectorProperty name="CalibrationFileName"
diff --git a/VelodynePacketInterpreters/VelodyneLidarLegacyPacketInterpreter.xml b/VelodynePacketInterpreters/VelodyneLidarLegacyPacketInterpreter.xml
index c5435d2..bee7a61 100644
--- a/VelodynePacketInterpreters/VelodyneLidarLegacyPacketInterpreter.xml
+++ b/VelodynePacketInterpreters/VelodyneLidarLegacyPacketInterpreter.xml
@@ -1,9 +1,9 @@
 <ServerManagerConfiguration>
-  <ProxyGroup name="internal_interpreter">
+  <ProxyGroup name="internal_velodyne">
     <Proxy name="VelodyneLegacyPacketInterpreter"
            class="vtkVelodyneLegacyPacketInterpreter"
            label="Velodyne Packet Interpreter"
-           base_proxygroup="internal_interpreter"
+           base_proxygroup="internal_velodyne"
            base_proxyname="BaseVelodynePacketInterpreter">
 
       <IntVectorProperty name="LidarModel"
diff --git a/VelodynePacketInterpreters/VelodyneLidarReader.xml b/VelodynePacketInterpreters/VelodyneLidarReader.xml
index 9decd1f..9321fa4 100644
--- a/VelodynePacketInterpreters/VelodyneLidarReader.xml
+++ b/VelodynePacketInterpreters/VelodyneLidarReader.xml
@@ -3,7 +3,7 @@
     <LidarReaderProxy name="VelodyneLidarReader"
                       class="vtkLidarReader"
                       label="Velodyne LiDAR Reader"
-                      base_proxygroup="internal_interpreter"
+                      base_proxygroup="internal_velodyne"
                       base_proxyname="CommonLidarReader">
 
       <Documentation short_help="Read Velodyne LiDAR data files." long_help="Read Velodyne LiDAR .pcap files.">
@@ -22,7 +22,7 @@
 
       <SubProxy command="SetLidarInterpreter">
         <Proxy name="PacketInterpreter"
-               proxygroup="internal_interpreter"
+               proxygroup="internal_velodyne"
                proxyname="VelodyneLegacyPacketInterpreter" />
         <ExposedProperties>
           <PropertyGroup label="LiDAR Interpreter Options">
diff --git a/VelodynePacketInterpreters/VelodyneLidarStream.xml b/VelodynePacketInterpreters/VelodyneLidarStream.xml
index 4424a6d..569d02b 100644
--- a/VelodynePacketInterpreters/VelodyneLidarStream.xml
+++ b/VelodynePacketInterpreters/VelodyneLidarStream.xml
@@ -3,7 +3,7 @@
     <SourceProxy name="VelodyneLidarStream"
                  class="vtkLidarStream"
                  label="Velodyne LiDAR Stream"
-                 base_proxygroup="internal_interpreter"
+                 base_proxygroup="internal_velodyne"
                  base_proxyname="CommonLidarStream">
 
       <Documentation short_help="Velodyne LiDAR data stream." long_help="Velodyne LiDAR live source stream.">
@@ -12,7 +12,7 @@
 
       <SubProxy command="SetLidarInterpreter">
         <Proxy name="PacketInterpreter"
-               proxygroup="internal_interpreter"
+               proxygroup="internal_velodyne"
                proxyname="VelodyneLegacyPacketInterpreter" />
         <ExposedProperties>
           <PropertyGroup label="LiDAR Interpreter Options">
diff --git a/VelodynePosePacketInterpreters/VelodynePosePacketInterpreter.xml b/VelodynePosePacketInterpreters/VelodynePosePacketInterpreter.xml
index 9a4f5be..432a795 100644
--- a/VelodynePosePacketInterpreters/VelodynePosePacketInterpreter.xml
+++ b/VelodynePosePacketInterpreters/VelodynePosePacketInterpreter.xml
@@ -1,9 +1,9 @@
 <ServerManagerConfiguration>
-  <ProxyGroup name="internal_interpreter">
+  <ProxyGroup name="internal_velodyne">
     <Proxy name="VelodynePosePacketInterpreter"
            class="vtkVelodynePosePacketInterpreter"
            label="Lidar and Pose Velodyne Interpreter"
-           base_proxygroup="internal_interpreter"
+           base_proxygroup="internal_velodyne"
            base_proxyname="CommonPosePacketInterpreter">
 
       <IntVectorProperty name="PPSSynced"
diff --git a/VelodynePosePacketInterpreters/VelodynePoseReader.xml b/VelodynePosePacketInterpreters/VelodynePoseReader.xml
index 588e4c9..d3d8b58 100644
--- a/VelodynePosePacketInterpreters/VelodynePoseReader.xml
+++ b/VelodynePosePacketInterpreters/VelodynePoseReader.xml
@@ -3,7 +3,7 @@
     <LidarReaderProxy name="VelodyneLidarPoseReader"
                       class="vtkLidarPoseReader"
                       label="Velodyne LiDAR + GNSS Reader"
-                      base_proxygroup="internal_interpreter"
+                      base_proxygroup="internal_velodyne"
                       base_proxyname="CommonLidarPoseReader">
 
       <Documentation short_help="Read Velodyne LiDAR data files." long_help="Read Velodyne LiDAR .pcap files.">
@@ -32,7 +32,7 @@
 
       <SubProxy command="SetLidarInterpreter">
         <Proxy name="LidarPacketInterpreter"
-               proxygroup="internal_interpreter"
+               proxygroup="internal_velodyne"
                proxyname="VelodyneLegacyPacketInterpreter" />
         <ExposedProperties>
           <PropertyGroup label="LiDAR Interpreter Options">
@@ -66,7 +66,7 @@
 
       <SubProxy command="SetPoseInterpreter">
         <Proxy name="PosePacketInterpreter"
-               proxygroup="internal_interpreter"
+               proxygroup="internal_velodyne"
                proxyname="VelodynePosePacketInterpreter" />
         <ExposedProperties>
           <PropertyGroup label="GNSS / IMU Transform">
diff --git a/VelodynePosePacketInterpreters/VelodynePoseStream.xml b/VelodynePosePacketInterpreters/VelodynePoseStream.xml
index fb89c01..22d6828 100644
--- a/VelodynePosePacketInterpreters/VelodynePoseStream.xml
+++ b/VelodynePosePacketInterpreters/VelodynePoseStream.xml
@@ -3,7 +3,7 @@
     <SourceProxy name="VelodyneLidarPoseStream"
                  class="vtkLidarPoseStream"
                  label="Velodyne LiDAR + GNSS Stream"
-                 base_proxygroup="internal_interpreter"
+                 base_proxygroup="internal_velodyne"
                  base_proxyname="CommonLidarPoseStream">
 
       <Documentation short_help="Velodyne LiDAR + GNSS stream." long_help="Velodyne LiDAR GNSS Pose live source stream.">
@@ -22,7 +22,7 @@
 
       <SubProxy command="SetLidarInterpreter">
         <Proxy name="LidarPacketInterpreter"
-               proxygroup="internal_interpreter"
+               proxygroup="internal_velodyne"
                proxyname="VelodyneLegacyPacketInterpreter" />
         <ExposedProperties>
           <PropertyGroup label="LiDAR Interpreter Options">
@@ -56,7 +56,7 @@
 
       <SubProxy command="SetPoseInterpreter">
         <Proxy name="PosePacketInterpreter"
-               proxygroup="internal_interpreter"
+               proxygroup="internal_velodyne"
                proxyname="VelodynePosePacketInterpreter" />
         <ExposedProperties>
           <PropertyGroup label="GNSS / IMU Transform">
diff --git a/VelodyneProxies.xml b/VelodyneProxies.xml
index afeb6e5..34ccf78 100644
--- a/VelodyneProxies.xml
+++ b/VelodyneProxies.xml
@@ -1,24 +1,14 @@
 <ServerManagerConfiguration>
   <ProxyGroup name="lidar_interpreters">
     <Proxy name="Velodyne"
-           base_proxygroup="internal_interpreter"
+           base_proxygroup="internal_velodyne"
            base_proxyname="BaseInterpreter">
 
-      <StringVectorProperty name="LidarReader"
-                            number_of_elements="1"
-                            override="1"
-                            default_values="VelodyneLidarReader"
-                            information_only="1" />
       <StringVectorProperty name="LidarPoseReader"
                             number_of_elements="1"
                             override="1"
                             default_values="VelodyneLidarPoseReader"
                             information_only="1" />
-      <StringVectorProperty name="LidarStream"
-                            number_of_elements="1"
-                            override="1"
-                            default_values="VelodyneLidarStream"
-                            information_only="1" />
       <StringVectorProperty name="LidarPoseStream"
                             number_of_elements="1"
                             override="1"
-- 
GitLab