From c295a065dc10e84189a23e9ae757d5e5099a0698 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Couble?= Date: Mon, 18 Sep 2023 13:35:37 +0200 Subject: [PATCH 1/4] [fix] Add missing vtkLidarPacketInterpreter includes --- Application/Qt/ApplicationComponents/lqOpenPcapReaction.cxx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Application/Qt/ApplicationComponents/lqOpenPcapReaction.cxx b/Application/Qt/ApplicationComponents/lqOpenPcapReaction.cxx index db8f9521a..db9d34e5f 100644 --- a/Application/Qt/ApplicationComponents/lqOpenPcapReaction.cxx +++ b/Application/Qt/ApplicationComponents/lqOpenPcapReaction.cxx @@ -1,5 +1,7 @@ #include "lqOpenPcapReaction.h" +#include + #include #include #include -- GitLab From 20d2e6b0084255da74dfab397ce1d2ca6c9c4734 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Couble?= Date: Mon, 18 Sep 2023 13:36:31 +0200 Subject: [PATCH 2/4] [ci] Enable warning on One Definition rules --- .gitlab/ci/configure_ubuntu22_debug_tidy.cmake | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab/ci/configure_ubuntu22_debug_tidy.cmake b/.gitlab/ci/configure_ubuntu22_debug_tidy.cmake index e3b2792bc..4e2cb7fca 100644 --- a/.gitlab/ci/configure_ubuntu22_debug_tidy.cmake +++ b/.gitlab/ci/configure_ubuntu22_debug_tidy.cmake @@ -4,5 +4,4 @@ include("${CMAKE_CURRENT_LIST_DIR}/configure_ubuntu22_debug.cmake") set(PARAVIEW_ENABLE_PLUGIN_HesaiPlugin OFF CACHE BOOL "") # Treats warnings as errors -# Note: -Wno-error=odr as one definition rule warning triggered by fpos_t only on ci -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall -Wextra -Wno-error=odr" CACHE STRING "") +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall -Wextra" CACHE STRING "") -- GitLab From 0bf751a33e2fab348d6507931634d000d031e237 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Couble?= Date: Mon, 18 Sep 2023 15:09:54 +0200 Subject: [PATCH 3/4] [submodule] Bump VelodynePlugin b396af9 Merge branch 'fix/fixFposIncludeWarning' into 'master' --- Plugins/VelodynePlugin | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Plugins/VelodynePlugin b/Plugins/VelodynePlugin index 2e55482ef..b396af9e9 160000 --- a/Plugins/VelodynePlugin +++ b/Plugins/VelodynePlugin @@ -1 +1 @@ -Subproject commit 2e55482ef8dd17e4b1740e740f4bd93e2f4d6d6f +Subproject commit b396af9e91d337d7b36666442a56e738f5162f59 -- GitLab From cf77c01d4b1035954413f1c2dfe293392f201cf2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Couble?= Date: Mon, 18 Sep 2023 15:19:36 +0200 Subject: [PATCH 4/4] [submodule] Bump LVCore e303310f Merge branch 'fix/fixFposWarningMessage' into 'master' --- LVCore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LVCore b/LVCore index 399d6f79e..e303310fb 160000 --- a/LVCore +++ b/LVCore @@ -1 +1 @@ -Subproject commit 399d6f79edbbf88309056a0f1652080d93f0788d +Subproject commit e303310fb34f7e331238a3b450a3390d28b436aa -- GitLab