Commit 81f1c158 authored by Jerome Dias's avatar Jerome Dias
Browse files

[fix] Use PythonQt fork instead of a patch.

According to recommendations in SuperbuildMacros, patches should not be
applied to projects sourced from Git repository. That's why we get
sources from a PythonQt fork instead of using the superbuild_apply_patch
function.
parent dc06d2bc
From 1ccbae62bb5e704c61462d8ce49b43fa6ad0badd Mon Sep 17 00:00:00 2001
From: Jerome Dias <jerome.dias@kitware.com>
Date: Mon, 26 Oct 2020 16:24:44 +0100
Subject: [PATCH] [fix] disable _POSIX_THREADS unset.
In unix platform since python 3.7, _POSIX_THREADS need to be defined. If
it's not the case the native threads type is unknown and a build error
is returned in pythread.h.
---
src/PythonQtPythonInclude.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PythonQtPythonInclude.h b/src/PythonQtPythonInclude.h
index be8d0e0..dc9c7f1 100644
--- a/src/PythonQtPythonInclude.h
+++ b/src/PythonQtPythonInclude.h
@@ -35,7 +35,7 @@
// Undefine macros that Python.h defines to avoid redefinition warning.
#undef _POSIX_C_SOURCE
-#undef _POSIX_THREADS
+// #undef _POSIX_THREADS
#undef _XOPEN_SOURCE
// Undefine Qt keywords that conflict with Python headers
--
2.17.1
......@@ -11,8 +11,4 @@ superbuild_add_project(pythonqt
# specify the apple app install prefix. No harm in specifying it for all
# platforms.
-DMACOSX_APP_INSTALL_PREFIX:PATH=<INSTALL_DIR>/Applications
)
if (UNIX)
superbuild_apply_patch(pythonqt fix-native-threads "Disable _PTHREAD unset to get native threads type.")
endif ()
\ No newline at end of file
)
\ No newline at end of file
......@@ -11,7 +11,7 @@
# endif()
superbuild_set_revision(pythonqt
GIT_REPOSITORY http://github.com/commontk/PythonQt.git
GIT_REPOSITORY https://gitlab.kitware.com/LidarView/pythonqt.git
GIT_TAG patched-8)
set(PARAVIEW_VERSION 5.6)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment