Refactoring of vtkPatch situation
LidarView uses some improved VTK classes, featuring work that never made it in the official VTK repo.
The files in question are all under the LidarPlugin/vtkPatch/
directory.
Here is an overview of the situation:
-
vtkCustomQuaternion.*
Covered in vtk/vtk@9079da1b merged in VTK8.0.0. Since the recent upgrade to (PV56 with VTK 8.2.0), this has been taken care of in 104ef8e8
-
vtkCustomQuaternionInterpolator.*
Covered in vtk/vtk@b265abed merged in VTKrelease, did not make it in a Release tag (As of Feb2021). It should be removed when it makes it to a VTK release tag and LidarView catches up to this version. Has been taken care in !375 (merged)
-
vtkCustomPiecewiseFunction.* and vtkCustomTupleInterpolator.*
Covered in vtk/vtk!2582 (closed) but has missing work, present only in LidarView, and the associated Test has to be tweaked. Retried in vtk/vtk!9792 (merged) merged in VTK release. Has been taken care in !387 (merged)
Additional Concerns:
-
vtkCustomTransformInterpolator.* , not present in vtkPatch it has a simillar naming convention. It seems that those improvements are specific to LidarView and would not make it inside VTK itself. Proper Renaming is advised. (It adds more interpolation methods, just like the previous MRs)