1. 25 Jan, 2019 1 commit
    • Ben Boeckel's avatar
      Help: prefer commit hashes in commit references · 939dc9a5
      Ben Boeckel authored
      The logic is that the describe output is readily available using `git
      tag --contains` locally. In addition, for a hypothetical commit which
      landed in both v3.9.4 and v3.10.1, there is no "better" tag to refer to.
      since v3.10.0's relation to such a commit is unclear either way.
      Also mention that a `Fixes` trailer is preferred if the mention is just
      to indicate a commit which introduced an error rather than writing a
      complete sentence about it.
  2. 24 Jan, 2019 4 commits
  3. 23 Jan, 2019 11 commits
  4. 22 Jan, 2019 19 commits
  5. 21 Jan, 2019 5 commits
    • Vitaly Stakhovsky's avatar
    • chuck cranor's avatar
      Compute implicit include directories from compiler output · 5990ecb7
      chuck cranor authored and Brad King's avatar Brad King committed
       - CMakeParseImplicitIncludeInfo.cmake: new parser that extracts the
         compiler's include path from verbose output.  If the parser cannot
         parse the output, we fall back to the old behavior.  On osx we skip
         over framework directories (handled elsewhere).
       - CMakeDetermineCompilerABI.cmake:
           - use verbose flag in try_compile for ${src}
           - use new cmake_parse_implicit_include_info() to attempt extract
             implicit include directory path and if successful set
       - CMakeCCompiler.cmake.in and CMakeCXXCompiler.cmake.in - preserve
         CMAKE_${LANG}_IMPLICIT_INCLUDE_DIRECTORIES value between runs in
         the same way CMAKE_${LANG}_IMPLICIT_LINK_DIRECTORIES is preserved
       - Tests/RunCMake/ParseImplicitIncludeInfo: tests for parse
         based on the older Tests/CMakeTests/ImplicitLinkInfoTest.cmake.in.
         The test runs a set of verbose compiler outputs collected from
         various machines through the parser and checks the results.  New
         compiler files can be added by dropping input/output files in the
         ParseImplicitIncludeInfo/data subdirectory and then adding the new set
         of files to the ${targets} list in ParseImplicitIncludeInfo.cmake.
         There is a helper CMakeLists.txt in ParseImplicitIncludeInfo/data
         that can help with the generation of test input files.
         NOTE: the standard cmake pre-commit hook rejects verbose compiler
         output with trailing spaces... you have to manually edit them out.
         This shouldn't impact the test.
      Note that both the parser and the test code can use CMAKE_${LANG}_COMPILER_*
      variables such as ${CMAKE_CXX_COMPILER_ID} to decide how to parse
      verbose compiler output.  For the test code, this requires us to
      save the variables values in the test input files.
      Fixes: #16291
    • chuck cranor's avatar
      CMakeDetermineCompilerABI: set locale to C for try_compile() · d751d2d2
      chuck cranor authored and Brad King's avatar Brad King committed
      Have CMakeDetermineCompilerABI set the locale to C before calling
      try_compile().  This is for the implicit include path parser to
      keep all the verbose compiler messages in English so we can parse
      it.   See #18784 for discussion.
    • Brad King's avatar
      CMakeDetermineCompilerABI: pass verbose flag during compilation · c765ae49
      Brad King authored
      Default to the same flag that is used for verbose link information, but
      provide another internal platform information variable to use a
      compilation-specific variant.  Populate it for CUDA where we use a
      different compiler for compilation and linking and therefore need
      different flags.
      Co-Author: Chuck Cranor <chuck@ece.cmu.edu>
    • Brad King's avatar
      try_compile: Preserve special characters in COMPILE_DEFINITIONS · 8c5221fb
      Brad King authored
      When generating the `CMakeLists.txt` file, we pass the values given
      to our `COMPILE_DEFINITIONS` option in an `add_definitions` call.
      Pass them as bracket arguments to preserve special characters
      like `#`.