GitLab

Brad King authored Jun 09, 2020 and Kitware Robot committed Jun 09, 2020

796b4473

 FindOpenSSL: Fix OpenSSL 3.0.0 version extraction
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4860

Craig Scott authored Jun 09, 2020 and Kitware Robot committed Jun 09, 2020

855ed801

 Help/dev: Update CMake Review Process document for GitLab CI
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4865

We have replaced use of `buildbot` with GitLab CI.  Update the
relevant section of our review process documentation.

Craig Scott authored Jun 09, 2020 and Kitware Robot committed Jun 09, 2020

6b751752 Help: Add example for REQUIRED_FILES test property
61139c91

 Help: Add example for DEPENDS test property
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4853

Brad King authored Jun 08, 2020 and Kitware Robot committed Jun 08, 2020

f8b2d8f1

 ci: remove unused sccache download script
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4866

Billy Brumley authored Jun 06, 2020 and Brad King committed Jun 08, 2020

Fix the regex syntax added by commit 61d746e5 (FindOpenSSL: Detect
OpenSSL 3.0.0, 2020-05-27, v3.17.3~1^2).  Add missing escapes.
Test with `openssl-3.0.0-alpha3`.

While at it, also unset a temporary variable after use.

Brad King authored Jun 08, 2020 and Kitware Robot committed Jun 08, 2020

f859e6f8

 CPack/IFW: Fix documentation typo: REQUARED
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4862

Brad King authored Jun 08, 2020 and Kitware Robot committed Jun 08, 2020

3fd07d30

 VS: Enable DOTNET_TARGET_FRAMEWORK properties all target types
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4854

Brad King authored Jun 08, 2020 and Kitware Robot committed Jun 08, 2020

7e2f8646

 FindCUDAToolkit: Fix cudart not found status message
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4861

Raul Tambre authored Jun 06, 2020 and Brad King committed Jun 08, 2020

This ended up after the searching after commit dc2eae1f (FindCUDAToolkit: Factor
out discovery code into a separate file, 2020-04-22).
Move it back to where it was and should be.

Brad King authored Jun 08, 2020 and Kitware Robot committed Jun 08, 2020

0f88b7a5

 CUDA: Fix Clang depfile flags when simulating MSVC
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4863

Raul Tambre authored Jun 07, 2020 and Brad King committed Jun 08, 2020

__compiler_clang() doesn't call __compiler_gnu() if we're emulating MSVC. Thus
CMAKE_DEPFILE_FLAGS_CUDA remains unset and compiling doesn't work, due to NVCC
dependency injection workaround in CMakeCUDAInformation.cmake, which triggers
for Ninja if they're not set.
Always set the depfile flags to fix this. Most other compiler modules seem to
do the same.

Brad King authored Jun 08, 2020 and Kitware Robot committed Jun 08, 2020

4eaf1ef4

 CUDA: Fix checking working architectures with specifiers
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4856

Brad King authored Jun 05, 2020 and Kitware Robot committed Jun 05, 2020

5bf9a290

 CUDA: Fix CUDA_ARCHITECTURES policy CMP0104 check in try_compile
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4857

Since commit e98588aa (CUDA: Add CUDA_ARCHITECTURES target property,
2020-03-12), `CMAKE_CUDA_ARCHITECTURES` is both initialized and required
by policy CMP0104's `NEW` behavior.  Inside a `try_compile` project we
use `cmake_minimum_required(VERSION ...)` with the current running
version of CMake.  Now that our version number is 3.18, `CMP0104` gets
set to `NEW` in the `try_compile`.  If the outer projects does not set
the policy then `CMAKE_CUDA_ARCHITECTURES` is not available and the
`try_compile` fails to generate.

Teach `try_compile` to check the outer project's policy status and
set policy CMP0104 to `OLD` if needed to match.

Fixes: #20794

Release versions do not have the development topic section of
the CMake Release Notes index page.

Brad King authored Jun 05, 2020 and Kitware Robot committed Jun 05, 2020

389ca182 Help: Organize and revise 3.18 release notes
ab6b5c01

 Help: Consolidate 3.18 release notes
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4845

We don't distinguish real/virtual architectures during compiler detection.
If the user passes -DCMAKE_CUDA_ARCHITECTURES="70-virtual" we'll test with only
the real architecture.
If it works "architectures" will end up as "70". We check equality using
strings, so this fails and we incorrectly throw an error.
Fix this by comparing against CMAKE_CUDA_ARCHITECTURES with the specifiers
stripped.

We need to deduplicate tested_architectures for the same reason in case the
user specified something like "70-real;70-virtual".

KonanM authored Jun 04, 2020 and Brad King committed Jun 05, 2020

This makes them compatible with `VS_PACKAGE_REFERENCES` and, in
particular, fixes nuget package references in combination with install
targets.

Fixes: #20764

Brad King authored Jun 05, 2020 and Kitware Robot committed Jun 05, 2020

9f392389 libarchive: Map fixed-size integer types from KWIML as typedefs
d20bf471 liblzma: Map fixed-size integer types from KWIML as typedefs
92c4316d KWSys: Hard-code try_compile results on Windows
2bc89f1a cmSystemTools: Hard-code try_compile results for Windows
d350d466 libarchive: Hard-code try_compile results for bundled dependencies
bf60ac24 Source: Assume elf.h does not exist on Windows
f408cc2c expat: Remove unused try_compile checks
6c4f3dcd

 Utilities: Update hard-coded try_compile results for third-party libraries
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4848

Brad King authored Jun 05, 2020 and Kitware Robot committed Jun 05, 2020

e219527a VS: Use StdOutEncoding for VS 16.7 Preview 3 and above
8a7ad923

 VS: Extract instance version from VS Installer
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4847

Brad King authored Jun 05, 2020 and Kitware Robot committed Jun 05, 2020

ef816610

 ARMClang: allow fallback to -march and correct setting of --cpu flags
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4850

Brad King authored Jun 05, 2020 and Kitware Robot committed Jun 05, 2020

b1243201 CUDA: Don't RunCMake generate separable compilation tests on Clang
1b4c6905

 CUDA: Throw error if CUDA_SEPARABLE_COMPILATION is ON when using Clang
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4827

Brad King authored Jun 03, 2020 and Kitware Robot committed Jun 03, 2020

922cd3af ci: fix the project detection for CDash submissions
c5b07280 gitlab-ci: add jobs for reproducing the release binaries
45f2786f Release/linux: remove explicit LANG setting
c540fcaa Sphinx/create_identifiers: handle qhp contents as utf-8
e237fc65 Sphinx/create_identifiers: use `not in` not `not _ in`
0aa061f6

 Sphinx/create_identifiers: remove unused import
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4852

Brad King authored Jun 03, 2020 and Kitware Robot committed Jun 03, 2020

f65ba960

 gitlab-ci: Update Windows builds to MSVC 19.26
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4851

Brad King authored Jun 03, 2020 and Kitware Robot committed Jun 03, 2020

cbe80818 gitlab-ci: support Windows jobs which support concurrent builds
d3e02f1a

 gitlab-ci: support macOS jobs which support concurrent builds
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !4849

Refactoring in commit ade3b16e

 (libarchive: Use KWIML to get
fixed-size integer types, 2020-06-01) accidentally changed the method of
defining `int#_t` types from `typedef` to `#define`.  Change it back to
`typedef`.
Reported-by: Rolf Eike Beer <eike@sf-mail.de>

Refactoring in commit 12e7bfcb

 (liblzma: Use KWIML to get fixed-size
integer types, 2020-05-25) accidentally changed the method of defining
`int#_t` types from `typedef` to `#define`.  Change it back to
`typedef`.
Reported-by: Rolf Eike Beer <eike@sf-mail.de>

It shouldn't be needed anymore now that the Sphinx scripts are reading
UTF-8 content explicitly.