Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Eli F-F
CMake
Commits
7d222039
Commit
7d222039
authored
Mar 21, 2017
by
Ben Boeckel
Browse files
Help/dev: mention how the robot performs its checks
Fixes: #16264.
parent
48dc2d12
Changes
1
Hide whitespace changes
Inline
Side-by-side
Help/dev/review.rst
View file @
7d222039
...
...
@@ -65,9 +65,14 @@ The "Kitware Robot" (``@kwrobot``) automatically performs basic checks on
the commits proposed in a MR. If all is well the robot silently reports
a successful "build" status to GitLab. Otherwise the robot posts a comment
with its diagnostics. **A topic may not be merged until the automatic
review succeeds.** The MR submitter is expected to address the robot's
comments by *rewriting* the commits named by the robot's diagnostics
(e.g. via ``git rebase -i``).
review succeeds.**
Note that the MR submitter is expected to address the robot's comments by
*rewriting* the commits named by the robot's diagnostics (e.g., via
``git rebase -i``). This is because the robot checks each commit individually,
not the topic as a whole. This is done in order to ensure that commits in the
middle of a topic do not, for example, add a giant file which is then later
removed in the topic.
The automatic check is repeated whenever the topic branch is updated.
One may explicitly request a re-check by adding a comment with the
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment